From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 089F31B1F2 for ; Wed, 9 Jan 2019 08:15:59 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 46E08100074; Wed, 9 Jan 2019 07:15:58 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 9 Jan 2019 07:15:51 +0000 To: Ferruh Yigit , Thomas Monjalon CC: , Declan Doherty , Chas Williams References: <1539157900-6208-1-git-send-email-arybchenko@solarflare.com> <1545200580-15467-1-git-send-email-arybchenko@solarflare.com> <10d9a6ab-d2b3-69a8-9155-2c8a50079564@intel.com> From: Andrew Rybchenko Message-ID: Date: Wed, 9 Jan 2019 10:15:47 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <10d9a6ab-d2b3-69a8-9155-2c8a50079564@intel.com> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24348.000 X-TM-AS-Result: No-3.893900-8.000000-10 X-TMASE-MatchedRID: 8+bhjh9TQnEOwH4pD14DsPHkpkyUphL9FuNF4lJG6xvxxaAXDrCns9yi JF4Y8A5bahX4ipyY+l5BFJQa5SX9rPQYZJBBoF8R3FqOVb7PDELEGBoHKd3a+Ss/NM02Lj98642 uCOdFG25D+jzLG/8tD+kj+9vm/sSGn6xXepMP3Wfuykw7cfAoIILLh2/Jcc7eax+0dEYaKwwL3J nlO2X0PfekXIoW8BAcIeWOmF7CbXMrYPqmZqtV/xWCVBr+Ay98zSnbR3NwN1wHiwiF9OOogUqyU ztVRoTBdvgGbsWpCcvPX7sUkKqkssgNYoWONkdvL4+sB3yBsckIUQiRW/XLrHlQgJBy8EXjxTPN 0i7ijGH3aCtTBCBhl3k48PxckV+kTX7PJ/OU3vKDGx/OQ1GV8qu+08oqCcwYYGOlXVLkspXXoj8 0jaeWvV4IOroDEQH2vWhKgIPVXu+aRYvJaPUf8C9os4AVTOtil2goFqTeWN8EvsTo4X8INi+4b4 HmlVB568Lk5NNLiMZKaQImDYjEJDpVEKnuxkkpPF4IeEM8rtcxV7FvfpQ/8m7Zw9m/tEsp1sO0v PiGApH+Zbd1uQWTtgHii3a3gRUpwL6SxPpr1/I= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--3.893900-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24348.000 X-MDID: 1547018159-RvMKqVqf14zX Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v1 0/3] ethdev: document more retained across restart X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2019 07:16:00 -0000 On 1/8/19 5:52 PM, Ferruh Yigit wrote: > On 12/19/2018 6:22 AM, Andrew Rybchenko wrote: >> The patch series tries to improve documentation of what is retained >> across default restart. > Overall makes sense to add below items into retained list, only concern if is > there any PMD conflicts with these information, they should either updated with > this patch or at least notified about expectation change. From my point of view it is just clarification of the required behaviour. MTU is required because of flag which may be used to advertise that it is impossible to change in started state (otherwise the behaviour for different PMDs will be absolutely different). Default MAC is just cosmetics because of MAC address list is already mentioned and the only goal is to highlight since these are different features from the feature list point of view. All-multicast is a part of Rx mode. In fact I recall that net/bonding does not preserve all-multicast (CC maintainers). If there is an agreement to fix it, I can take a look - it should not be hard to fix. In general I think that notification is sufficient in this case. >> Andrew Rybchenko (3): >> ethdev: advertise MTU as retained across device stop/start >> ethdev: advertise default MAC as retained on device restart >> ethdev: highlight that all-multicast is retained on restart >> >> lib/librte_ethdev/rte_ethdev.h | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >>