From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 4EF821B7DB for ; Tue, 24 Oct 2017 17:18:33 +0200 (CEST) Received: by mail-wr0-f194.google.com with SMTP id g90so21048761wrd.6 for ; Tue, 24 Oct 2017 08:18:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=M6F98JH/x+wn7tgMBky9ElJ+KNPNycD4axu7lEhtI8o=; b=L8YynrrDwYsBboKSEpwNZu+LCq6scsW+LYrlRVF300YrTv6MzRyDmIkkucqH9G8EWO K2TpMvUTYmCLHi5vcMuWCnlGm1//Az6prVz6Oa8V3N+nrlXeENxUxXEyrkb5hCouBRQA W1azYIe2F86bgGfUTS+WAooyUGLb5onNNrdkhRMLM5UHQHksucchTcBBPnmlWFCD9Q07 +RFhY0qZKnWzNFnDg0KRuZ4KfUvtXe8uZlw1TT7mD8ExMPOsP+3biyf7hdLb4vf/7ECY eCpWOeYJtV8/m9SG0lg/2vqiiWHLMP1L/rR/PM4nugkowaSpegmL2inVTiPGIPH5KZ0A 3RQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=M6F98JH/x+wn7tgMBky9ElJ+KNPNycD4axu7lEhtI8o=; b=dMk/u6tWUVT70JSyWZ4G+hxd1pf2XsJ28I9gpFB9QucxdwBKdPclhM3Cw3exrJrYOn eGGZaxpJhCk+a7qnm5l4CMcPL/j9FurulQKfnrCtOoUabbdAnUMFAcVxZ3ESuyAj2c7v mRxA/HmsiNOwi71B46z8U9VVUjn/E1uQeLSfxoOstcc6mCWBnsywY/PD8HnWWNabQab6 zXaHroUTfVFnFeLgITaZ6LBp/pF/R5ZOBzvr/xf+5DZMfg8x616ByulzHETrEbWKmxbg YD5YAG2zAgAOTvHEgsMl8+BjaVkI2heu8oNAiL790qHSjFU58imHX1yd1st/Lmb/hT/q YG+g== X-Gm-Message-State: AMCzsaX/nwy9cpiehNU7HyLSMaGN/fpcbwAfa6dq6rXIRD5RuCycZWbz s3MjGtwiygMzO2v1isSV6DUKOsGL7Q== X-Google-Smtp-Source: ABhQp+TZoN83fay6ee3EWhfkKZb8ZF+V7UIw5NzZcpZb/LGmLltdCP0XfNrbuQVWwvnKCkv/OUXluw== X-Received: by 10.223.132.163 with SMTP id 32mr1300124wrg.218.1508858312831; Tue, 24 Oct 2017 08:18:32 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id v23sm637300wmh.8.2017.10.24.08.18.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Oct 2017 08:18:32 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Yongseok Koh , Adrien Mazarguil Date: Tue, 24 Oct 2017 17:18:16 +0200 Message-Id: X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH v3 5/7] net/mlx5: fix mark action with drop action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2017 15:18:33 -0000 Marking a packet which will not be received by the NIC is useless, even if this action remains possible, it blocks the creation of the flow counter which embed a mark action to a drop queue to be created. Fixes: 31ba9997f11a ("net/mlx5: fully convert a flow to verbs in validate") Signed-off-by: Nelio Laranjeiro Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 96a753e8d..13b78ce9b 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -786,6 +786,8 @@ priv_flow_convert_actions(struct priv *priv, goto exit_action_not_supported; } } + if (parser->drop && parser->mark) + parser->mark = 0; if (!parser->queues_n && !parser->drop) { rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_HANDLE, NULL, "no valid action"); -- 2.11.0