From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B35F7424A3; Fri, 27 Jan 2023 16:38:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A5E3640150; Fri, 27 Jan 2023 16:38:48 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2042.outbound.protection.outlook.com [40.107.92.42]) by mails.dpdk.org (Postfix) with ESMTP id BDDFB40146 for ; Fri, 27 Jan 2023 16:38:46 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QNb2w7ivNakqo3HoULzFsONJoE0efgt584MOroAaPqUJm48ZV0oKZnF4FZqUGfKXiJZiBUrM7o0XLZnF6GathHkgr4L+F8iYCNnkBXNXt79mhvK2z3VE1k+3sfn6V/vq2S3Jca+JDiK2VxW33fazgW9wVpQdgyj98dtQnYoo8EdUldU/HHeQ+ObOHdCZygxnH3e06QYuzMTpsEfxhlsBXYyIcYpurNl6SmELrrB7eWbulqyYEnoDSTLg5Ru8cr4XZ9lVMlV5Sql5f67srkZeor0rd4DA/QSB0q5k8bvdpHrvHdHmkb0ZuxTGkuS1gEmD2BOKuN+8/O8LvS6mZ2phPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PAsWA10XU87/R2Menqy/ii8olXP7CFKZaOFcm5n1p7c=; b=TMrLUwVnj7/PEuC3dTyMehqDvbNNRazY6XJCo8YSdSDvj8UuJBwZ7JmkG1yWaw/Z9m8zaGn3yiFPHGdZPNBpWcEzhsR8to5JmRf6dyzeL734Mcs0tIrf1+FKjGZCZ9iLwvIzhuwcOeXPnXmlcxPQgNmJ5NBftoWI6U1obagHH/r/lwrxlvXKe12X9C/akzPH+XC5nrJapfOUbq22ly6Gp/f2HEL+Q5cB8teRvjiHZnTifu9pdFfE7GHRNRfHSCKEqDyiuGBoES0GS1Sg7nTL10A2Lg8eT7/wJPCfpMBq9qmK3WkNdSqyqJv88xDyOX1Zs3ed4BKJQkB1DMN7D16d9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PAsWA10XU87/R2Menqy/ii8olXP7CFKZaOFcm5n1p7c=; b=aEKvxJMKlrVjaPYnSDqAlw+xvmcxpKTpArVdBGE2a4agMLRKuMRzSvPzmSO65ympY8obgcznLCWDcmtscLLOni+GxuKl4KREISWYVekRh+kyXGWPaGi7o913cgH+8i9WkjR/DnxJGeUt1zlIkvOz3d9qsdj1LPapkb+iScataBU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH3PR12MB7643.namprd12.prod.outlook.com (2603:10b6:610:152::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.22; Fri, 27 Jan 2023 15:38:43 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%8]) with mapi id 15.20.6043.022; Fri, 27 Jan 2023 15:38:43 +0000 Message-ID: Date: Fri, 27 Jan 2023 15:38:37 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: Jiawen Wu , dev@dpdk.org References: <20230118060039.3074016-1-jiawenwu@trustnetic.com> <20230118060039.3074016-9-jiawenwu@trustnetic.com> From: Ferruh Yigit Subject: Re: [PATCH 8/8] net/txgbe: add SFP hot-plug identification support In-Reply-To: <20230118060039.3074016-9-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P302CA0023.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:2c1::15) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH3PR12MB7643:EE_ X-MS-Office365-Filtering-Correlation-Id: 08f8f9fe-3da6-4a7d-fdfd-08db007c91eb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PQXASzAPuMk6vqUWRlLrWhBet3wuDXbGEW6V5drJKRV/6umaRv+fvDaRSUiVpxa6nRr+ythC7hB5Sb+KVmJ3ToWijPhzQAMBXp2B1x/eltAIfV00c64OaqJAhEaJrfwB40W46f6V7fCOURNsIQmzwX+PjZLyrSxXPbXNq38WQ9W4WgeXVbMH5WXhDoBxy8Z5v4l+4Od/0p0UIn3vNIhvlSNQSbxNpgjcWmMb4U/zd6hpW7k+e0/hUFBpDhxcvu9NwC6P13VAKKmkSRSTrTBVL8w2CXqZUeKcDvGEw38ZUTVZhm85CfCaOP0Nn7uA1CNW9CG+MpdsmtW3rhr4XGr9+BD4oYmYR4WPBh91hddJjFrlS/1WNk7xLowGj06JJNMs+A1s+jaGH/l6HSSRwORl3AGvz9aSngt5Ok8rt9SFhpd821XEf9UUpTt5eAIVqI+kZwtaSuOEtIls0It161tLGyPet2st7UrEDerT0jk+XlfBZfStFmso20bA84hC/Y/rL2FWmKqhy8qzkjowlXvasyNYHLGqyZG+I3eRJDiGJbtM+w3PgQl7AKQNn3F12pVttXUAxti3L2YgpsTn4UHvomvI7chsXdLSeIe6No5ZndDyts0t4GOZC87N4qB4cm65BqJkf9YPzaLU/LPIfCHP2XthJqyvL0R9pbToACp5utPJUhnDJOefIhl2pptlOWcJrE3ebtlfXB1ZpBEy+Q0Qea45sCMKaD8OI+lhJ50aC+Y= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(39860400002)(346002)(366004)(136003)(396003)(376002)(451199018)(4744005)(86362001)(44832011)(5660300002)(41300700001)(6512007)(31696002)(2616005)(316002)(186003)(8676002)(26005)(8936002)(36756003)(66476007)(66946007)(66556008)(478600001)(53546011)(6506007)(38100700002)(6666004)(31686004)(6486002)(2906002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUw3MmQvbi9SUjkzVVJHYmVqSkxGNmxzMjhIWWJwTFBpRjJpZFUvTVFBcER2?= =?utf-8?B?Snd4aUY4UERVMUFMaFptY2lYL21OcnJ3ODA1ZWh2VmJzWkRKbysyK1ZHQ0Vu?= =?utf-8?B?b2lkc0RIUXA4WlhuNDVGQW1Fbmh3NjEwYnNiQWVBcFNPSkdMUjB2QU9LR0lC?= =?utf-8?B?cjFrVzh6WkNqVUtZM0VKVkpkYXNtbEZQNFpDY0pQbTNNR09mVklCQkdqTGxP?= =?utf-8?B?akl0RlFGQ1JyczlFQWErNW0wcG9QOE9kZUhqNkt6ZTgwVGNzWTFzR3lCUFMy?= =?utf-8?B?YlZVMnY4QSs4NnJNSGRUMkFrK2x6UGd2bzBWTE1ybzJ4OGhtNHErcGlkTlNW?= =?utf-8?B?K3hvc0VtR2JMQjFWMGtudnR1cmQ5TlBqMWg5S3VzV3lzcHN3dUxkQ2dRT2kz?= =?utf-8?B?byt3Z08zQ2wrSWgvUnptcTF5b1o4WFhPK0FMVHUyWWJXZkhsRTdxbDFLOUpY?= =?utf-8?B?c3lubndZdFZhclF1ZG5MYzltSXV3b1l6c0dPbEVRU2Rvam1wM1hKa3pyQ1E0?= =?utf-8?B?MlJJbktWSWora1RDbXJyN1J1S0FtQ1pTYldHeHJzNitYT2xWMTF4ekxoeGox?= =?utf-8?B?QmxKKysyTURzWjkwK3JHeWdHQXN3VjZ4dEUxWUNNME54b0RVRXBSQWJQZWp2?= =?utf-8?B?TGxvbjRoMG1CME1EaFJFRUdKWjQrbVVEb1pyZDY3UlNNRnUzdGRpS1FYdm5a?= =?utf-8?B?bEE1RjdROHFQWFZ4US9tQUgrQ0hUbjBPTWIrUmhKS1lMd085d2FhS0IrNHha?= =?utf-8?B?T2RFVzdxeHVKWFNlcGdkekdmQTJDbUFoM1lHbVBUT2lLL0VuRi8yNi9jMkE5?= =?utf-8?B?NEpObW5pY29FT2xQMGJYMmE1Q3lWa1JHSkUvUG1ERVh4akJTYy82NWs2SUpt?= =?utf-8?B?Z2VLWC80WXp6UzNWWmoyZ3pjelVub2ZsL3hYekVQNFZZZ3JCZWdLdnZya0k5?= =?utf-8?B?S1pUL0UzR0JHaS9sZGVFNVpCV3ZmQzVKT2pFMWFhaWp6cTNsdkVka1o5VDMr?= =?utf-8?B?QndLUHRqR2Z3clhkeVJRUTNzQWJnUExWSVczQ2pDdWpZR1FqY0dhZDZ1NW5U?= =?utf-8?B?KzFFeGxZY3JPa1EwY0EwWWdxMFhvK1VhVVU0d296b0piL05OYXIvYmV1clhD?= =?utf-8?B?NC9kU3BKR1h5NDNhUHNkUGFXNmU2TkkzVnpsYWFIOFkyUDVDb05mbFVZRmc0?= =?utf-8?B?YTZ3WVlRaS8xOVp0Z1VGWXZ2OGJ3b2dpaGloMUxaQ0pmc0NqT3NBaFdiRFZt?= =?utf-8?B?NUtZVStLOUlCNWVYUndNNkEvUG5Zb0RIbmhFMWgvRzE5U3FDSTEzSWhaL3A1?= =?utf-8?B?dDMwY0xVc2FhTWhobVFjMnkxd1dEMGlQY0tQZnBLR3h3ZEVTSmIzUTZ4ZzVx?= =?utf-8?B?a0hVNlNLdnNOL2NEV2hoNnd0ZllyZUFVNnlncFNlUXdyUDRuUTIvMjR6VDVq?= =?utf-8?B?MXR4K0IwYlZXTzhwczh2eU1Pcis5L24wUUIyUXo0N1I0TzhVRGozb0tWWDZq?= =?utf-8?B?Y0o4YnZTdHFpNmk4VTZua250bEZ1UWkvandFazFKbzV3akpMbWgwczRnQjJ4?= =?utf-8?B?WDZXbm4wcm94UHdQOWI4Qm05TzVWeVk1M2tETERpYzFFWjViMzhBUWoxeWNo?= =?utf-8?B?Z05xeW90cEFyelJmRmRBODRzbDl4ejZCSXdEM0RYQ0JXRnhhWGttZmk4Z1FH?= =?utf-8?B?MkZUUXYxRkRTWEpSTk51OExtRFU1Q2tCdUo3cEJWQjY4MU02OXNvcTMwckdh?= =?utf-8?B?U2ljdHFlclFPa0kvYXVobFBpZERML1E3MG01M3pDbjdxWVNzN3Mxckg0dExm?= =?utf-8?B?d1V0UVVWR2pvVTdjWEllTUh4SjZaK1BiRlZvOVhVRzFwMWtBbktQcXNqRlli?= =?utf-8?B?K3F2UGE4NDRDSkxXeWdyK2ZaZU0yWGFqNnZ4R3QxenF3Ukd2U0RETGZ2YmNw?= =?utf-8?B?NXNsRFJ0ZHAvRThZa2MwUlRXSDRHWTVOVXlKODZac2ZrWDN5MHU0ZFh0ek5P?= =?utf-8?B?SmJ6bXpzeGRLaCtTV3UrYldsQ1VLWkVFb3pHdzFqUWtaRnlYL0MzY2tDWE1w?= =?utf-8?B?L3Z4RzNJNDl1K1N0bzRXRzE1ckk4S0lTK3BwWmFLeC9QMTd5MkF2cHI1VG9Z?= =?utf-8?Q?ywiM67/BDxJSW6wqM3ZbUJbkJ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08f8f9fe-3da6-4a7d-fdfd-08db007c91eb X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2023 15:38:42.9519 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Gu3h0MRPimVd/H0AaQwvZLxaUITm2blvKhBz6hTWyuucQwNdpVMqCVMBUwNwy8l8 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7643 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/18/2023 6:00 AM, Jiawen Wu wrote: > Support to identify the new SFP/SFP+ module when the device is started. > > Signed-off-by: Jiawen Wu <...> > @@ -2972,9 +3029,6 @@ txgbe_dev_interrupt_get_status(struct rte_eth_dev *dev, > rte_intr_type_get(intr_handle) != RTE_INTR_HANDLE_VFIO_MSIX) > wr32(hw, TXGBE_PX_INTA, 1); > > - /* clear all cause mask */ > - txgbe_disable_intr(hw); > - This change looks like a major one, is it related to the "SFP/SFP+ module"? I assume this is replace by below line [1], if this is unrelated please separate it to its own patch, and if it related can you please explain why it is related in the commit log. > /* read-on-clear nic registers here */ > eicr = ((u32 *)hw->isb_mem)[TXGBE_ISB_MISC]; > PMD_DRV_LOG(DEBUG, "eicr %x", eicr); > @@ -3000,6 +3054,8 @@ txgbe_dev_interrupt_get_status(struct rte_eth_dev *dev, > if (eicr & TXGBE_ICRMISC_HEAT) > intr->flags |= TXGBE_FLAG_OVERHEAT; > [1] > + ((u32 *)hw->isb_mem)[TXGBE_ISB_MISC] = 0; > +