From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC8F345E8E; Fri, 13 Dec 2024 10:09:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 53810402BB; Fri, 13 Dec 2024 10:09:41 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by mails.dpdk.org (Postfix) with ESMTP id 3B64440263 for ; Fri, 13 Dec 2024 10:09:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1734080980; x=1765616980; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=PRl9pUP/0e7cMLsNT1YdppY27RAqXtD/mpA1ahh28ns=; b=YZyPcy8RDC5BbyYBUc2HWmv6AvpNYx8aT9Xu+37AmfWxPjz4Qvss6eA8 6Qo9+6o9zR7fuZxRS+PxXiVcm1poJynylSeLIB1ulmZ06OV7GPQ5eprqj TG1MzcnzuYgMmVqRG5U6MSIPMiA3jifmPAUzbrUs14x3QSM9BLggGZi8u xbD4I7iR+wqFDKCvXek2g4QdGmMi1gAFEdSqez31RqmjiASRlewIvbAu/ kNHi6If8b1T1mokAsUetXLtT06difhV4RiYy4MJ0u5IIgbiwGXqkPSLIr p5KppWtsR3rfDyblBJ5N0RUy58MhFKxvjsP0CNysL9OzEV/vlm4wrV9VO A==; X-CSE-ConnectionGUID: CwA7yXmaQm2xUUdYAvW0nw== X-CSE-MsgGUID: JWDQR5juTNiFuu+0Z5It2Q== X-IronPort-AV: E=McAfee;i="6700,10204,11282"; a="38464418" X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="38464418" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2024 01:09:37 -0800 X-CSE-ConnectionGUID: +ofqbwO9QquwILiwvyPK5g== X-CSE-MsgGUID: GWNSCz80RC2HrDUWQYASNA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="119741217" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 13 Dec 2024 01:09:35 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Fri, 13 Dec 2024 01:09:25 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Fri, 13 Dec 2024 01:09:25 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.170) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Fri, 13 Dec 2024 01:09:24 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=khHvXeyOnKbZhwWdR8kW01wKGT3Ibzt2KkH3AVIrlsFYkokDV3LxgguLunfIASElkOHCFi9Zm8u8mRZe0tHaweGUKSwhCXRJKM+lfImSDCRPrrKH00qUAPxrGa1rLTwMXZ22cP5UNsN4tUUtwHRcBMtVMOpgt1RyDKJ9yKCRIcLGIdcKexEml7YvqRMclBMSFvDLCp1G3SIqha8Y+KXp34MmHSDf4UFd0MloIcvDLqyVP+DVWu/j9DdGqrmBfX/im1meV9T5YXZIn657pO/PdSY3F8PS3nTmYIIi1VyCcZxzcAuvQsA2mJ9PXLAjuqEZp0DcPwsg5OCS30ujcmlzlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tat6o+xYgiX6b0wCrXRzaE5SPSm3vlIF+N15UAh8hqE=; b=fMxhtDnXVEzOViJJglZ8Raaep0vuAVQ7SEguvgUb5r0KlqsA/9JyJA6amphOiU/bvfeXN0IPdG2A7tLJ5vbwSbtGFvZS81fHbUiIwy+JgVxeP1xrRUwJTgBoczEnbUYcPagHwfk0gSxqUZ4FcAYrX1aTWXDO4o4wnFPbm5Jrq5YoWpXqqjO7kwhch3HqWMmyHQntJOSsy/nCmKiA8MA2IykA+QE8IGdqiyGhEXZZIZRpVFsWFfw9fnkKp4ScGOnzHESxz029aILVkp2o55wzqt3+/TXlTl82kuLbSctftTm8X8p6lHon7B6FMSfiokLZ7M5BKSD59MlRY3rZPqn6Dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by LV8PR11MB8605.namprd11.prod.outlook.com (2603:10b6:408:1e5::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8251.17; Fri, 13 Dec 2024 09:09:09 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::21e4:2d98:c498:2d7a%3]) with mapi id 15.20.8251.008; Fri, 13 Dec 2024 09:09:09 +0000 Message-ID: Date: Fri, 13 Dec 2024 10:09:05 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/4] net/e1000: prevent crashes in secondary processes To: Stephen Hemminger CC: References: <3c323577ce36cf4425d2c2def85d0d6644b87dc8.1734020337.git.anatoly.burakov@intel.com> <20241212100223.2863e50b@hermes.local> Content-Language: en-US From: "Burakov, Anatoly" In-Reply-To: <20241212100223.2863e50b@hermes.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DUZPR01CA0328.eurprd01.prod.exchangelabs.com (2603:10a6:10:4ba::13) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|LV8PR11MB8605:EE_ X-MS-Office365-Filtering-Correlation-Id: 4fec8130-8607-4ad4-2210-08dd1b55cd7b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Q3h6dWVnZEFJcThlZFJrRkd4dW02eUVlNXMyWTRuUGZFdEwvcUtzSkYvTzR2?= =?utf-8?B?dkV4N2ZsV2dvcVRuWFF5am96aStaUDA2b1MwSzMrb1RvMUFyM3g5endydFJV?= =?utf-8?B?eFRPc3p3dnBvSnFtcU4rbnd6SGM1VW1XaW90NEE1ZTZWc1YraG5sSmx2bzI2?= =?utf-8?B?dm9rWTMvbUVCTHAvY3NVTStVakVwVnp0Kzh0MDB1Vk44MDY2Y0M1Y0RmNExW?= =?utf-8?B?MmFreU1mSjc2V2FKOGxGTFZva2puZ3ZPVWd4RENaNm4ralRBRmF1WTVKeTF3?= =?utf-8?B?VUdHT2ZoZlp6OVNGNW05c0dRZE1rN0NzdlgwZWt0dFBYVWo4cWhOVTQ1NDFT?= =?utf-8?B?YWs2S2RJUjIwTzZQR1FzbUcrbEFtZ0thU29TN1hONFU5ZHNLQVBxR1FWR3F1?= =?utf-8?B?cThxSlFXWW52cnhMTWVrbnFRbEt6NnN0VGpqSTB6dWdzL3BJenMrNkhpR1lk?= =?utf-8?B?QTU4Zlk3VStOL0prRlh3Rmp5RXU2SWlWQ3BHMHhBVlpKR0UzdjFFc1ZIaUtS?= =?utf-8?B?NG44MVY2SnNpVjYxMzI5M1lBOHR3eHVlQW40SmVLQ293M1c4UVdiMDRVS3VW?= =?utf-8?B?OE1zWDRROWE0ZE9EUm9uT0pZMkgrVDJMZ2hSYUNoUkhqS2N5dVhnWSswL0c5?= =?utf-8?B?Tnk2M0JhMGRMNlNFRkRTaXNWaVZoY0NiRXJiZFp4WUU1YU1zUEVYTDVvUURj?= =?utf-8?B?UFlzTnNvZGJCMElPVklIWTQ1SGRNUmhoY0ZpQVpmeGdZKzVtSVNJNkRmbExi?= =?utf-8?B?alluWlBZQmR2OXV6enRUQnBadTh4NkYyZWdXdzVWbExpVG1IMkxqYnpaRjY0?= =?utf-8?B?d1ZmVHMySms2TjNxYTJuWGZYc3pkUzVDUWUycVhER04vMFJBM3FXRjFqSnBJ?= =?utf-8?B?dmg3R052clNEbHhsUnFvRUdsVm90Uzk5R1lSQW9weWVwQWljL1dSR29qN01R?= =?utf-8?B?NTNEQ3RzVlNRTFlVemU3WlpZV3F5T0JWZHlzSEsyU0hYK2YyYXlSZ2Q4enJa?= =?utf-8?B?TWRyZFUvR0dSbkc0d0V6eW0zQ0ZkS1NGYWp3TmpPU0xJRlZzWFlwL3hZMVN0?= =?utf-8?B?U0VjT3NmVnA3ZnNlL3IwZWtBWVg0dWhOblZ1aXZjdGNsNjFoU3IvLzJlR0Vk?= =?utf-8?B?N0o5ZWpEL1QzUTcvalNmSm5RZ1JZQit5TnQvQnFheXFIQXVxU2JZZzdSSmlW?= =?utf-8?B?azZ4T1FZQmMzWERvWWhxWWcvTjh5V2NwL045bUVmUTVSVFdYdHZNT041RWd0?= =?utf-8?B?ZDdoUmJTRHdxbkpWcVM2dWJMZmtJejdWaG9TbzUvRmxPT25jTTRGaHFyb3M5?= =?utf-8?B?R0RRSnh5TXZCczdFRHNXYW1RYnVVSkFIQk4xUHZ5OGlnbHk2VlZtWllhUHBH?= =?utf-8?B?cEtIbU94SEZld08rTDVxNUFrU21lQTg3aEc2VExOQ2I5a0xDK2NobkhEeWFi?= =?utf-8?B?OTJodkZMWmdCRXViQXIwWGhOaGpzRkhIS3JCWWJwWU5QbU5UQm5pVGpPMWRD?= =?utf-8?B?SkdtWllOaGZPZjBjZVZaVjhINGNwaisrMGI5UEZ4VXh6QW92ZFFESk9sSElJ?= =?utf-8?B?WnJJU0dqTkFuOHNmN0daSFBDYnY4UWVlSFMwbVFwTSsyaFRNNnBlMEJTV2pp?= =?utf-8?B?dDJtWmY2cDVQZE9jZFZEcHcyRUdlNERSY3c2ZTZKN1RIa2h4dUFoWHNUa1dL?= =?utf-8?B?MkF0aDdTWEhBaUx2bDBMT29NdjJKaEIyQ3R1QklsU3RlQlpIUlJhejJUbGN0?= =?utf-8?B?dCswSFpna3RwTU9LUmhuTFdNTGZyeUtDOGFQSEhFcDNNY01QRVhtL2RTbFUy?= =?utf-8?B?YTlUdE1qTUN4aGova29KS1JHK2w1NXl4WW5Ka2d3SjUzUUZCRkF1dFNEQ2xO?= =?utf-8?Q?XLin/N13Obv+K?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ajZFTW1pOXI4dzFqVDhEeGlYYkk2UW1mM3NMRFR0VFBzUGI3OXhSVFhhTkt0?= =?utf-8?B?NnNrZFZYL1Fva25VbnIrQ2NKQWFjRGZhS2NvVWVnRHVEdVB3Z0ZkSDQzYTg0?= =?utf-8?B?YWNVL1gvSDYzUjhFZ3BOWm1RMmpKOHIyNWRMaVdZOW9OQTVJTmpUUzFUb0R2?= =?utf-8?B?cE04WnBsenpSdUQ5cXd4TkMyRGV6OVgwcmx3NFE4NGFieFZsa21NUGZUaGlj?= =?utf-8?B?THpadWI1SUdjRGplZXo0MmtBU0ZRc0RVYkRiVklaNVVqUXVhbURFQkRJRTFF?= =?utf-8?B?UXZwYUNGakR6Y29ZbktUK0I0Ynk5eW93SGJjZVFveEQvc3FjVVhoOWx0dHk5?= =?utf-8?B?ZEY2ZWt2alFSMDE4MXVveGZ6OEFOaDg1ZnFNbWlFSnpmWGNjVGZyKzk0TzdJ?= =?utf-8?B?eTlIQjhManJaOTMyQVQxZlJkQk9EeG1RL3p0ZkgrM3l3dVdSdVk1YlhZZUYr?= =?utf-8?B?TGJLZGdDaHp4aElsVmw5MjFQZWdIMXBUZWxQcmdudDdEYmlKdnI2Q2NFejYw?= =?utf-8?B?Z0VjLzhMeGo0T0ljRDMwbk9VUDBFRUQyWTVSbGtiY1pnUU9IcVo0Ylg4cHJx?= =?utf-8?B?QWJFL1E0SnlwSDhDRzc0TWlQU1JsUW0yTUJTWEpDWmdKZkphRnAwOEkxMTlw?= =?utf-8?B?Yy90Y0lWWCtuMFlkempUMm5rSHBpaFN0ekFRQUpXUFppaFkzMVA2SzJMajho?= =?utf-8?B?eUlSTWxiOTFuazJWYVRsL3htK25DLzYyck9uMnExdEk3bFZvc3ZjRGhENGJh?= =?utf-8?B?ckFpQzdJTFdrS1pOZ0ZiK3k0VnlkMmRTOHVwSFdYV3dMQnBSR3U0a2xFWXZn?= =?utf-8?B?U29pcmdBS2FvbXNMb0xpTjBwUWpQQUdsYjZ4VElvVi8vRFhBdWJPdnVQUmxi?= =?utf-8?B?cEtteEYrUmRXSDhyNXUzS3daZFVSTzdHL1Q1MTdvN3laUjJDZkN3TytKUHJu?= =?utf-8?B?UGpzVzdSQlVLbm92dDNjT01FT0lIQ0pJeTcwdXpxNU1BQXBSRWNNbmQvRURt?= =?utf-8?B?Ni85Vy9aSHFVQld6bkxXdy9GZXJ2V1QxanBiVGtaVWUwS2xkT0tWanpNMTc0?= =?utf-8?B?MWhxN2hHdTE1ZkdHL09mbjUxL0hkNFloU2xZT29Xb3hnRFJCQVhDVWwxWmRS?= =?utf-8?B?ZEp6Um9FKzJCQ0JPL1dHWmwwekwyaGpWZVQrYmYvdEd1M2ZPN2g0K0JlSzR5?= =?utf-8?B?WGpaZU50TnZvc3V6d3l6YUZ4NHF3NzV2MmZHSXhTd3d1ZUVPOUJPM05ldEhm?= =?utf-8?B?Zzg3RW1KVTAwNFFvTDV4MmhXYzVmbnNqUStHdzlqVlk3UXoxM2JNdFR4VzJG?= =?utf-8?B?ZHpKY0d3U3hpaWdzdFk2VFpMVVB6cC96R0N0d1M3Y2VKbFdxZUdzTStaNkZm?= =?utf-8?B?QmlwblBsblhVY2s3TEluQ2VtK3RORGtySGFTM1pPUytQWFlaYnFMSEpZcWF4?= =?utf-8?B?TWJBSTBhVWtqNVRJeEIxYzNBcGs5bGVtbXFuanlzVExzRE1pRzZhbXNoL3dN?= =?utf-8?B?cWpiRkF0bnV1RWlEeENMdUhibFZleTcrVmMrQk9XUHpJaGJQTkZkZEFGN0Vl?= =?utf-8?B?VUpkQTMzM0tXZkowOTFsajlTUDdiVUY4Q0dFVWdDTmEydmFIeHZVcm1lc0hO?= =?utf-8?B?K3ZhcWlrQ0lLRjNRQlB3aGcwUFQ3NGJIMGF5THBpNk1mV2pCRHpTOEt2dXJV?= =?utf-8?B?SVVKb1ZLUndBaUkyckttUWhFZlE5TlN6Zm93TkxHWi9pNnp1OEZ4L0pUSysv?= =?utf-8?B?ZjhWQmwwNTNyV2pNZzZJbDRkMVZsbjNabnBLTDcwekZGMWpINnE2U2o4WVlP?= =?utf-8?B?WVBTTE5ucUtTZkhBZnVXVlcvY1Q3RWdzc2FpQVAyMHRjNFdmSyswSWpNZXds?= =?utf-8?B?NGZsLzFZeDRHQWhDZ2NzcjYvbERWekpySHFDdFJPbk4reFBiaW45TFFJbjcv?= =?utf-8?B?VGZIQkdqWHROY0ZqeG9xVW42cXFPKy9PWUFkQU9MMWVRSEFyRTQ1cU83dy9T?= =?utf-8?B?aFlNZHFvMlVIOXRWd2dEYmQwNXdPQ3lRanJXY2UxWStuME5HN3dHTzR3a2Nv?= =?utf-8?B?WDFDTUhjM2UxcFhvN1lhZDdSUFhTTkROdUZ6c29RRGdSaVJ2d0QrT2VRWjhy?= =?utf-8?B?ZFNQTjZjUis3VHJhdzN5anBxL1J2Y0EwR0VhZS8rY1VINCt4L1h3UXNCcWNt?= =?utf-8?B?ZlE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4fec8130-8607-4ad4-2210-08dd1b55cd7b X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2024 09:09:09.2377 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OwvQmC0VxpAbtxZW9RGR+PAitkn9USlFpczZ+AUlhPx+l2LBcl/EIHTiMegTRZR5uNZmb1/bmMzabf6lgDxbtxhV97f+zMS3T9NhtqeyeV4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8605 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/12/2024 7:02 PM, Stephen Hemminger wrote: > On Thu, 12 Dec 2024 16:19:03 +0000 > Anatoly Burakov wrote: > >> Currently, the architecture of the base driver is such that it uses >> function pointers internally. These are not guaranteed to be valid in >> secondary processes, which can lead to crashes. This patch prevents these >> functions from being executed in e1000 driver. >> >> Fixes: 805803445a02 ("e1000: support EM devices (also known as e1000/e1000e)") >> Cc: stable@dpdk.org >> >> Signed-off-by: Anatoly Burakov >> --- > > Not a fan of this. It creates so many special cases like: "This is ixgbe, and > it can do X but not Y in secondary process". > > Either the driver should get fixed correctly so that all operations work > in secondary process, yes you would have to fix the base code. > > Or the driver should be not support secondary process model at all. > > If you have to write lots of documentation about limitations, it is not helping > the user. That is the intention. Fixing these issues will take some effort as there's a lot of code to fix due to how endemic function pointers' usage are to these drivers, but in the meantime, things "arbitrarily not working" is better than things crashing outright. -- Thanks, Anatoly