Re: [dpdk-dev] [PATCH v3 0/2] net/failsafe: support multicast MAC address set

[Andrew Rybchenko <arybchenko@solarflare.com>]

On 9/21/18 7:33 PM, Andrew Rybchenko wrote:
> On 9/21/18 7:21 PM, Stephen Hemminger wrote:
>> On Fri, 21 Sep 2018 16:36:19 +0100
>> Andrew Rybchenko <arybchenko@solarflare.com> wrote:
>>
>>> v3:
>>>      - move apply on sync to fs_eth_dev_conf_apply() to apply to
>>>        a new subdevice only
>>>      - use ethdev API to apply to sub-device on sync
>>>      - remove unnecessary check the same pointer from the method
>>>        implementation in failsafe
>>>
>>> v2:
>>>      - fix setting of zero addresses since rte_realloc() returns NULL
>>>
>>> Evgeny Im (2):
>>>    net/failsafe: remove not supported multicast MAC filter
>>>    net/failsafe: support multicast address list set
>>>
>>>   doc/guides/rel_notes/release_18_11.rst  |  1 +
>>>   drivers/net/failsafe/failsafe.c         |  1 +
>>>   drivers/net/failsafe/failsafe_ether.c   | 17 +++++++++
>>>   drivers/net/failsafe/failsafe_ops.c     | 50 
>>> +++++++++++++++++++++++++
>>>   drivers/net/failsafe/failsafe_private.h |  2 +
>>>   5 files changed, 71 insertions(+)
>>>
>> Since TAP has no filtering this doesn't really do much for the slowpath.
>
> Yes, I know that TAP does not support it. Is failsafe so tighly bound 
> to TAP to block it?

In fact I've put it incorrectly. TAP supports multicast address set, but 
simply ignores
it since "every packet is received". But it is still makes sense for 
other failsafe
sub-devices which really support it.