From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, david.hunt@intel.com, john.mcnamara@intel.com,
ferruh.yigit@intel.com, keith.wiles@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] devbind: don't display non-existent device categories
Date: Fri, 23 Nov 2018 09:23:53 +0000 [thread overview]
Message-ID: <d9e709fb-7f7e-22e5-189b-e445c7e34431@intel.com> (raw)
In-Reply-To: <2321597.iDRxu9RN5K@xps>
On 22-Nov-18 5:12 PM, Thomas Monjalon wrote:
> 19/11/2018 11:33, Anatoly Burakov:
>> If there aren't any devices of a particular category on user's
>> system, we still display them, which is bad for usability. Fix
>> devbind to not print out a category unless there are devices in
>> it.
>>
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>> Reviewed-by: David Hunt <david.hunt@intel.com>
>
> Applied, thanks
>
> I think we can strip output more and remove "no detected" messages.
>
I had an idea to do that, but for now i decided to keep it for the
purposes of providing just enough useful information to the user with
little expense.
--
Thanks,
Anatoly
prev parent reply other threads:[~2018-11-23 9:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 16:42 [dpdk-dev] [PATCH] " Anatoly Burakov
2018-11-15 13:27 ` Hunt, David
2018-11-15 14:06 ` Wiles, Keith
2018-11-18 23:13 ` Thomas Monjalon
2018-11-19 10:03 ` Burakov, Anatoly
2018-11-19 10:33 ` [dpdk-dev] [PATCH v2] " Anatoly Burakov
2018-11-22 17:12 ` Thomas Monjalon
2018-11-23 9:23 ` Burakov, Anatoly [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9e709fb-7f7e-22e5-189b-e445c7e34431@intel.com \
--to=anatoly.burakov@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=keith.wiles@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).