From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE1A242B48; Fri, 19 May 2023 13:23:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 706F54161A; Fri, 19 May 2023 13:23:23 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2066.outbound.protection.outlook.com [40.107.92.66]) by mails.dpdk.org (Postfix) with ESMTP id CCB8D41148 for ; Fri, 19 May 2023 13:23:22 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m/be4QdEV4D6yi4nkYIsWlCTv7ojUiVMu0bIKR2M85aT7IyIZmOf+4oecMW17OdLX9kOwSP++L+iKj0llKJdlWHXQkqwiWgVrHeGeEi7pwQGeWeMvx9gQ+lyn4ChXGaTfMCc66IVqYPZ7WBBTeH6Ajb5iIhk2+MIlzUfyK0mMfG8NZP3ovnnR1GtJp+RlThK6J7P/g4q8ke9Z+C5tK6n+Rm5RHkYKIYDW7hAwzCHTnRfF+Jk1HuIgVXo9IJHEPtbl2L3iQbhKd1xAeusihKp49Kau5lXtfE7g0STF2abKiNeOOBgj6DiugKeA9Q/sIEXnwaXyfdBKpztA8nkbSRX2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RTYXO5jfuFkNlxcC2FAADlZgDvIziVE5fyRIBotUvr4=; b=KAZr+kS76EEBn3UWFwTYwNunoTkqVnnQ2/xzj+SQks77MxzZcT/xIPp9HXgKW71HMatYGHLEGXQR7nflyTd2jifCJF5NB23gBOQyBFtdv1bN4TREaxIzzIaof3C874YL+dWaoBXrfu22IDTmNzg/pAHYiALKLiEprxZSEkXRJbiaydiWuoqvhwFpUhVX7F3JAGwNuGOdqdMLsyiRHd1/rx6Vz8jAQU2O6erI3h4nxr9gSBH11NzhzphDIo7g78bvxOPV9WwL0WYSv6rieUBEOgYmXHjW0Of8x2n03hmpD3PWv7nW1Ze5bTY846LCT72AEgSuc+whoCR2N1DqWs23RQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RTYXO5jfuFkNlxcC2FAADlZgDvIziVE5fyRIBotUvr4=; b=K/QS36pSfrqw9AeGcqZEOS22KFIKjvW3iazXm4xabPsbIfC6dOM4C4Hh0N2STIZE/b2g85EFuE3sbqBTW1Eq6YhYSI0KJYEC+BcX44Zw57T+7SRRzQqThlkipPUY9Yu6XGZbYotfq3gaeaxtUClqbF325eAd/9juIC6tbLyRuPk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ0PR12MB7007.namprd12.prod.outlook.com (2603:10b6:a03:486::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19; Fri, 19 May 2023 11:23:20 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6411.019; Fri, 19 May 2023 11:23:20 +0000 Message-ID: Date: Fri, 19 May 2023 12:23:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Joshua Washington , Aman Singh , Yuying Zhang Cc: dev@dpdk.org, Rushil Gupta References: <20230421232022.342081-1-joshwash@google.com> <20230519002249.2525777-1-joshwash@google.com> From: Ferruh Yigit Subject: Re: [PATCH v6] app/testpmd: txonly multiflow port change support In-Reply-To: <20230519002249.2525777-1-joshwash@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P265CA0009.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:339::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ0PR12MB7007:EE_ X-MS-Office365-Filtering-Correlation-Id: 6ed273e3-f12e-424a-da5d-08db585b72d8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LlLYQKaGc657cBSc9cGD9xsqvfRo3YycnQ0pwnw9MiG22Nr6IdsqZrOmLzh5n+dDBhjpXn/e8BQFiDqU4N6wRXIXjXnA/efVVh3Ln8+IR8eoSCSJvoqhxUrszp1ajSZXtTlAbC8BNgC4qKknBMMC3jHE8dkkw3xZm1TvQNzbDgfcQV4mRiGsdZLbX65+S8nWA+Pc+/6FegRfbwPXvowb1byd6jm9eCPHTnVKx1Dvss+Y/BBjCq9Vo8v8anfW1Xiv6IXdE7I2ZUqSjQeC1C3XH3QYUCfLuacsnFdySZMVWNCBduMiULUg5IoE29k7forfrgzr1zdny0GGdpzWNYsJjFWSsquzDryIGQNr7pyzTdv2MWfkwB/x21UpOZE+EtdT+C9j6VgIzMjNxwTLD0GkQ7gSBp82UVNIZTTtE2sApuEjHKZW6WjJ2g0N4rpO1tGpDiDYarSrsePIdMLcyYqn/JvsOd1iLpHgUj1zXsAsHZUgTACZSi1jt0R2KIvSM7jgERLO5J4L8xuRdv8WnUsbaEkg60D96qGbT8PGMI+iiiDyerh6rUAfr/6J+BlYcLu/wmH4fVpUvO5eMlqTt9fH8fwqwpn0vBH9LrxbWAFH3UmXrjLkbjT5/V5EDa4kBHY+0uASrIks2PY1txdbjZVb0Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(39860400002)(136003)(346002)(376002)(396003)(451199021)(6506007)(26005)(6512007)(53546011)(83380400001)(36756003)(31696002)(2616005)(86362001)(186003)(38100700002)(110136005)(6486002)(44832011)(478600001)(2906002)(4744005)(316002)(31686004)(8676002)(4326008)(8936002)(41300700001)(5660300002)(66476007)(66946007)(66556008)(6666004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVB3aXNVR1ltRmwwcWhHZDd0RVV4WjFJcjlHd0t1b0krc2RhK2k4NVRNOUJq?= =?utf-8?B?bU9Za2s2emhDeWRlZ2hhSFdSRTlSdjYvaTFEL2R0TUg2ZXRzUm5Oakw5NGYw?= =?utf-8?B?N25DMXFlWUVyUHppek1kNTdrMUUrVVlzUW0vMUpKemVJSzMxR1YzZndSSDFq?= =?utf-8?B?MEorSmgrYjRLN1JLelRhVzM0SDRXMEFaN0NDZ2ZERUZsMW5xK2ZjRUdnbUo0?= =?utf-8?B?blc0cGJraXc2eGVYYy85bTZEbzVSbDJTTHNOWVA2WDMxZGNoOUc1eE9nc09m?= =?utf-8?B?eVhrL1hpYlkxWTRtVlRRejM4NVphaGpuMFdSbXJlZzhLazhsMmNkaHhQWWZU?= =?utf-8?B?ZGpDUmxmenJSZmF6bzVSaHdxSGVwMUpadVBoOEJrZGY2VHJNTnN5QzBhd01i?= =?utf-8?B?Y1V6OTNwT0xDZFd4MHRLNTViZzNJWEdxYjFJSWUvRXRSNmxPbVcwdEYzajVj?= =?utf-8?B?d0t0RkdwazBHcElFdTd1cnRpTG9zcmRwdE9oZ3laWmp3a29QdGdSQkVBOFBB?= =?utf-8?B?MkhZNmEwN3BhVGhtY3ZPdzJabExCZk5LZVN5NjE4QXVhV1MxUDFRZVRBdTl4?= =?utf-8?B?NEIzc21VeEpMT1hiK3g4VWlOU2QrOXNaNklWaCtsRmkwdGNXSG9pTG9RTm1w?= =?utf-8?B?aFZRbitMQUtGL3FZVENBQUVXdDRmSFVoOHdBRExCSTFDUTNBaUNkQVNOMEhE?= =?utf-8?B?cm14dktZZ1hLSXZGUGVCdnEzNXNGMmt6NExzZzdaQy9WRThPTmpNNWZXSE9Z?= =?utf-8?B?bTJYUjBoZ3RHc3E0LzhHc1o3dzBJS0NpalJkTHJsYlFnWnBLYnlCNmVoRXNL?= =?utf-8?B?dEpwUnVPUjUzajJZcmtQRTdlV0pkVWZzckkxQ3M2azNFWjJYUy9Nd3I4c3pC?= =?utf-8?B?RHNsNDQ1L1o0ZkZPS2QrWkNDdm5jTWY4VE1SZTVmcGYzNnBJd2p2MjFnb0wz?= =?utf-8?B?MlIxT00wc0NiRkFVbFFPdnNKRzdtR2dqOVZmbks5cm4xVHIxWG1QajB2TEtW?= =?utf-8?B?Uk1LMWk0SmdGeDVlMWJLWUVzRXhWeVBlNkpWOVluMFA4YlBZS0xpSWJJQmhJ?= =?utf-8?B?T0hzTmEyb2RYQ0hLWTc4TXZWeGZjK1RhWllTdUtxU1dDNGFuakpBS1BIT3Q0?= =?utf-8?B?MDVEcWEyUjgyOGhaWkNpbXBMY3VWMFExanJpZDhvOSsyc05QYjVQWVFuUkxK?= =?utf-8?B?OXlUUXd4MC84S0N4UE1mMnFTL2VlMmV3ZlpiclorcGwyNDlWeHBGbENjS3Rp?= =?utf-8?B?NkNWbVRuNnpNcDRaVDdpRk9PL0VRQ1NwR3hsbmtQeS9kd1VkVkhEZGdVUzN1?= =?utf-8?B?b252a0lRVmYyb0RYMUhWL2ZjUGxObnhwRG1uNGRHNy8vcll4R3ppdG5Yank5?= =?utf-8?B?TVVaK1FUTm42SWs3M2E2d1Z2YjBTYmhXL0tnV2EzbjVOZGNkdFJ6L25IbnlR?= =?utf-8?B?ckVMcXYzbTF6L2w2RXovbGJuUXhFNTI0czV4b0lkd3JDOHB0WG9KamdDT0RZ?= =?utf-8?B?anVtaHhSZ3BJZ3pXREoyNnRqV1h3VmE1T2x6UEhWSmRldW81ck1Sa1BkNEhL?= =?utf-8?B?MFpuV2hmTGJ1Mld6SnVCbjBmUnAwQStNSzVWM2NzdkZ0V3lsczNEcFQwV1NG?= =?utf-8?B?NnFWM0lIejV2OFRtM0VYSEZsbjd2ZjNpTEhYbUk3QVQzY1NFdS9qS2hqRlNB?= =?utf-8?B?MTEwSEF3b0FDS0ZQTmI0c3NaM3hhV01DY3pqaXBIUUFobE84a01vSTBHUmRF?= =?utf-8?B?QXVGL0tJN0owMWpiOUlKeDFiYVZBMFp6TUtHRHBCNDArUnVvdkJCbkh5YlYx?= =?utf-8?B?M25VY082VFI0aWhYUGtYaHZDLzVIOUFFdTBNRVlOVzZmb1A2ekM4VjdzTm5u?= =?utf-8?B?NUxad2xSaEtpZkdMYXU2eVNSZW1jOUtWOHdiVzY4dW9iN0lZODFyU3ljc293?= =?utf-8?B?VndhOXRnUFZyZTZmSEF5K2hCdXFBWVpJZnNuYXU5M2gvcE5zUXoyTE1OTVg0?= =?utf-8?B?QUg3N082WUR5T3A3U1FOTnoyb0g3S0F1MmpQcnlpSlhvb3NsaUtrNjRqWWRV?= =?utf-8?B?ejBZWWs3ZDFhZDRZczFTZUpGbEprUm8vWUQ3bVlrZFZpd2hheDV2d3RaaFJT?= =?utf-8?Q?Ypbz8DP/PFE/EqH1TsOpNWdPv?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ed273e3-f12e-424a-da5d-08db585b72d8 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 May 2023 11:23:19.8293 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2D2+FZMzoyqbkOOGtS8bqfT0Jb4pf2cbR7cA4bIXVQ8bWRMteahUH7AG3zzGAG2b X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7007 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/19/2023 1:22 AM, Joshua Washington wrote: > Google cloud routes traffic using IP addresses without the support of MAC > addresses, so changing source IP address for txonly-multi-flow can have > negative performance implications for net/gve when using testpmd. This > patch updates txonly multiflow mode to modify source ports instead of > source IP addresses. > > The change can be tested with the following command: > dpdk-testpmd -- --forward-mode=txonly --txonly-multi-flow \ > --tx-ip=, > > Signed-off-by: Joshua Washington > Reviewed-by: Rushil Gupta > Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks.