From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F18D24261A; Fri, 22 Sep 2023 17:24:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 82CFA40150; Fri, 22 Sep 2023 17:24:01 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id 719FE4013F for ; Fri, 22 Sep 2023 17:24:00 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X5qfUTCRHE9HnxxUjjBeCszSKYWya+ITKq/0J/ZqU7YbmxnsQC9Pi4F17mi6MNSP1CHtPK3PBPlHyXRAG8PfCdpfkvYUd+WFgXnH8SMDk66IuegcF76umu8wUIQpTQVI/aPZvThfN0SM/+vCwer6uEMGvG2kvb9L5vxUaZpTsgPvnF50/n7Gy9AHFaEwIzWpxGGaXSmqqrcpNpg+CDS9EDDtAHpeWdsfVbvpvx6k8QUzAeA438zP/oCTRs+FbAk2M6JvG4x6Khzu9DJKJUVDQco5Kid5O2bkcwIuKeX31dn2EDsoOTo/WWYHW43tE56OKl8EcpZGuAQxaIhIq6Qjvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mfqo/m6zbWslPZDQ8U+2BA0vWaPxWmsJ9O6jdSRqeKs=; b=NqFPT0HpjoIIatxaLquU622/Ww7N6nuLxxqnn+tWvBoc3PCNCO0dxNndqd0agq8ThUdTdzlWV9l7RQrIjrOokDJfmHTe3ug9mr2S2fMwx1OgC4ndvZ6t9ASl22Hn8fcsz3DCnLDoLznBOXV4/cqMpZCpje1Kpt3ciKqhH1V3SqyGoOZNhHKZbK5t00G2qah8g9GBrNsozjqE+LgwTZKoYIfFxnrWwBnYguDXBeTFdwYjQEen/2EGOYJBNJzb/O7y6lg+RCHS0P13ARuI3Syo2WFnRIhWws6aypvxcUJGo7Ajp9FtM3O1iTaRBhc8MGO5xaDXSGn4P+scbKzCWLm9Xg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mfqo/m6zbWslPZDQ8U+2BA0vWaPxWmsJ9O6jdSRqeKs=; b=eJtHiUZazclbw9JAMjq6cz3KoYv8yenC8Wd419tIgiVbefHr8W9+wjfjR35okGqgmaYw/BNND+mAiRAYhSQfk9yMMrN/Wi4en2pL2YGuR8W3sXWOC+Pxteg7O1RMTqKWRBMRvCtjPI8vLvD2xcJMFyxJUzOCyyp8SNuF8BmTfmk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH3PR12MB8710.namprd12.prod.outlook.com (2603:10b6:610:173::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.23; Fri, 22 Sep 2023 15:23:56 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6813.017; Fri, 22 Sep 2023 15:23:56 +0000 Message-ID: Date: Fri, 22 Sep 2023 16:23:49 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ethdev: validate reserved fields Content-Language: en-US From: Ferruh Yigit To: Bruce Richardson , Stephen Hemminger Cc: dev@dpdk.org, thomas@monjalon.net, Andrew Rybchenko References: <20230525203942.129413-1-stephen@networkplumber.org> <834275fc-c34c-4411-bf25-41250f418bdd@amd.com> Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <834275fc-c34c-4411-bf25-41250f418bdd@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0066.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::30) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH3PR12MB8710:EE_ X-MS-Office365-Filtering-Correlation-Id: 529aca01-57a6-44f3-1be0-08dbbb7fefee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RKshEfa+DV65Io8Km9LW3gUEaWNX6Y+JJ6awHGV6GYmNatYEr26pQn2haHhMto1XQvTLesAMUVh7FZIBh/vcShDnQCt13MVhaocvjtSdtCj96ftmE8lk1SxSwSyFVrHUkmBsr4ll/JHtHqY721GtxeEzqCJwPAO3fraQowLySUAbIZZ/cFN+nGtLZmGC9qRAXvf/cqmaWE80y5b9PlTjpKEhNJt2CZRGZ3TP9rqWnzFnfx1SPwh1m0f9clQYVRcCwC/Rp0ql81OC+QqN+Jo+92JG3CZ9BvMmoyDVMOaWx0LLh9uXd+nXvP3xjyDdf/wXfv1Kuk4Kij24OboBgu56ZwD1ItZakw9+TxJtA+3ADl8PVuPrd8RTXvkoCjbJyoy7qh0rDulOpeJzrvOrp7U9QEn6yMJzOVAxgPAl5Ml9GpqZ090S3Dr1yalvyHCO+Ns0JkHK0juKXzHyc9uiaJEC2NthH6634QvMXFQgZ9IiGnkl94rxxZQztapRow54PMyr2mqXyfurijlSdcuO4z+RGarzKEjk7lg5WT7nvr9sjm4KxjPC+o14otEvUT4q62IL7H4J4zjs9aG24aAqqWj69dobNv3AT3W3xrvsWX+xdQgIlgO31z0iHZRJEwBj5ctVyinDJNS9hXDjAJENbkpd+g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(366004)(39860400002)(396003)(136003)(376002)(451199024)(1800799009)(186009)(86362001)(83380400001)(2906002)(316002)(53546011)(6486002)(44832011)(15650500001)(6512007)(38100700002)(6506007)(110136005)(478600001)(2616005)(66556008)(66476007)(6666004)(66946007)(5660300002)(26005)(36756003)(4326008)(8676002)(31696002)(8936002)(31686004)(41300700001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YTdiUEsyRHBYbEJ5UnVNUm41MjlMVWJKRG1JTnZBR0h1SU5SOS9JQmJwU1VH?= =?utf-8?B?eFBnVDdOaUp2Y0xXSDdUdktEbmplN21Ma2hkL1dpQU5kN2tGTjFZcEl0dWNo?= =?utf-8?B?NUdJOXFjUDY5ekN3VWsyS0VwcGU2T1htWFV1blNIemJ0VUQzdVJuZnJVckxI?= =?utf-8?B?Zmt1bWhZQ3c0SjRmeUFCalFZVm9CNGdseVRvaldGTXg0SzFkQUhxd0ZUS2Z5?= =?utf-8?B?a2Z5OXlDdkhpcW1UWjdCMnZJbFk5ZE9IZWhaZ1R0NWFKWjRmRWhyK2JoaEZW?= =?utf-8?B?UXgvT202UHJlRkdBdUZzZVNwNkVLTlJWUndWMTBIeEdxMmdWS1hqWW9wRGdl?= =?utf-8?B?a3pvZWRiU01qT014RFRadkFBbURHRmd2dmFvQ3liTmlvdGU1ZTNFQ0tiQzdh?= =?utf-8?B?cDk2eFg4dkh5OEVKMHovWTl5eWZMMko5SlZFVjVIbG53QjVBbzhqS01sWnZD?= =?utf-8?B?TFZqRnErRDhNczg4eGVRU1dwOHcvOU5Ud2poSlp1OWw0UlVabHB5eWhVZWVR?= =?utf-8?B?M3l0RG90Ri9na0hodGo1c0xlNCtiN25zd0psc3dUWHhHNmZrYmVaZ0tPblNT?= =?utf-8?B?UzJYZ01VVVhIZFJTV2NQNzNxTEVmNjNydENVRkxDcmVFdHd4Qkg5Q0N1eW9p?= =?utf-8?B?aHFwZlBCT0RxTnVyeFZwcFBORXYyUFEyMWY4Q1F5TDlSQ2Z5Y1djYnVTcHpW?= =?utf-8?B?U0FGckttL1BDaDFpVTliKzJ2VFJuNGFKVldwRnlVZ05vOW9LSlpzbjVYY1c3?= =?utf-8?B?S1pyZnJ3VURHSUpCOGlSU2R0VitvcEgvck01S2hqY3BDMFdDbWM2dUpwSm5o?= =?utf-8?B?M0pUR1BUNUhRR1BTc0RLUUFzVjdMS2Z5d0pPZWRiUm5BV0NLYzF2T0k3RnN6?= =?utf-8?B?VG9wejl4aHFZdGFzbWNJeG1kNEc4MkU5YzJNejRlekUxSGRPQ20zWFNPTWpx?= =?utf-8?B?S0RBTG5BcmtXcWg4NXZ5em15RzAwODJEV0Z6RTdGcGxOZzVub01mSHlTOG0w?= =?utf-8?B?SHlIMHBybkUzemo0UC82Z0krM3R4ZXlRUXBMdGFOakRJWXhGcWlObXptci9B?= =?utf-8?B?c3FrRlVXZkdDd0swRXhPVjVKZHBVU2JEaEIzby9aMUpKQ29HK0JZeVhDbXhI?= =?utf-8?B?cEd1SHZRemNnTHdjOEJFMi9LdnBlakhPRStObG9acWQ2eERTeHNNdDNaRWI5?= =?utf-8?B?U1g4RzZnZGg1UFlXakd2RTdjYzZzWkVuQk05Z1dPekpZRUVIbDdvSTdrZVRO?= =?utf-8?B?bnhBVlpCQWJRUjdoczA1a25kYktrTVJITmVsUGc3dGFzQTl6bUhFMGsxWmt6?= =?utf-8?B?aFRubmYvZVFEMjl0OGkyeFY1djhSblpKVjlJUTBHQUNVUHNmMm1JU091VUlN?= =?utf-8?B?ZGN6OFdFQWZhUzJ4eE1vVVJmWDF2d2o4MERyYjZCZTRrRGY3TkRjRXVVVkx4?= =?utf-8?B?Nk5xOVkzUS9LOHhxcFdLWG5EemRuYnVaSTZ6bVFOaFlhR1FHQUQ5OThXLytq?= =?utf-8?B?RGdDL04vdkliSmo1TFYxTE90K1ZyNEZXQlJKRXlWSVRVUmtWaENOSklVNXJS?= =?utf-8?B?UXJ4UFl3SFFSb1VZVlQzcXlIWENTQnZYTEVjWGcxNFdpMTZ2Wit4OUtGRWJG?= =?utf-8?B?ek5hc2xUZGZrd0ZLS0RpOXF0UVhIM25wT0hTUzFqUERzR3ZVeTBNT1BiajNG?= =?utf-8?B?cEVVSFhOTTlKa3lLZ1N1TjZFQklQZ1hMbklSUzI5ZFZPY29TK1UvK2MxOW1T?= =?utf-8?B?SGs4ZU5vK3NyUVFBajVzY1I5MDJRR0U3allTU0Z0bi91VUxJa0F6NjQ0Nkdp?= =?utf-8?B?YVZxV1B0VlJtV0psTThYZzEvVzlOOEMwdW00NVhvQy9wMjIrU01lTnNldFI3?= =?utf-8?B?K2lTTEJ4aENjcnM1STZ0NTk3bEFBM2M2Z09PbXRSN0lYemh4U2drYVdQRHI2?= =?utf-8?B?RmI5SEppNlJ0Yk9NUEJ5eWJlQS9ZTzVNV1ZDQmdJYW1iQzJDNm1FWEJJajJk?= =?utf-8?B?clZpZVRJSHVjM3ZWT0ZKUmx4MXhvZTJPdklDYkFERFVtRWpzdEwxc2lwcmM0?= =?utf-8?B?bGdHVVR5RzhIRHU2K29RNzFEbnpXVDRXSERrZ2Jtdi92WFBCUWZERjNjOWwy?= =?utf-8?Q?MwE/l6UCbpXnNJQBnH916WUwz?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 529aca01-57a6-44f3-1be0-08dbbb7fefee X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2023 15:23:56.6323 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /tzgeP2pA3B5AfV1OkFh9TRWH7k7wCyortAY/1F/N3HPiSq6sRe7qarETeD+yoY2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8710 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/21/2023 5:33 PM, Ferruh Yigit wrote: > On 9/21/2023 4:12 PM, Ferruh Yigit wrote: >> On 5/26/2023 9:15 AM, Bruce Richardson wrote: >>> On Thu, May 25, 2023 at 01:39:42PM -0700, Stephen Hemminger wrote: >>>> The various reserved fields added to ethdev could not be >>>> safely used for future extensions because they were never >>>> checked on input. Therefore ABI would be broken if these >>>> fields were added in a future DPDK release. >>>> >>>> Fixes: 436b3a6b6e62 ("ethdev: reserve space in main structs for extension") >>>> Cc: thomas@monjalon.net >>>> Signed-off-by: Stephen Hemminger >>>> --- >>>> lib/ethdev/rte_ethdev.c | 41 +++++++++++++++++++++++++++++++++++++++++ >>>> 1 file changed, 41 insertions(+) >>>> >>> Acked-by: Bruce Richardson >>> >> >> Acked-by: Ferruh Yigit >> >> Applied to dpdk-next-net/main, thanks. >> > > some unit tests are failing with this patch, both iol and github actions > reports it, need to investigate the root cause. > > Based on findings, we may need to drop the patch from next-net, fyi. > Unit test failures caused by segfault, because in 'rte_eth_rx_queue_setup()' & 'rte_eth_tx_queue_setup()' accepts 'rx_conf' & 'tx_conf' to be NULL, but checks doesn't take this into account. Adding "rx_conf != NULL && (..)" check for Rx, and similar for Tx. I will update in next-net, and force push.