From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B654342417; Thu, 19 Jan 2023 15:53:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A6CCA40223; Thu, 19 Jan 2023 15:53:26 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 14D45400D5 for ; Thu, 19 Jan 2023 15:53:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674140004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8t60imSJmQiHwQjxb9VOa3Ebkrt1gx+dUqvbHPQtaE0=; b=AQPgYKhQWdFNoOBUiI9CYhQ+EktuB6kKNy6bvpfXQtUdU/xK6QlYvTG3jJZtwbfLXKMLTN gijNlDtGMsp4N8/Z1YgSJm2otmnOHo6RouCHQ2BhTamXc3tHdi2I0ajPkEfCuLfFxYl/a2 Pl1ZHx6DBOkBlNeUtTWXucKFqB7efBo= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-594-neV4suqOPtqx8wqyweyYsA-1; Thu, 19 Jan 2023 09:53:23 -0500 X-MC-Unique: neV4suqOPtqx8wqyweyYsA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3BF33811E9C; Thu, 19 Jan 2023 14:53:23 +0000 (UTC) Received: from [10.39.208.26] (unknown [10.39.208.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D9629492B02; Thu, 19 Jan 2023 14:53:20 +0000 (UTC) Message-ID: Date: Thu, 19 Jan 2023 15:53:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] vdpa/ifc: improve device stop logic for block device To: Andy Pei , dev@dpdk.org Cc: chenbo.xia@intel.com References: <1670917055-229334-1-git-send-email-andy.pei@intel.com> From: Maxime Coquelin In-Reply-To: <1670917055-229334-1-git-send-email-andy.pei@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/13/22 08:37, Andy Pei wrote: > For block device, we make sure no IO is inflight before we > stop device. We terminate the notify relay process and wait > for all inflight IOs to be completed. So in this period, we > wait for hardware to update used index, there is no need to > relay new kick. > > Signed-off-by: Andy Pei > --- > drivers/vdpa/ifc/ifcvf_vdpa.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c > index 49d68ad..0822f47 100644 > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > @@ -367,11 +367,7 @@ struct rte_vdpa_dev_info { > (u16)(ring_state & IFCVF_16_BIT_MASK); > hw->vring[i].last_used_idx = > (u16)(ring_state >> 16); > - if (hw->vring[i].last_avail_idx != > - hw->vring[i].last_used_idx) { > - ifcvf_notify_queue(hw, i); > - usleep(10); > - } > + usleep(10); > } while (hw->vring[i].last_avail_idx != > hw->vring[i].last_used_idx); > } Reviewed-by: Maxime Coquelin Thanks, Maxime