From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Richael Zhuang <richael.zhuang@arm.com>, dev@dpdk.org
Cc: lukaszx.krakowiak@intel.com, stable@dpdk.org,
David Hunt <david.hunt@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3 2/3] test/power: fix a bug in cpufreq autotest
Date: Wed, 7 Apr 2021 10:58:51 +0100 [thread overview]
Message-ID: <da2370ab-4dd3-bf36-63df-44bd7396eb20@intel.com> (raw)
In-Reply-To: <20210407074636.26891-3-richael.zhuang@arm.com>
On 07-Apr-21 8:46 AM, Richael Zhuang wrote:
> For platforms that don't support turbo boost,rte_power_turbo_status()
> returns "-ENOTSUP" (like power_kvm_vm_turbo_status()). So don't allow
> check_power_turbo() to continue if rte_power_turbo_status(TEST_POWER_LCORE_ID)!=1
>
> Fixes: aeaeaf5f2d62 ("test/power: add cases for turbo feature")
> Cc: lukaszx.krakowiak@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Richael Zhuang <richael.zhuang@arm.com>
> ---
> app/test/test_power_cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test/test_power_cpufreq.c b/app/test/test_power_cpufreq.c
> index 1f4d8bb05..cda74bd8a 100644
> --- a/app/test/test_power_cpufreq.c
> +++ b/app/test/test_power_cpufreq.c
> @@ -386,7 +386,7 @@ check_power_turbo(void)
> {
> int ret;
>
> - if (rte_power_turbo_status(TEST_POWER_LCORE_ID) == 0) {
> + if (rte_power_turbo_status(TEST_POWER_LCORE_ID) != 1) {
> printf("Turbo not available on lcore %u, skipping test\n",
> TEST_POWER_LCORE_ID);
> return 0;
>
If what you're really checking is -ENOTSUP, maybe check for that?
Because otherwise it seems like you're making unwarranted assumptions
about why the call failed...
--
Thanks,
Anatoly
next prev parent reply other threads:[~2021-04-07 9:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 3:04 [dpdk-dev] [PATCH v1 2/2] " Richael Zhuang
2021-04-06 3:41 ` Richael Zhuang
2021-04-07 2:39 ` [dpdk-dev] [PATCH v2 " Richael Zhuang
2021-04-07 7:46 ` [dpdk-dev] [PATCH v3 0/3] test/power: fix bugs in cpufreq test Richael Zhuang
2021-04-07 7:46 ` [dpdk-dev] [PATCH v3 1/3] test/power: round cpuinfo cur freq value in cpufreq autotest Richael Zhuang
2021-04-15 5:39 ` [dpdk-dev] [PATCH v4 0/2] test/power: fix bugs in cpufreq test Richael Zhuang
2021-04-15 5:39 ` [dpdk-dev] [PATCH v4 1/2] test/power: round cpuinfo cur freq value in cpufreq autotest Richael Zhuang
2021-04-15 5:39 ` [dpdk-dev] [PATCH v4 2/2] test/power: add delay before checking cpuinfo cur freq Richael Zhuang
2021-04-15 5:59 ` [dpdk-dev] [PATCH v5 0/2] test/power: fix bugs in cpufreq test Richael Zhuang
2021-04-15 5:59 ` [dpdk-dev] [PATCH v5 1/2] test/power: add delay before checking cpuinfo cur freq Richael Zhuang
2021-04-20 12:38 ` David Hunt
2021-04-20 13:15 ` David Hunt
2021-04-21 2:41 ` Richael Zhuang
2021-04-15 5:59 ` [dpdk-dev] [PATCH v5 2/2] test/power: round cpuinfo cur freq value in cpufreq autotest Richael Zhuang
2021-04-20 14:01 ` David Hunt
2021-04-19 16:31 ` [dpdk-dev] [PATCH v5 0/2] test/power: fix bugs in cpufreq test Thomas Monjalon
2021-04-21 17:22 ` Thomas Monjalon
2021-04-07 7:46 ` [dpdk-dev] [PATCH v3 2/3] test/power: fix a bug in cpufreq autotest Richael Zhuang
2021-04-07 9:58 ` Burakov, Anatoly [this message]
2021-04-08 2:10 ` Richael Zhuang
2021-04-08 14:55 ` Burakov, Anatoly
2021-04-12 2:08 ` Richael Zhuang
2021-04-14 8:29 ` Richael Zhuang
2021-04-07 7:46 ` [dpdk-dev] [PATCH v3 3/3] test/power: add delay before checking cpuinfo cur freq Richael Zhuang
2021-04-07 10:14 ` Liang Ma
2021-04-08 5:10 ` Richael Zhuang
2021-04-08 5:16 ` Richael Zhuang
2021-04-08 7:54 ` Liang Ma
2021-04-08 9:08 ` Richael Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da2370ab-4dd3-bf36-63df-44bd7396eb20@intel.com \
--to=anatoly.burakov@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=lukaszx.krakowiak@intel.com \
--cc=richael.zhuang@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).