From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 6265E42DAB;
	Wed,  5 Jul 2023 05:16:53 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E8B04406BC;
	Wed,  5 Jul 2023 05:16:52 +0200 (CEST)
Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])
 by mails.dpdk.org (Postfix) with ESMTP id CED0D40150
 for <dev@dpdk.org>; Wed,  5 Jul 2023 05:16:51 +0200 (CEST)
Received: from kwepemm600004.china.huawei.com (unknown [172.30.72.55])
 by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4QwlDl5XZzz1HCsw;
 Wed,  5 Jul 2023 11:16:23 +0800 (CST)
Received: from [10.67.103.231] (10.67.103.231) by
 kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.27; Wed, 5 Jul 2023 11:16:48 +0800
Message-ID: <da3e4ff4-350f-42da-3725-acbbf1570e88@huawei.com>
Date: Wed, 5 Jul 2023 11:16:47 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: [PATCH v2] app/testpmd: fix invalid queue ID when start port
To: Ferruh Yigit <ferruh.yigit@amd.com>, Jie Hai <haijie1@huawei.com>, Aman
 Singh <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com>,
 Shiyang He <shiyangx.he@intel.com>
CC: <dev@dpdk.org>, <liudongdong3@huawei.com>, <alialnu@nvidia.com>
References: <20230703110232.28494-1-haijie1@huawei.com>
 <20230704084507.12788-1-haijie1@huawei.com>
 <29d89a6b-49e0-8789-411f-6a89db177b91@amd.com>
From: "lihuisong (C)" <lihuisong@huawei.com>
In-Reply-To: <29d89a6b-49e0-8789-411f-6a89db177b91@amd.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.67.103.231]
X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To
 kwepemm600004.china.huawei.com (7.193.23.242)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org


在 2023/7/4 18:59, Ferruh Yigit 写道:
> On 7/4/2023 9:45 AM, Jie Hai wrote:
>> Function update_queue_state updates queue state of all queues
>> of all ports, using the queue num nb_rxq|nb_txq stored locally
>> by testpmd. An error on the invalid queue ID occurs if we run
>> testpmd with two ports and detach-attach one of them and start
>> the other port first. This is because the attached port has not
>> been configured and has no queues, which differs from nb_rxq|nb_txq.
>> The similar error happens in multi-process senoris if secondary
>> process attaches a port and starts it.
>>
>> This patch updates queue state of the specified port, which has
>> been configured by primary process. As the secondary process
>> cannot configure the ports, make sure that the secondary process
>> starts the port only after the primary process has done so.
Now look good to me.
Acked-by: Huisong Li <lihuisong@huawei.com>
>>
>> Fixes: 141a520b35f7 ("app/testpmd: fix primary process not polling all queues")
>> Fixes: 5028f207a4fa ("app/testpmd: fix secondary process packet forwarding")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Jie Hai <haijie1@huawei.com>
>>
> The problem description and solution looks reasonable to me, but Intel
> testing still reporting the issue.
>
> There is a chance that the issue Intel side observing is different,
> waiting for more information from Intel test team.
>
> .