From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55964A0562; Mon, 3 May 2021 17:26:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 784A64116B; Mon, 3 May 2021 17:24:34 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id D8009411B0 for ; Mon, 3 May 2021 17:24:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620055470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eLF14skIE08S4wtYkcaEDa64PmaPCgtDykmenai+P7I=; b=EEutI/jfwFRrz5p9OoyUlTzovwj2JJELS8BAaHXmz4EiXUKE+luEHyYnIlbidf1dE55HHL ZCyeTV5CsQVaZ1xTrBiLts3EVLpY9v19W6A9Vr7qaTq/1httHK416gROkjR7X3lXdNb+/f z2gxFX2RHOam3Ca7UG7d6SYkVAQi0yQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-235-pN8UVWPYMHuPcMllueazyg-1; Mon, 03 May 2021 11:24:27 -0400 X-MC-Unique: pN8UVWPYMHuPcMllueazyg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1FDD0107ACE3; Mon, 3 May 2021 15:24:23 +0000 (UTC) Received: from [10.36.110.22] (unknown [10.36.110.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3AB57E2F2; Mon, 3 May 2021 15:24:16 +0000 (UTC) To: David Marchand , dev@dpdk.org Cc: olivier.matz@6wind.com, fbl@sysclose.org, i.maximets@ovn.org, chenbo.xia@intel.com, ian.stokes@intel.com References: <20210401095243.18211-1-david.marchand@redhat.com> <20210503132646.16076-1-david.marchand@redhat.com> From: Maxime Coquelin Message-ID: Date: Mon, 3 May 2021 17:24:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210503132646.16076-1-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 0/4] Offload flags fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi David, On 5/3/21 3:26 PM, David Marchand wrote: > The important part is the last patch on vhost handling of offloading > requests coming from a virtio guest interface. > > The rest are small fixes that I accumulated while reviewing the mbuf > offload flags. > > On this last patch, it has the potential of breaking existing > applications using the vhost library (OVS being impacted). > I did not mark it for backport. > > Changes since v2: > - kept behavior untouched (to avoid breaking ABI) and introduced a new > flag to select the new behavior, > > Changes since v1: > - dropped patch on net/tap, > - added missing bits in example/vhost, > - relaxed checks on VIRTIO_NET_HDR_GSO_ECN and VIRTIO_NET_HDR_GSO_UDP, > Patch 4 does not apply on top of next-virtio/main branch. Could you please send a rebased version? Thanks, Maxime