From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39C3242B2C; Wed, 17 May 2023 12:10:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F4514114A; Wed, 17 May 2023 12:10:30 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2062.outbound.protection.outlook.com [40.107.92.62]) by mails.dpdk.org (Postfix) with ESMTP id CA56B4067B for ; Wed, 17 May 2023 12:10:28 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=abiP3iybJADBvFjlXfMNMN8q0XDKKYdaufIFQ/XaF5oeBJ/HAa+98LKWaEpzvJVQZWYFdAnKMFPwHom579glql9qUILxQUOe+gJe5xG0zjdXIw5F7H3VZKRZBoygQLyGRqzoD65vaH0uCGqKHMTpdwa0R00OaLzUb3doTtzbFXg9uTN9zxX/TRj9xIXABlxAxLLe5XV463026Y7nesRm3/FOuDdWXbjZek3P6oMbPrrQRIUxeN3hEpSW+Qa/+s8TlJv6MMWMc6Ub+YTYtcj6cOT+zKbzXc9wsGBTtSDptYz0gTJu0UiJyoHKz41O+UQ76XaOiK0H5VKqk6JvXhCgHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jf3ppur+ISKH/7Q+dXWoToWgYiMxXfwhM5dEOkq2ovI=; b=erPisCqh1pWE9EO2thlomfmhxANj37kf34xFqpRaAO42e5CK8OiPZ3mb1wmC8xOmRe0ogh/vq2Vc/Bd4UkWU675GpdiFHbp/l1pbNcfyocE21krLHViw0/1/LKGAaPaldb5lkW/oqWbTyAVExUVkPtoSd7A4DSxAn9O3RYyIiSzAdyFTveyIOpLraX4PPZygmS/1BComOxcI2Tpl8tbJtgeHFhgaoRAtPLLWQ7FHmGMOnNfb18pAgYJ9OFGybUHiMS8S1vmfrr9eMBiPMauiGbrLcooFOwD/YbRJB02SaEdHS3LAp6GR+/WBZZEfMyHiHJbHZyZ5Nc5dzFyUM4pfpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jf3ppur+ISKH/7Q+dXWoToWgYiMxXfwhM5dEOkq2ovI=; b=glc+iZCnoP5ARd44REdnqOY6/Y7Ct5fyEIUbaig3VEuv/VdO6M7cwRrhWNjX+j2U6Ur/SnM8M5a8MUhjMoCl2Fh3NjhWIiMF6yTIyTon4rF2r3krcgCs8Xle1Srq9MgIHLJnoyOltHbpGGNS8CWZal74LRCv6Vbuxa0AqoMwuAw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CYYPR12MB8853.namprd12.prod.outlook.com (2603:10b6:930:cb::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33; Wed, 17 May 2023 10:10:26 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6387.033; Wed, 17 May 2023 10:10:26 +0000 Message-ID: Date: Wed, 17 May 2023 11:10:19 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Joshua Washington Cc: Aman Singh , Yuying Zhang , dev@dpdk.org, Rushil Gupta , Stephen Hemminger References: <20230412181619.496342-1-joshwash@google.com> <20230421232022.342081-1-joshwash@google.com> <6c4b95ca-48f3-d1e2-7b39-c1c251095493@amd.com> From: Ferruh Yigit Subject: Re: [PATCH v5] app/testpmd: txonly multiflow port change support In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0283.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:38f::14) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CYYPR12MB8853:EE_ X-MS-Office365-Filtering-Correlation-Id: 8ace6c85-372a-4e17-4a6e-08db56beeeec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gQ1QmC43C3Z2/aCBfWFT5BuG0xRAE2DGbLhM/QRpIY4cyJ4W8Ii6FooQXz2/LMyz/vRHM5CD1dJYR8JKAIfqal3gKB1mqr1waM4jiz3xQQALkh6vl2yy88GgL3SufVztJBm5MMiYIhOYMNmvhewYY7wodCIY6oW9ugf4e6cCCvXSZUWHCBNO3AI1j1oTmBC+/BupuMtEnubaQCL63w4Xpesj53FhXRWibkGIDNdjIIPP/9uklzoZxxd8OFgEnRgIxoKqvpa5VPYsWE9eoFcT5RpsI95HvMPoOY/8G/v2Ur0kP4hzmqiNu+924T4kLOecFelSwEKiB1+rm4Sg/BiXQ4xRKfeTRYX2XhergwfQ/7uIeOXG/I0ctXC/aOrts6vEeU5qiOAmMOJHJ8nko8PXfGEX2eDx3HBkQG1I46ejs91lqAZhcc0pVoLjS/CahhlvRjn9b6W5Qz4bPdP9vQ0R3sb0yQ/TGOYyeRKxXUQqlRipFoKxdUjabMd5K59j5T8X8a0/4PA36SVwVUZGzFgLsjlY0P9W+3r/MFt50cQ/WV35dYb7utSJ9y9VEO6/V17RCZfPMLG6vM0nwcpMIARHXETrenxG/5vyLQQ3Q4z8C4FYjNGk13Ix/FlDgopn3zGpoMBa9fH8k9hJM/BrXt/3Nw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(376002)(396003)(366004)(346002)(39860400002)(451199021)(31686004)(66476007)(66556008)(4326008)(6916009)(478600001)(66946007)(316002)(54906003)(86362001)(36756003)(31696002)(83380400001)(6512007)(26005)(53546011)(6506007)(6486002)(186003)(2616005)(5660300002)(2906002)(44832011)(6666004)(8676002)(8936002)(41300700001)(38100700002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZURWMjh2SUcwaGJ4dXVLU2FPRDBvQWJtSjc1YUhFTDl5dHk2WGt2RlZ2QzZ2?= =?utf-8?B?UjQrMFd6OXJrMmM1ZEw5MzU5VnJrZklQZGFBdGxnY0F6R0gvUU85L2Yzanl2?= =?utf-8?B?R3NoRW5vMmd2K3JIK2FXMTl1dG1aOGlLMlNXbjhtS1RBTG1ESGt4cU9OZnpm?= =?utf-8?B?VFBISUVrNzFxN1VKUm14UmNCSllxc252bkhIOG01cnk3ajd3UWhaRnVPSXk0?= =?utf-8?B?Q2lZWEZBVkErR3lBTS83UGQvRkhXZ1YxdjBhRHc1Y0ZpMnVqcFpJOHdBRTZi?= =?utf-8?B?ak9ZNWdmUFUrQ2Uwa2N2d3QxczVFQlNESnZFbC9CQnBlTEZqaUdyRlhlYkdI?= =?utf-8?B?eXU3R0RZeWVlWU9ud0Q1WDgrYWJ2REc1Mk9FSmNPbDhzZ3gzQmxIZmZWQk9V?= =?utf-8?B?dmFvY3JYM2VGeG1FdWxlc09mVGVvNWNoQ2krOUhWZHBjdUJJSm9Ic1dST2N0?= =?utf-8?B?c281NGl2RTFKbGJXTTU1S3d4TXlkRzljaHVUeU5adVZkYnNpRjNzM2IzL1RF?= =?utf-8?B?ZVp3bGVCQnBGUC9mRDE4MTQxR2lCQzIzVTYzckREc2J3VjNCbkxMaTlrckFo?= =?utf-8?B?ZEMxSnhiQjVJT3dVdHlnZFJEUkxyMm1ENUNoVkpBRU5TVWUxT3BodCtTcWFN?= =?utf-8?B?Yk9BSWFEYUVUa3htdGZVNW1OSmV5aTRTOXZpYnZPcUlNRlJCd0pLUDRYaSs5?= =?utf-8?B?QlJXUU5UMGlHWUM4RW84OGFJMkwwQWZrcnl0K1JOQndlb0hhN1ptc2hFdWdi?= =?utf-8?B?dnNZU2ZNWHpBZjVPMXorUWFwYW9KL1pFNlJNNzFlVGhBTnYzRi9uZ0VlWkJn?= =?utf-8?B?cjEwRHFGTHl1eGZ3a0FVOXNmc3VMOWhCVDhRamVKZzJCdHNCMGNnVkhOa29X?= =?utf-8?B?aVBIT2FqbGlqaENVQU9kWEZPL3cvZXdKeE54VGR0ODFCckZwbzY1L2dINVVi?= =?utf-8?B?dllzbU43YXRyRGY5d0tnUU0vb21SSllDTVZVc0ZnOXdlajZHd2xSMjRiUDZr?= =?utf-8?B?MlNZb1NrcWhUZWdNd0RTR3hJa2F6Y21EMk44aFI5N3kyTWx1QTVpdFFKMEp6?= =?utf-8?B?NEphdHNUQi9ZNjFnbFhkK1pvVHg3RTlLUHIrNmFJY00wVEV1cUtPWkNJYi9W?= =?utf-8?B?eUsvd0N0V0ZibmJzN0dPM0QzL0V3UHBubDhNOGJNYzhsNCtWSDJtTC9PejRx?= =?utf-8?B?Q3ZFc1JHcU9sSSs5UU16MjFRMlZ3SWE5dUN2ZWoyUGtDMzd1Y0hNbVlnVHQ5?= =?utf-8?B?QjI5by9KU2hUdHczWGdWL2tKaWlOVjNiVDJGWHlzNkw2MDMvdUZRNUhBVFZZ?= =?utf-8?B?bnA5aXV1ZzlzWjgybURiMzlWc0ZGQS9MVVZ1VWovbzhjSnhBajVJMG4rTVVT?= =?utf-8?B?emRtUFpCalZvWW9XWHZUY0kxMjJqbHkwYmRQMkpSL2hiQWxjTHFGRlFpNFNC?= =?utf-8?B?NGZYT3paMFp1Zk5VTFluVEF3U04zNnVDMUJqQVFvQ1hJNzBVekEyN1BBdndY?= =?utf-8?B?bVA1LzYwZlY0SFZuY0pYYzJMRXNDQzZmWWxxNVhSSmw2NFVYNDNRUUVjRE9Q?= =?utf-8?B?Zm0zSGpMZnhmY2ZxSkZFSjIyeENYYllVaVlHY0dGTGdEbitoc29uTllzR2dV?= =?utf-8?B?M0xMMVBoYXdiWmJMMXMyc0UyaXZkL3A3aHdoZWcwRUVKRXh0VmRhNW5DTnVr?= =?utf-8?B?RUFwMXlUa2MraDkybkMrVjMrV0ZEa0J3a0ZiMlF2WUs1WjBqb21LTTg0aEd3?= =?utf-8?B?VzZiM0YzRm0xRC92cEJzcUV6SS9ZZnZ2cm0zQXloc3JlTnBHcVVxbjhTSlZC?= =?utf-8?B?SFBGempxdzhMZGVkZFdhUDBwYitNT0hTeWFCZ25kcVU3N2xPQzkxcytTYk1Y?= =?utf-8?B?cEptU0hHeThXbDhuSzdnQ2VIcUU5LzVlQnl1Qm1sUFpNNmVkVkhOams2ZDNP?= =?utf-8?B?dVlYTTNwZzhTOGgwVlR3YTV5L2wyaGJDWHhXZVIreFZJRGdRdndsVUI2MnB4?= =?utf-8?B?S3FIM0hicktwRjI2N0Q5SDNWbnl3VFpCQmM5cC8wTGhlSnV1QnVzcEpXZTM2?= =?utf-8?B?bDVkb0ljd2NPalpDNnJQK2FMbWROMjQwQmM0RDFzaWV6WHRLWnFNOVRSeXF2?= =?utf-8?Q?CWLBnZEFtB4nsamubD6NHyOHa?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ace6c85-372a-4e17-4a6e-08db56beeeec X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2023 10:10:25.8781 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /tTtiBfCX9L28hgX3Al1AQAAWZU/sD51j1MBG+JDrrnsFnK4kBKKTOHjJHeazjGX X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8853 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/16/2023 6:32 PM, Joshua Washington wrote: > Hello, > > I believe my original solution was something closer to what you are > suggesting for backward compatibility. I originally had a flag that > enabled changing source port instead of source IP addresses, but I > received feedback that adding an extra flag was complicating things too > much from Stephen. > > On a VM, the purpose of using multi-flow is similar to that of bare > metal: to test RSS in the RX side. However, generating traffic by > changing source IP address can cause inconsistencies in performance due > to protections in cloud infrastructure from sending packets from a > different source IP address than is provisioned for the VM. Changing > source UDP port to test RSS should be functionally equivalent while > allowing VMs to send traffic from a single source IP address. > > If everyone agrees that adding --txonly-multi-flow as an option as well > as keeping the flag is an acceptable way of moving forward, I can do that. > Hi Joshua, I missed the first version of the patch and the comment, thinking twice comment has a point, I was thinking some users doing RSS based on IP but probably all supports RSS based on UDP too. Better to keep simple. Lets proceed with latest version, I will put some comments on it. Thanks, Ferruh