From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0074.outbound.protection.outlook.com [104.47.33.74]) by dpdk.org (Postfix) with ESMTP id CB41237A0 for ; Wed, 24 May 2017 08:02:06 +0200 (CEST) Received: from DM5PR03CA0050.namprd03.prod.outlook.com (10.174.189.167) by BN3PR0301MB0900.namprd03.prod.outlook.com (10.160.156.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1124.9; Wed, 24 May 2017 06:02:05 +0000 Received: from BN1BFFO11FD019.protection.gbl (2a01:111:f400:7c10::1:165) by DM5PR03CA0050.outlook.office365.com (2603:10b6:4:3b::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1101.14 via Frontend Transport; Wed, 24 May 2017 06:02:04 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD019.mail.protection.outlook.com (10.58.144.82) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1075.5 via Frontend Transport; Wed, 24 May 2017 06:02:04 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v4O621Q9009478; Tue, 23 May 2017 23:02:02 -0700 To: David Hunt References: <1495535304-159542-1-git-send-email-david.hunt@intel.com> <1495535304-159542-3-git-send-email-david.hunt@intel.com> CC: , From: Shreyansh Jain Message-ID: Date: Wed, 24 May 2017 11:40:09 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1495535304-159542-3-git-send-email-david.hunt@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131400793243458042; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39450400003)(39860400002)(39850400002)(39380400002)(39840400002)(39400400002)(39410400002)(2980300002)(1109001)(1110001)(3190300001)(339900001)(377454003)(24454002)(189002)(199003)(9170700003)(106466001)(33646002)(5660300001)(53936002)(230700001)(105606002)(229853002)(64126003)(50466002)(36756003)(31686004)(6916009)(2950100002)(23746002)(54906002)(86362001)(2906002)(4001350100001)(8936002)(77096006)(47776003)(6246003)(50986999)(76176999)(31696002)(104016004)(498600001)(65956001)(65806001)(4326008)(189998001)(54356999)(38730400002)(110136004)(356003)(8676002)(83506001)(65826007)(305945005)(81166006)(85426001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN3PR0301MB0900; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; MLV:ovrnspm; MX:1; A:1; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD019; 1:EktOknwKi+wKOfGyHsS7abJx2KjHrfJ02QfER2+6IR3Da7aWozjIAWQfCuFCCK6hIQC91JS9INIcyrDwQA5y0+oc92tu8SjdriQ1scAPFyGW9Ki1ohgsjF5/L+rvujLmqmtc13DXH0xL1PKBR2zapsXhYVMYeUWvsPuGt6Vtx9Uald3nENmtN29SES8CjdC8pRlgiL5dVd4VOJYy2M4gDIc4JF3YioIfBtqp1NsMhwa99Lraeo5ZY16MJkZgZtVPCUqRGHyZneV0gSlduxEMC8Ztt01CM8c1vvBozz5H5gebHxC2ZV3DS+HJiUHtOgUEpc+vbuGJL4J4wrVy388emY80+hIX4VeY3f/D63GcyocqDF4I+Ajvn0rOB24082bPaA0bCP3IRduYH/CDup2LG+B2CicYOsxQbbehgsVwkm6fhf3jI1DvxQM1cbluinQbQXXjjzOaCSmo3JSENh7AHz48aAcw7RbL0raiQ/kQPGgqz0wYfdsjj7u1NNTnfvhATgXXvBldIQBG73nCSpQogHdH7fqSddI2ZsiWE6DzzfW7g5fNHimcXJrKfuTb+sULCBqusJwBgoufFI+cbXAIOAeM8oKzV1p2R7dINAyhLTpUaZjv6c3Gq/G+ts1o+7WfjnSEUz1r51BgMCWdX9hEDw== X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PR0301MB0900: X-MS-Office365-Filtering-Correlation-Id: 29c58236-fcc8-489d-b89d-08d4a26a66ef X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131430075)(201703131517081); SRVR:BN3PR0301MB0900; X-Microsoft-Exchange-Diagnostics: 1; BN3PR0301MB0900; 3:CAF12afS0DMXPKzz0jsiwDdFGzzl8KMwfh3jFW9wlyR/twWC6ucHF6HmEmzOJmRnOJZtVorVDGU9kfVunTob4cRHp/6i6QWdFfBl1Np78i1SCijWOXujJGhnVLsAhS6c89gBjR+hQJz4OqrOpkZi00iMW61U7gOywP0FnvcZTBPJtwI/JIP6AvRjXqFcuIETpdGrZwVpKVXyVj7zGRktGCEnVC8DNSLAievLnSS2P+n9LVpNOYqXT0HFcMlSVhmr41hsOSM5O3CoZm+4+wrPxEd7rfP8c7Gwd2GkGelSrNhiQsM+NoYnGqSlRqv1obZRnpBNWGcXjDk7jWMKTl2VrS/LHWarmTP1a8Jzy1k72xq/yVPzS7UkwtPkvisUMlSsxlE1Cwbr0xjJ8ehfeisvWWIXrYoqnRWWFozlRmebuTG9pCWR24mgX0sPo28HW/4q; 25:VPIbjxWLI9ikubYYN+Gucq5osSSPPDGcw2GL0eEEF9CmaauPM0yc0KAl9y9IMhFBYnUcSseny7Gt8iT8elpG/nCZXMR+R0tiL22Qaomy5bxjEr3rwF9o09F1VzWYiN1jKwmNV3lxrLmkBhNFW2PpSUhB0/RbBCFTTd9vEUEFEF0pcvcUMt1uyCZsHPjwTLuWQZX0ZTtQwvChkcFMihARmeuVuQQkdjBgEL6XgZJ6XIeNrwqwReaFRDYqZB+DP49UFomkauu62VzzAMJ0mzladd1F7ANkqivGi0EZq8Z85RNSNPOU7QgvjJBYyiiBEhRyMk/D0FkyPQZ+/qjHFX1Fz5YTMtKdum40H18lEfN4c//Q4PjaLQFl8yZVWYQtMz7GU8BI70Z/GAgYRSRIki6IBZ1oDiUbrX/r5yfGL24DyXO9dEMTKF/ghUAvbUq9qrCHteV9AdmFoND0/KI+wX1KpKTlnO4AGiCWAHlJG2rqKv0= X-Microsoft-Exchange-Diagnostics: 1; BN3PR0301MB0900; 31:4oxq7zMBYePlT754JKyDJwOZPZsFk5Pa1yoZQTmOZ+f4UF428WJQXsUy77Zm1IFSkriT+qt8EcngBWnK5geHXaiBjGGoNqa70J4Aguc5MckpaQUZ3qFSfwB+RRYWA3M0FWH2bcw+FFnneducqi5DUl6XMGpxVWF/i9YwVjX1VS46NEcpydkkF0k5aGYEGXCImAaqWh9Z4bSQ93Bhdbdc8dlitXDn43eEQ2MHx5tsTqyoh6+5HOVCzhm0x7xEgZp1 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(601004)(2401047)(8121501046)(5005006)(13015025)(13017025)(13018025)(13023025)(13024025)(10201501046)(3002001)(93006095)(93001095)(6055026)(6096035)(20161123556025)(20161123561025)(20161123563025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(20161123565025)(20161123559100); SRVR:BN3PR0301MB0900; BCL:0; PCL:0; RULEID:(400006); SRVR:BN3PR0301MB0900; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN3PR0301MB0900; 4:Uymi2lRoD6XTJA809QwK8xfLZYlPnDWgfmwV?= =?Windows-1252?Q?PNdoXyypP949l1P0BBMqY419YNSKZCMRO1kHswgtA6U96AnsKL/WXd9+?= =?Windows-1252?Q?GLAaHlpipPslIE++6s7S+XlN+2oYpReMs9tYNO3paOHqToexTVXj81yo?= =?Windows-1252?Q?1CUU26p/DqQg/Jd9J7lujPjLqRBwN4+5BHYojEUk/qM3A1RQEiP8MVOx?= =?Windows-1252?Q?pIlC9aPRS1gDxfDsEIihAOYgHYAA4dm48QVIcXUbS4cXsCOIs1XlWY4d?= =?Windows-1252?Q?plVLCX6n4xHdtK8GgdMM9n9svIl33KlbwXPQzHXiW0Zri92TpbMVohWF?= =?Windows-1252?Q?9SyuYrxdZdwg5W0zze2Xph0g1hITtDFFT+y6zWBUYY9t8iSdkwHJ2+ZQ?= =?Windows-1252?Q?/I7UXk/Lpg2Her09rWIPf9LEd5v7OsFkiXiOpYXthptDQeihQU9xBxih?= =?Windows-1252?Q?jJqtSvk9a8jY6xUeOMd9w1j7t4qu7PWgXeFmGKZHZ7QjKv1PhYfIuUfD?= =?Windows-1252?Q?ykNnAYDmVWE0ygpNcRFuVFmfsiSTAqOsfYsGwlKsE+21tP6fA0iIAncE?= =?Windows-1252?Q?ee/pcZTLc+UFkqcnXBGDMeyJ9rUcBRohD1DEm7Dl/loC1vTvXOq8xwpI?= =?Windows-1252?Q?jOb4mEds85R69bmPqq+7ydSgmeI9lS7po3yY+cznCB4NV0+EbATbuCut?= =?Windows-1252?Q?GBb7qlb6OG22doJoi9Pb/7pfQlP5c3KU/3iiWp0jIf4Ge4BNCamfZSos?= =?Windows-1252?Q?u6h3cExNfZl5NNYqbuY1C5wS72ezQERer3LIoXOiv0xxLUTXvf/JiKoJ?= =?Windows-1252?Q?bwsUgXHs6YZ8iq8oA5HxgEy3ITRZvUOG1kqUdS8g4E6DXs2AiEynpBSo?= =?Windows-1252?Q?GfIGO2n1A5NUnt7zH2Q8VSgaCSJBu4KtZXb/VfNNXiT01ln93GefbohX?= =?Windows-1252?Q?Mof2fuCt1zfj0YQojmosRQukLHyO6jqz8fkV/S75RuJGmuQ1o83f1t+L?= =?Windows-1252?Q?aFHSP4Nkt9HHrEo0fbrHYiR7Y+Bopkit5opmd+niClJCRr10CQ=3D=3D?= X-Forefront-PRVS: 031763BCAF X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN3PR0301MB0900; 23:8qnStFX/nRcnwL1sgK2uvWBEy9Ym4b88X2f?= =?Windows-1252?Q?fy+YQijClqcnCASvFL7/IVILkW+Lxhg2/Q6Qf8IpGzWhTbYPI7csvd/k?= =?Windows-1252?Q?a2pQDSv1Q3iENSX/bBuF2SmP35oCo/wTgSDgfdrscm+kwaS/G0HriYcb?= =?Windows-1252?Q?3hML89w8PYjhv8a8y/pYyEirVoKwTHBL19XoaZgXE14ZGriBEwRDAjlq?= =?Windows-1252?Q?2WFlk7ThlKVGnQu/ynr8TkI6z0kGv6rGAduxWgUb5Vl0eg7YsbGu7dOa?= =?Windows-1252?Q?mTI6+ymiz0V3aGigQeWGurcINmwxsZ58QDHYn5G0SgBrO51mWr9GcFHQ?= =?Windows-1252?Q?GYmB7Wxc0jmgVZDfaJVU3j5nJzkBa0tlcYf08AZ2SEcQPJxtfottFrzo?= =?Windows-1252?Q?jhw0p64Ms6VPvLyLe0EX1K8v8oY0lO5xEHBO8m5YIJHBCaiC6MACBgHi?= =?Windows-1252?Q?3fvToS7ONaZP+GjyJTLgdlbroKBJauZRE+5GV7OMVCoNT2UhdmInbMV6?= =?Windows-1252?Q?JMc0YT5U2aFi0A6TwsSd14FDGcXtmYfO+O+0qOK3+X7alp5HcF36viA7?= =?Windows-1252?Q?THoUcTXLOM+nxEwYs7eatAbm0iXMAnOfwa4QNKdfz5Xpk3F9sp4RhQhE?= =?Windows-1252?Q?MLUThS2t5x4/oWWVhWZKYFI6SJ7/awCa/6PFiaNnePsKwJ4E0UBtRFNg?= =?Windows-1252?Q?SP7OudeC6yPw2I5Xb9Q25qq4VjT7UteLEBOlizpEW3d6+mRUkPGsj02G?= =?Windows-1252?Q?eNUvmpqKbutARQewKrCzolHGU5zo3eHT2GOd/HSO0PCSJfrY/U3J0ad3?= =?Windows-1252?Q?Tm8MAR/K8IvedGrLEmtrK6Y4YdYnPlZAAxqYKw6h00gxWVa0cQROnPnm?= =?Windows-1252?Q?Jlh8WgYhpQx0kV7Vnp0kdfCH5OlJJiEl/Z6BcRaVDnTR4mVIKe2zbW2K?= =?Windows-1252?Q?PkEDeNF3wtFTnJ+w3vX2/MGaA2bomXJZHrLa6Kgj07of10GccvUQ3ou2?= =?Windows-1252?Q?M8TGrpyIPQG51lribh64fAsbEp6IBkf5h0OiAEHIRge9RGq8N/5NPvvN?= =?Windows-1252?Q?7/k7tsct2bAPsiGTo0wEBEk1UbWINiDLFvZ5ufw/FNaqTNTDjI2sp138?= =?Windows-1252?Q?kBLmT/t5D44SWaOL7QpXJMPB0yQvjxzWrjqb5+Q2BsCGQ3gfmXS0cuyv?= =?Windows-1252?Q?r4dxBBnMLnl54u7wdHdMIyoZZjndlJWQZHNDV5+gMi/8wU9RoJzRb1Gg?= =?Windows-1252?Q?tp8g1+fWaVCpiEw2gTEQyFHdgTHz367GHhSgW5mLi7JIvkKokbowCokb?= =?Windows-1252?Q?so1g9zHqzTmTtQFPWm3trQksHmgRet7pRg4tzxNggow2oGexwFEYb3Nt?= =?Windows-1252?Q?q+IiUrG+ACajedSVNszDi5B3TfBQyERfUQnTY+DQqm/dVVUeSNm4qcM3?= =?Windows-1252?Q?QCSs3R3DMJVu7YWYS+WjwTess+JixTiHrSliJadUjj/CzZQyqjUyaymr?= =?Windows-1252?Q?hJjeQwxPcV/27M+8QGBqxpdjiJu3v6wyfVmeWX5V7+rBUWUHQLgV9zvG?= =?Windows-1252?Q?nDv2SoCLKykH2gTFa8UHmw3vTAe3PkeoBuGXS?= X-Microsoft-Exchange-Diagnostics: 1; BN3PR0301MB0900; 6:2S480a0AAR0PguE2hFKHIBKQXWxJ9xRKFfhdh+wMyaR4o6tI5OQV8Eg7OpSr4boXvYaDqhIzSUevFarxXM9HaBU9sXFuspUsAf6+yhmv33kDKcP805qm1F9LtwWNjhV+MuvP2u6LjVEQMf7Pu7AQ3aLKFU/JG+p4q4kVzIk0dklI7rEc1El2St1Wl8ED3d8k+0RqSCOjASvmGMBP89ADVrHh/ek6buzPSIx422vKDzhkFde9g7DVZnSy58j60BFPpxMGyOJLsvm7758AK00YNJF6134xZXtToPAvCRmc46ZNgKhZDgkJF2ikp0zjCABP5wxLDnUeUSZ0fiJd74+5UvGSxOaxnbJOA3tmfB+Hnhoo6bxhObqyq/v/igrVZca1geg9unEhRvDvpY4snwJicHYqfoA7EbtLhn98HaTG5bjt6Ts75+4uDCtI17AD0mkOMZYXDOkipaei40Mm/xrduTYoGX7ks8c5IpayrgGbqVPw4oMwqGVLBNBFz/FExDkyyiOuOBPhT58ZPiuU39K8dA==; 5:y/3mpcySfupyEJ/XuFNR1L5xIItmDXx5AhI4WLxXOWrLLagXYxc05gB6r+aoyHEsutQXUBiUh4WFXXS8c6wyM8enj/nUUraAnFEznJXYPa5prRGpy2E4pInZxDNyln5N5PneczvxvatTPcK4WjpNG+vqyjsCbjQ3j181sM678aXWcsCPynYUnaAWaBqb1rZh; 24:0DBRMMJbhuIDSdfXwDtmL2Sd0OY2MCweXV8qcjkk3cj/39jurvY5Bfke/+XVnhxLEC/7/SvSg1r3xS31Hhzn0z3Ir4Gk0TpGaBmtvfeCGsw= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN3PR0301MB0900; 7:RGWZ5FHc+iw8pKXBP3Zg+dySltg9C2M47zhBUPIkH52Vpz1/LGiswSL/FBz4aYjQYksjNx+WHNJeofN9ivkv5Q0xifHt+AER4P9nHRKz0E0BlmH6ns1OBb2cqHQIuUkWVt5OIGCcj6bkiLW85mWzrR+ikRhgmRdBN4E/pcvu9a/yiXzkX44Pph7qaMMyaW7hUoWuVNBdLgo/XGKRtDX/t5v/6oGXTwx/ypjtV2Sl6/g0vht6Iqjdcs+StXEznFzvCjh4MZtXxH8Qmj+AzmBkU45yfg1qjzbCc1DzIGxomNe75+DTgTX8jP2Qr29hJKL+2hzaViUCTr/Y443CiwRVDg== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2017 06:02:04.1586 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0301MB0900 Subject: Re: [dpdk-dev] [PATCH v1 2/2] mk: add sensible default target with defconfig X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 May 2017 06:02:07 -0000 Hello David, On Tuesday 23 May 2017 03:58 PM, David Hunt wrote: > Users can now use 'make defconfig' to generate a configuration using > the most appropriate defaults for the current machine. > > > arch taken from uname -m > machine defaults to native > execenv is taken from uname, Linux=linuxapp, otherwise bsdapp > toolchain is taken from $CC -v to see which compiler to use > > Signed-off-by: David Hunt > --- > mk/rte.sdkconfig.mk | 15 ++++++++++++--- > mk/rte.sdkroot.mk | 4 ++-- > 2 files changed, 14 insertions(+), 5 deletions(-) > > diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk > index 1f2d6bd..4f30d56 100644 > --- a/mk/rte.sdkconfig.mk > +++ b/mk/rte.sdkconfig.mk > @@ -60,16 +60,25 @@ showconfigs: > > .PHONY: notemplate > notemplate: > - @printf "No template specified. " > - @echo "Use T=template among the following list:" > + @printf "No template specified. Use 'make defconfig' or " > + @echo "use T=template from the following list:" > @$(MAKE) -rR showconfigs | sed 's,^, ,' > > + > +.PHONY: defconfig > +defconfig: > + @$(MAKE) config T=$(shell uname -m)-native-$(shell uname | \ The idea to have 'make defconfig' do the works looks great to me. I am just worried about the above line - it wouldn't allow configurations like arm64-dpaa2-linuxapp-gcc or arm64-armv8a-linuxapp-gcc Basically, having the MACHINE default to 'native' would not be right in all cases. But, I don't have a better idea about how to detect this automatically. Or, we might use RTE_MACHINE someway. > + awk '{ if ($$0 == "Linux") {print "linuxapp"} else \ > + {print "bsdapp"} }')-$(shell ${CC} -v 2>&1 \ > + | grep " version " | cut -d ' ' -f 1) > + > .PHONY: config > ifeq ($(RTE_CONFIG_TEMPLATE),) > config: notemplate > else > config: $(RTE_OUTPUT)/include/rte_config.h $(RTE_OUTPUT)/Makefile > - @echo "Configuration done" > + @echo "Configuration done using "$(shell basename \ > + $(RTE_CONFIG_TEMPLATE) | sed "s/defconfig_//g") > endif > > $(RTE_OUTPUT): > diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk > index 9bdaf20..8019603 100644 > --- a/mk/rte.sdkroot.mk > +++ b/mk/rte.sdkroot.mk > @@ -90,8 +90,8 @@ export ROOTDIRS-y ROOTDIRS- ROOTDIRS-n > .PHONY: default > default: all > > -.PHONY: config showconfigs showversion showversionum > -config showconfigs showversion showversionum: > +.PHONY: defconfig config showconfigs showversion showversionum > +defconfig config showconfigs showversion showversionum: > $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk $@ > > .PHONY: cscope gtags tags etags > Other than that, I tried this patch for x86 and it worked fine. - Shreyansh