From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Timothy Redaelli <tredaelli@redhat.com>,
Tiwei Bie <tiwei.bie@intel.com>,
Zhihong Wang <zhihong.wang@intel.com>
Cc: Fan Zhang <roy.fan.zhang@intel.com>, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] vhost/crypto: fix build without cryptodev (shared lib)
Date: Tue, 23 Oct 2018 11:42:07 +0200 [thread overview]
Message-ID: <dab929ec-b0a8-95e6-787b-21777256aef7@redhat.com> (raw)
In-Reply-To: <5cfae41059f6e9b52f424a1a1f6b0d3d41318e2a.1539722428.git.tredaelli@redhat.com>
On 10/16/2018 10:47 PM, Timothy Redaelli wrote:
> Currently it's not possible to build DPDK as shared library with
> cryptodev disabled since vhost is trying to link with rte_crypto,
> but rte_crypto and rte_hash are only needed when you build vhost_crypto
> and so only when cryptodev is enabled.
>
> This patch fix this by linking rte_vhost with rte_crypto and rte_hash only
> when cryptodev is enabled.
>
> Fixes: b4ca81298613 ("vhost/crypto: fix build without cryptodev")
> Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> v2: Fix the second 'Fixes' line. I wrongly copied that commit id from
> commit b4ca81298613, but it seems it's a commit not contained in any branch
> (as reported by Maxime and check-git-log.sh).
> ---
> lib/librte_vhost/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to dpdk-next-virtio/master
Thanks,
Maxime
prev parent reply other threads:[~2018-10-23 9:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 20:47 Timothy Redaelli
2018-10-23 9:42 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dab929ec-b0a8-95e6-787b-21777256aef7@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=roy.fan.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=tredaelli@redhat.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).