From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5732741CBF; Fri, 17 Feb 2023 13:59:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2EEFB40EE3; Fri, 17 Feb 2023 13:59:55 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by mails.dpdk.org (Postfix) with ESMTP id 03DE140EE1 for ; Fri, 17 Feb 2023 13:59:54 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=REDNpSut2jeCrHA8jVGhfW7Jaa/5JdLhvpxBZFG/FDxQET4sjo8zGm9T/Tko4+QhTh1QEw43xUW2YSWDREHQueIgS7c9FHC0kajLnZ15nvhrsnpUTooI6Ujg0KoOgyHBkxpaZ5wYIWu5fkw5le2WGl7k33X9v2rftJQn4hmIadk66qFmn3RIurKnTYZgq8THgT/y8nEQx1faL8BGNpOi3yWQiagY5+Y8lXf1beqqr29iuvhHwoelZSNewjDpb/7x/Z72VmSak+zsVxugibZBlpn262i/stUavunMxKXes0yX6AVm+nqX45Lxr91RZWzYIoVKugb5ilg4Z1nKFeG0Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WiU9HE+AW9WGOxXWbuyKuTsW8/vzf+JlUEkbf/L0/8A=; b=WyiNn9Wd2RWb3MxbiBhYPqVoZ2tKrlqMLWWgMVi3no7r79TV7yY/hj5MJz5wZ1Jj14ux4WKCSLjO5hrJpmc0/7DzIRkeza36pC2rWikOjEUwtILLIlU4mmB/uSpjSeb5qMdTwefvdi9pUocnGL9V03ZOWl+dmhct4rryyl3gFdKTgHRu3A9i7H2AoCtCvO5ykh32q7CTNBoN/qgpVoNOo90+eaTi0femZRlM2OeRgjK7N0JtPMZ0omLIfCfBE510LfU7JH/1KoSi9pwE+JXmOy4owd7X1JjZdjG8n4IkRvMNBDLAp0izhjvu8guFfsdsoAl84Tt05W0A3W9E3RjzLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WiU9HE+AW9WGOxXWbuyKuTsW8/vzf+JlUEkbf/L0/8A=; b=M2+vs3iv5igG7t3eT+rxcvqeNXzdtsdeQ4xc6jd1WDtZm7Zuh+WR626MGgeHsxPJUo8qe915maZhyqyo4hwHV9x2GhCB8hQFXFTjGymvzcEzpletpo80TU7fbgqaECEb4EKtGUAPdpTHTseIv4hZ3q3tL0kTO8zHMI+lVlTfj3g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MN2PR12MB4454.namprd12.prod.outlook.com (2603:10b6:208:26c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.13; Fri, 17 Feb 2023 12:59:52 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%7]) with mapi id 15.20.6111.013; Fri, 17 Feb 2023 12:59:52 +0000 Message-ID: Date: Fri, 17 Feb 2023 12:59:45 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v6 1/2] ethdev: add Tx queue mapping of aggregated ports Content-Language: en-US To: Andrew Rybchenko , Jiawei Wang , viacheslavo@nvidia.com, orika@nvidia.com, thomas@monjalon.net, Aman Singh , Yuying Zhang Cc: dev@dpdk.org, rasland@nvidia.com References: <20230203050717.46914-1-jiaweiw@nvidia.com> <20230217105026.12927-1-jiaweiw@nvidia.com> <20230217105026.12927-2-jiaweiw@nvidia.com> <557ee985-b634-f630-0ef4-1b28f876f690@oktetlabs.ru> From: Ferruh Yigit In-Reply-To: <557ee985-b634-f630-0ef4-1b28f876f690@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0146.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::7) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MN2PR12MB4454:EE_ X-MS-Office365-Filtering-Correlation-Id: de7c6db8-c9e4-48bf-b995-08db10e6dbce X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8sej4kwuGAUdzLvHYUq28Rby7gcPNV5Layv3Os0AzITpYVVhxIu2FQ1HOALpCOGwbCfH6wPl4yRCHshxx6upojl9qlw+3XriwYg16yZfFvUENSLpi/Rvy9RrC5v6UBRtNi3VUAlj1J2OC/yF/pTuVGKZLYwXM4nRK9xfBw0zYVDitTYxTAwv0/EuJG9/4pOSW/s2FAkitFXOux0Qht4UCa0BT60UAVe0Nm+X3BB4bpiPi3OHnf1DZcg4V3JT0ONmPs1Nt4AKLUi0EWBUCCST1Updpd/4MWt9G4nvjzNQQC3uA1FvbggF4u2rF3C/ZeMN9FwOaag0mODBB6tLkLp/hUINnKTsSXLMQjk+zNGRJdLbDcanhsOCge/xG8w9QZd9XBS0PXgx9VT3Ay0A6m567XkeEJgtarubZaxPpF9u1xIKlKg3zK1JmFYokuVM9iDXR+zRkJfHKh/vsiW/Nt/AG0HmyP9wSAEd2A6eOOG/BnzUW85/Ou/SpaRCFdfjIwArRki8T+d8Je9RSIZpgRJQ4FTje6YW0k5p2HMtpDBn29brroPVV20K6q/pVJgh/MSqzXw9q5CMaRMUCVIX5LFO1oU3HgrXgGHYl0RKkCWzqquBemBPno9ljf/ihUZPFkSV7C013QwARlCp6u2jS14dPCty8rcLMZpxVJBXBqb9p68R7IooGnFo2im+Mt/2krxjN0OFS42Bv3JAO657no4cz4zSqHcw8vTgGtAz69b1PvI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(376002)(396003)(346002)(39860400002)(366004)(136003)(451199018)(31686004)(4326008)(66946007)(41300700001)(478600001)(66476007)(66556008)(8676002)(36756003)(110136005)(86362001)(31696002)(5660300002)(8936002)(316002)(6512007)(38100700002)(44832011)(186003)(2616005)(6506007)(53546011)(26005)(2906002)(6486002)(6666004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aVptYklYNzVyeHNMc0NoUE9sSEhuS2pwYS8vUGZqbXJ0cmhvc25LYXM5MnNT?= =?utf-8?B?Ky9JTUVkbTNxbzYzT2R1SXUzU0JIblNTR3NBd2I5dXRSM3ptRkphaVZkMWQz?= =?utf-8?B?cEJsMlhZMDVqdHkzaDhNRjlzUmVpZjRKeVZKTW9pVkpEMnh2MUE2L1BsenAx?= =?utf-8?B?Z3VpdnJCNWlvL25HYjd0UlltMGc2VEZ6ZTMvQWZOZXF6T0QrVUpoUlB2Vnls?= =?utf-8?B?SlQwT1lJTVFUOHJCclNhU2NJMUZjT2lyUXc3WlMwbzRVSStTenlXeDkwcFRm?= =?utf-8?B?MVRvZ3l2SXlqT3pGLzg5NUJsUENzdW1INkVaWlRGc0xwWkVCWFlVNUFIYUtp?= =?utf-8?B?Z1R6MjZSM2YzMXU4YjhUSEhYWVZZZmp6TzRMclk3ZFBZNUlNWHl2cVIyN3l1?= =?utf-8?B?L3RjSDlCQy9HdmllSkkvdWhYcHlWRVptV21oWWlPVGhwWW1oNVdMZUJyN1BT?= =?utf-8?B?QVhWWm1YYyszSTBmSjFjTGRrejRRNWhlamV3bFIwYXdlSFl4czN5WGpMcjVo?= =?utf-8?B?QmFtQ3gxK3VSRWg3VUZrV0ZyVmtrcE5lTWIyR1VQWVExS21ZWjVJZXpTaC9T?= =?utf-8?B?UXpuZlZSckpUaVhHVVJDd3hNL0gxZUlnL211WkRZckxXSVJoaWpsM05SdmJq?= =?utf-8?B?d3Nwdk9wOXBMSFZOSnI2NUtFekRhRklmZVJkN2xseW95SVFDcnNsS0Z2bGRq?= =?utf-8?B?ay9aa0V2TzlEQnNwVW80dVp0TnBKc2Q2TEhXRFlFQi9UVHk3eWhzOHRJSWFa?= =?utf-8?B?SEpOWG5Na3dhUXJaVm9yYk9tcW82MnN3cmd3YVJQdVcyWWx0d3c5TnoxNnk2?= =?utf-8?B?T01kRm9ac1laODhLNFc1NXBWUVdJTlhPc2E0YkpZRDAwQ0Z1eCtJNGdCUkhv?= =?utf-8?B?T0tWWlpSMGMvTEcyeU5ZRm51dE4xWnZGK0ltQUdRSVhKRTAyenA3WTlQalJ5?= =?utf-8?B?STlTeE9ESHlSanZWVWN4RHdZTFNzK1p6SjZiRFBWdXdYd3FtL1ZFZHd6RnJ6?= =?utf-8?B?QzVXbnZEVEg2MFRMNys1ZWJvYkNXZDRCSy81RDdLZDJlcjZWbUdaMUEvNFcr?= =?utf-8?B?ZkpNdis5ZVN6c2loYU15WmhZb2dma2wvNGIvcXpmNnBjMUhzNkFzNDdXL2Ev?= =?utf-8?B?SUMrYzhGUzVEUEpDZ2JqdUlwenhMZHhpdEpwRWdURzk1S0lBc0xsK2Znc0lz?= =?utf-8?B?dC9MM2p3b1lkMlR3SzhWalFiMTN1UkVaNkM0YjY3bnJjazNmVVVpL1dJMkp0?= =?utf-8?B?aWFEZk1xc29Rc1pJZXgrRVdoMDhGWW1VQU50Vi9DZXE4elpCd3NEYWlIYTZS?= =?utf-8?B?VVo2eWNGQkV1bURwNVRGRHgwTHhzMXo2SXFET1RsZG9aSitxTW5XeTI2RXQw?= =?utf-8?B?Rm1jYlEwenBWbkRieFFFYURPajVHV3QyV1VBRERoOEx0eUlsRWVrNmxKd2Nh?= =?utf-8?B?Q01yTk5mTFo3dEY5bTdPUmxTZGtPQ1pnOGlsZmF3MDdNVFZXNHk0bFJxUklF?= =?utf-8?B?SHBiYTNXU3BuNUZjY2ppZ24reU5oZm9LdjlLQTlwYmVPTG02dHAwV0E3ZWo5?= =?utf-8?B?NEJtYmNWeGMwdTZwY0NRSWRxVDROaXZFUEhRaExxd0hxS2NtV3k1VkFkMG43?= =?utf-8?B?OXJOdlNQdk9qRlpwdnpybEVSOWZjejdhdW5LbVljeExFTWRJaWU3WEcrMitv?= =?utf-8?B?UVYwalV5cklra1E5RUdhcWFzQXVTbzVsTU5NNlNFRXd4bFlJLzFRMmlHMmhr?= =?utf-8?B?dUhJTkRBNGRUYVJHVGFCaXZwQWNER2xuU1BQdWRkVG5RTVV4KzVrQ2FzRUpr?= =?utf-8?B?Yk1tZnFVZzd2UGJDUStpeGwrcmFDOVc0YlJWZlpoMkFYS3JabUp2b3h1YWgr?= =?utf-8?B?WUtCT2RBSnhMSEZPd0ljc2hwOW80b3p1RGl4N3VJOWtNUHZRWm1EQkoxL3Nx?= =?utf-8?B?dVdYNlE5L2VTQVlDYU1maUlSL2JRb1M0RTRQMGtxaks0Z0FjVVQxT2U5ak5M?= =?utf-8?B?UDJWVzgxYnRHM1A0Q2FrTnVhN0hBR1NOMTBSRk1oV0s2anFaaDkrMDhrcDJV?= =?utf-8?B?aWhtcjljakIxZjNHalBDUkl2VW1IZUNkWW9TVlkwdktGTSs4Z2VpSDZza1ZU?= =?utf-8?Q?Vq10jAJIaGmQG1G+XhTzx5EO7?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: de7c6db8-c9e4-48bf-b995-08db10e6dbce X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 12:59:52.1680 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v7x38hRiMgEw6oZ0jRS6m1yz8pvMjrz6BPQ1Bik4j2yHh1T90NsUmsL+a60fNw6E X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4454 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/17/2023 12:56 PM, Andrew Rybchenko wrote: >> diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h >> index 6a550cfc83..b7fdc454a8 100644 >> --- a/lib/ethdev/ethdev_driver.h >> +++ b/lib/ethdev/ethdev_driver.h >> @@ -1171,6 +1171,40 @@ typedef int (*eth_tx_descriptor_dump_t)(const >> struct rte_eth_dev *dev, >>                       uint16_t queue_id, uint16_t offset, >>                       uint16_t num, FILE *file); >>   +/** >> + * @internal >> + * Get the number of aggregated ports. >> + * >> + * @param port_id >> + *   The port identifier of the Ethernet device. >> + * >> + * @return >> + *   Negative errno value on error, 0 or positive on success. >> + * >> + * @retval >=0 >> + *   The number of aggregated port if success. >> + * @retval -ENOTSUP >> + *   Get aggregated ports API is not supported. >> + */ >> +typedef int (*eth_count_aggr_ports_t)(uint16_t port_id); > > Why does use port_id as the first parameter whereas all other > driver callbacks use 'struct rte_eth_dev *'? Ahh, this is wrong, internal functions should use 'struct rte_eth_dev *', not port_id handler. Thanks Andrew for catching it.