Re: [dpdk-dev] [RFC 08/10] ipsec: add support for SA telemetry

["Kinsella, Ray" <mdr@ashroe.eu>]

On 06/07/2021 12:29, Radu Nicolau wrote:
> Add telemetry support for ipsec SAs
> 
> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> Signed-off-by: Abhijit Sinha <abhijits.sinha@intel.com>
> Signed-off-by: Daniel Martin Buckley <daniel.m.buckley@intel.com>
> ---
>  lib/ipsec/esp_inb.c   |   1 +
>  lib/ipsec/esp_outb.c  |  12 +-
>  lib/ipsec/meson.build |   2 +-
>  lib/ipsec/rte_ipsec.h |  11 ++
>  lib/ipsec/sa.c        | 255 +++++++++++++++++++++++++++++++++++++++++-
>  lib/ipsec/sa.h        |  21 ++++
>  lib/ipsec/version.map |   8 ++
>  7 files changed, 304 insertions(+), 6 deletions(-)
> 

[SNIP]

> diff --git a/lib/ipsec/version.map b/lib/ipsec/version.map
> index ad3e38b7c8..c181c1fb04 100644
> --- a/lib/ipsec/version.map
> +++ b/lib/ipsec/version.map
> @@ -19,3 +19,11 @@ DPDK_21 {
>  
>  	local: *;
>  };
> +
> +EXPERIMENTAL {
> +	global:> +

Need to add a comment indicating when the symbols where added here. 

> +	rte_ipsec_telemetry_init;
> +	rte_ipsec_telemetry_sa_add;
> +
> +};
>