From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>, dev@dpdk.org
Cc: Honnappa.Nagarahalli@arm.com, thomas@monjalon.net
Subject: Re: [PATCH 08/17] net/virtio: use previous value atomic fetch operations
Date: Thu, 2 Mar 2023 15:48:20 +0100 [thread overview]
Message-ID: <db3072b9-1d37-ea54-5e68-eed2f9bacf3b@redhat.com> (raw)
In-Reply-To: <1677718068-2412-9-git-send-email-roretzla@linux.microsoft.com>
On 3/2/23 01:47, Tyler Retzlaff wrote:
> Use __atomic_fetch_{add,and,or,sub,xor} instead of
> __atomic_{add,and,or,sub,xor}_fetch when we have no interest in the
> result of the operation.
>
> Reduces unnecessary codegen that provided the result of the atomic
> operation that was not used.
>
> Change brings closer alignment with atomics available in C11 standard
> and will reduce review effort when they are integrated.
>
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> ---
> drivers/net/virtio/virtio_user/virtio_user_dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c
> index f46a131..2b4607a 100644
> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c
> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c
> @@ -1025,7 +1025,7 @@ int virtio_user_stop_device(struct virtio_user_dev *dev)
> uep->id = desc_idx;
> uep->len = n_descs;
>
> - __atomic_add_fetch(&vring->used->idx, 1, __ATOMIC_RELAXED);
> + __atomic_fetch_add(&vring->used->idx, 1, __ATOMIC_RELAXED);
> }
> }
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2023-03-02 14:48 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 0:47 [PATCH 00/17] use __atomic operations returning previous value Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 01/17] vhost: use previous value atomic fetch operations Tyler Retzlaff
2023-03-02 14:47 ` Maxime Coquelin
2023-03-02 0:47 ` [PATCH 02/17] telemetry: " Tyler Retzlaff
2023-03-02 9:34 ` Bruce Richardson
2023-03-02 0:47 ` [PATCH 03/17] stack: " Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 04/17] eal: " Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 05/17] distributor: " Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 06/17] bbdev: " Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 07/17] examples/vhost: " Tyler Retzlaff
2023-03-02 14:47 ` Maxime Coquelin
2023-03-02 0:47 ` [PATCH 08/17] net/virtio: " Tyler Retzlaff
2023-03-02 14:48 ` Maxime Coquelin [this message]
2023-03-02 0:47 ` [PATCH 09/17] net/octeontx: " Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 10/17] net/mlx5: " Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 11/17] net/iavf: " Tyler Retzlaff
2023-03-02 9:28 ` Ruifeng Wang
2023-03-02 15:50 ` Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 12/17] net/cxgbe: " Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 13/17] drivers/event: " Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 14/17] dma/skeleton: " Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 15/17] drivers/common: " Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 16/17] app/test: " Tyler Retzlaff
2023-03-02 0:47 ` [PATCH 17/17] test-eventdev: " Tyler Retzlaff
2023-03-02 14:40 ` [PATCH 00/17] use __atomic operations returning previous value Morten Brørup
2023-03-02 16:18 ` [PATCH v2 " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 01/17] vhost: use previous value atomic fetch operations Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 02/17] telemetry: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 03/17] stack: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 04/17] eal: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 05/17] distributor: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 06/17] bbdev: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 07/17] examples/vhost: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 08/17] net/virtio: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 09/17] net/octeontx: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 10/17] net/mlx5: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 11/17] net/iavf: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 12/17] net/cxgbe: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 13/17] drivers/event: " Tyler Retzlaff
2023-03-13 7:02 ` [EXT] " Pavan Nikhilesh Bhagavatula
2023-03-02 16:18 ` [PATCH v2 14/17] dma/skeleton: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 15/17] drivers/common: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 16/17] app/test: " Tyler Retzlaff
2023-03-02 16:18 ` [PATCH v2 17/17] test-eventdev: " Tyler Retzlaff
2023-03-03 1:54 ` [PATCH v2 00/17] use __atomic operations returning previous value Ruifeng Wang
2023-03-03 2:33 ` fengchengwen
2023-04-25 9:10 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db3072b9-1d37-ea54-5e68-eed2f9bacf3b@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=roretzla@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).