DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/nfp: fix unused header reference
@ 2018-06-08 10:40 Alejandro Lucero
  2018-06-08 19:49 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Alejandro Lucero @ 2018-06-08 10:40 UTC (permalink / raw)
  To: dev; +Cc: stable

Apart from not being used, this is causing problem when compiling
DPDK with the musl library as reported by bugzilla.

Fixes: c7e9729da6b5 ("net/nfp: support CPP")

Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
---
 drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h b/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
index b8541c5..d46574b 100644
--- a/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
+++ b/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
@@ -13,7 +13,6 @@
 #include <stdlib.h>
 #include <ctype.h>
 #include <inttypes.h>
-#include <sys/cdefs.h>
 #include <sys/stat.h>
 #include <limits.h>
 #include <errno.h>
-- 
1.9.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: fix unused header reference
  2018-06-08 10:40 [dpdk-dev] [PATCH] net/nfp: fix unused header reference Alejandro Lucero
@ 2018-06-08 19:49 ` Ferruh Yigit
  2018-06-11  8:35   ` Alejandro Lucero
  0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2018-06-08 19:49 UTC (permalink / raw)
  To: Alejandro Lucero, dev; +Cc: stable

On 6/8/2018 11:40 AM, Alejandro Lucero wrote:
> Apart from not being used, this is causing problem when compiling
> DPDK with the musl library as reported by bugzilla.

If this is fixing a bugzilla issue, can you please use defined syntax to
document it:

Bugzilla ID: ###
Fixes: ############ ("....")
Cc: stable@dpdk.org --> [optional if needs to go in stable tree]

> 
> Fixes: c7e9729da6b5 ("net/nfp: support CPP")
> 
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> ---
>  drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h b/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
> index b8541c5..d46574b 100644
> --- a/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
> +++ b/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
> @@ -13,7 +13,6 @@
>  #include <stdlib.h>
>  #include <ctype.h>
>  #include <inttypes.h>
> -#include <sys/cdefs.h>
>  #include <sys/stat.h>
>  #include <limits.h>
>  #include <errno.h>
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/nfp: fix unused header reference
  2018-06-08 19:49 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
@ 2018-06-11  8:35   ` Alejandro Lucero
  0 siblings, 0 replies; 3+ messages in thread
From: Alejandro Lucero @ 2018-06-11  8:35 UTC (permalink / raw)
  To: Ferruh Yigit; +Cc: dev, stable

Sure. I will send another version adding that syntax.

Thanks

On Fri, Jun 8, 2018 at 8:49 PM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:

> On 6/8/2018 11:40 AM, Alejandro Lucero wrote:
> > Apart from not being used, this is causing problem when compiling
> > DPDK with the musl library as reported by bugzilla.
>
> If this is fixing a bugzilla issue, can you please use defined syntax to
> document it:
>
> Bugzilla ID: ###
> Fixes: ############ ("....")
> Cc: stable@dpdk.org --> [optional if needs to go in stable tree]
>
> >
> > Fixes: c7e9729da6b5 ("net/nfp: support CPP")
> >
> > Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
> > ---
> >  drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
> b/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
> > index b8541c5..d46574b 100644
> > --- a/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
> > +++ b/drivers/net/nfp/nfpcore/nfp-common/nfp_platform.h
> > @@ -13,7 +13,6 @@
> >  #include <stdlib.h>
> >  #include <ctype.h>
> >  #include <inttypes.h>
> > -#include <sys/cdefs.h>
> >  #include <sys/stat.h>
> >  #include <limits.h>
> >  #include <errno.h>
> >
>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-06-11  8:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-08 10:40 [dpdk-dev] [PATCH] net/nfp: fix unused header reference Alejandro Lucero
2018-06-08 19:49 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2018-06-11  8:35   ` Alejandro Lucero

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).