From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49563A0545; Mon, 20 Jun 2022 10:28:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EA26340F19; Mon, 20 Jun 2022 10:28:04 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D5F9840150 for ; Mon, 20 Jun 2022 10:28:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655713682; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JdCxwm6bfQCliHMp0nVMtPAc0UxYCPWH891mEG1/eLM=; b=WbYlKsd3iqUSuk7TEcHDaslB+eBU6wlMBpBHrfslT9iHz9M4hzp/+jbCcT0fmpesjVitkx YH1R2HDFbPiiWYmLF6lZ+IItja3BbgZscy03x6xDdgd8uS8ovmDIyZHaTC3BRSVHC02MNc HqtsSD0t4BCeGpvoxUUeJPI6EJj1Qok= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-237-SWLwmoTMMQa8XDHGEBRLkQ-1; Mon, 20 Jun 2022 04:27:57 -0400 X-MC-Unique: SWLwmoTMMQa8XDHGEBRLkQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D797518A6539; Mon, 20 Jun 2022 08:27:56 +0000 (UTC) Received: from [10.39.208.29] (unknown [10.39.208.29]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0F57520296A2; Mon, 20 Jun 2022 08:27:54 +0000 (UTC) Message-ID: Date: Mon, 20 Jun 2022 10:27:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 04/15] vdpa/mlx5: support event qp reuse To: Li Zhang , orika@nvidia.com, viacheslavo@nvidia.com, matan@nvidia.com, shahafs@nvidia.com Cc: dev@dpdk.org, thomas@monjalon.net, rasland@nvidia.com, roniba@nvidia.com, Yajun Wu References: <20220408075606.33056-1-lizh@nvidia.com> <20220618090258.91157-1-lizh@nvidia.com> <20220618090258.91157-5-lizh@nvidia.com> From: Maxime Coquelin In-Reply-To: <20220618090258.91157-5-lizh@nvidia.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/18/22 11:02, Li Zhang wrote: > From: Yajun Wu > > To speed up queue create time, event qp and cq will create only once. > Each virtq creation will reuse same event qp and cq. > > Because FW will set event qp to error state during virtq destroy, > need modify event qp to RESET state, then modify qp to RTS state as > usual. This can save about 1.5ms for each virtq creation. > > After SW qp reset, qp pi/ci all become 0 while cq pi/ci keep as > previous. Add new variable qp_ci to save SW qp ci. Move qp pi > independently with cq ci. > > Add new function mlx5_vdpa_drain_cq to drain cq CQE after virtq > release. > > Signed-off-by: Yajun Wu > Acked-by: Matan Azrad > --- > drivers/vdpa/mlx5/mlx5_vdpa.c | 8 ++++ > drivers/vdpa/mlx5/mlx5_vdpa.h | 12 +++++- > drivers/vdpa/mlx5/mlx5_vdpa_event.c | 60 +++++++++++++++++++++++++++-- > drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 6 +-- > 4 files changed, 78 insertions(+), 8 deletions(-) > Reviewed-by: Maxime Coquelin Thanks, Maxime