* [PATCH] app/testpmd: fix help of create meter command
@ 2022-04-28 2:03 Jin liu
2022-05-31 13:27 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Jin liu @ 2022-04-28 2:03 UTC (permalink / raw)
To: dev; +Cc: niklas.soderlund, Jin liu, stable, Chaoyong He
The help message of create meter command is incomplete,
lack of policy_id param, update help string.
Fixes: f29fa2c59b85 ("app/testpmd: support policy actions per color")
Cc: stable@dpdk.org
Signed-off-by: Jin liu <jin.liu@corigine.com>
Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Signed-off-by: Niklas Söderlund <niklas.soderlund@corigine.com>
---
app/test-pmd/cmdline_mtr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c
index ad7ef6ad98..a0f885f190 100644
--- a/app/test-pmd/cmdline_mtr.c
+++ b/app/test-pmd/cmdline_mtr.c
@@ -817,8 +817,8 @@ static void cmd_create_port_meter_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_create_port_meter = {
.f = cmd_create_port_meter_parsed,
.data = NULL,
- .help_str = "create port meter <port_id> <mtr_id> <profile_id> <meter_enable>(yes|no) "
- "<stats_mask> <shared> <use_pre_meter_color> "
+ .help_str = "create port meter <port_id> <mtr_id> <profile_id> <policy_id> "
+ "<meter_enable>(yes|no) <stats_mask> <shared> <use_pre_meter_color> "
"[<dscp_tbl_entry0> <dscp_tbl_entry1> ...<dscp_tbl_entry63>]",
.tokens = {
(void *)&cmd_create_port_meter_create,
--
2.27.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] app/testpmd: fix help of create meter command
2022-04-28 2:03 [PATCH] app/testpmd: fix help of create meter command Jin liu
@ 2022-05-31 13:27 ` Ferruh Yigit
0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2022-05-31 13:27 UTC (permalink / raw)
To: Jin liu
Cc: niklas.soderlund, stable, Chaoyong He, dev, Xiaoyun Li,
Aman Singh, Yuying Zhang
On 4/28/2022 3:03 AM, Jin liu wrote:
> The help message of create meter command is incomplete,
> lack of policy_id param, update help string.
>
> Fixes: f29fa2c59b85 ("app/testpmd: support policy actions per color")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jin liu <jin.liu@corigine.com>
> Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> Signed-off-by: Niklas Söderlund <niklas.soderlund@corigine.com>
Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] app/testpmd: fix help of create meter command
@ 2022-04-28 1:56 Jin liu
0 siblings, 0 replies; 4+ messages in thread
From: Jin liu @ 2022-04-28 1:56 UTC (permalink / raw)
To: dev; +Cc: niklas.soderlund, Jin liu, haifeil, stable, Chaoyong He
The help message of create meter command is incomplete,
lack of policy_id param, update help string.
Fixes: f29fa2c59b85 ("app/testpmd: support policy actions per color")
Cc: haifeil@nvidia.com
Cc: stable@dpdk.org
Signed-off-by: Jin liu <jin.liu@corigine.com>
Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Signed-off-by: Niklas Söderlund <niklas.soderlund@corigine.com>
---
app/test-pmd/cmdline_mtr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c
index ad7ef6ad98..a0f885f190 100644
--- a/app/test-pmd/cmdline_mtr.c
+++ b/app/test-pmd/cmdline_mtr.c
@@ -817,8 +817,8 @@ static void cmd_create_port_meter_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_create_port_meter = {
.f = cmd_create_port_meter_parsed,
.data = NULL,
- .help_str = "create port meter <port_id> <mtr_id> <profile_id> <meter_enable>(yes|no) "
- "<stats_mask> <shared> <use_pre_meter_color> "
+ .help_str = "create port meter <port_id> <mtr_id> <profile_id> <policy_id> "
+ "<meter_enable>(yes|no) <stats_mask> <shared> <use_pre_meter_color> "
"[<dscp_tbl_entry0> <dscp_tbl_entry1> ...<dscp_tbl_entry63>]",
.tokens = {
(void *)&cmd_create_port_meter_create,
--
2.27.0
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] app/testpmd: fix help of create meter command
@ 2022-04-28 1:37 Jin liu
0 siblings, 0 replies; 4+ messages in thread
From: Jin liu @ 2022-04-28 1:37 UTC (permalink / raw)
To: dev; +Cc: niklas.soderlund, Jin liu, haifeil, stable, Chaoyong He
The help message of create meter command is incomplete,
lack of policy_id param, update help string.
Fixes: f29fa2c59b85 ("app/testpmd: support policy actions per color")
Cc: haifeil@nvidia.com
Cc: stable@dpdk.org
Signed-off-by: Jin liu <jin.liu@corigine.com>
Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Signed-off-by: Niklas Söderlund <niklas.soderlund@corigine.com>
---
app/test-pmd/cmdline_mtr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c
index ad7ef6ad98..a0f885f190 100644
--- a/app/test-pmd/cmdline_mtr.c
+++ b/app/test-pmd/cmdline_mtr.c
@@ -817,8 +817,8 @@ static void cmd_create_port_meter_parsed(void *parsed_result,
cmdline_parse_inst_t cmd_create_port_meter = {
.f = cmd_create_port_meter_parsed,
.data = NULL,
- .help_str = "create port meter <port_id> <mtr_id> <profile_id> <meter_enable>(yes|no) "
- "<stats_mask> <shared> <use_pre_meter_color> "
+ .help_str = "create port meter <port_id> <mtr_id> <profile_id> <policy_id> "
+ "<meter_enable>(yes|no) <stats_mask> <shared> <use_pre_meter_color> "
"[<dscp_tbl_entry0> <dscp_tbl_entry1> ...<dscp_tbl_entry63>]",
.tokens = {
(void *)&cmd_create_port_meter_create,
--
2.27.0
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-31 13:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-28 2:03 [PATCH] app/testpmd: fix help of create meter command Jin liu
2022-05-31 13:27 ` Ferruh Yigit
-- strict thread matches above, loose matches on Subject: below --
2022-04-28 1:56 Jin liu
2022-04-28 1:37 Jin liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).