From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4DFD0A04B1; Thu, 24 Sep 2020 10:35:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0627A1DD71; Thu, 24 Sep 2020 10:35:04 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 727631DD69 for ; Thu, 24 Sep 2020 10:35:02 +0200 (CEST) IronPort-SDR: bA4NIza5MB3tcS/pUB7d3YdDCh1rKDoagb02cndPDs1MN4OMMH56NyxriDlZaRmym3V3S6YJyd bGXxhrA+4jDA== X-IronPort-AV: E=McAfee;i="6000,8403,9753"; a="148889602" X-IronPort-AV: E=Sophos;i="5.77,296,1596524400"; d="scan'208";a="148889602" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2020 01:35:01 -0700 IronPort-SDR: OvjpmH+7i703QGtTUQSLiVMPkvKeaJlIH0fqTlLz71fxWOSqI/mEJa/FFW0V18c1t/oFIH6jN5 RPezcMi2gZ+A== X-IronPort-AV: E=Sophos;i="5.77,296,1596524400"; d="scan'208";a="335868208" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.213.217.234]) ([10.213.217.234]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2020 01:34:59 -0700 To: Phil Yang , dev@dpdk.org, david.marchand@redhat.com, nicolas.chautru@intel.com Cc: Ruifeng.Wang@arm.com, Honnappa.Nagarahalli@arm.com, nd@arm.com References: <1600244628-13062-1-git-send-email-phil.yang@arm.com> <1600925968-18278-1-git-send-email-phil.yang@arm.com> <1600925968-18278-4-git-send-email-phil.yang@arm.com> From: David Hunt Message-ID: Date: Thu, 24 Sep 2020 09:34:57 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <1600925968-18278-4-git-send-email-phil.yang@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH v3 3/4] power: use C11 atomic builtins for power in use state update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Phil, On 24/9/2020 6:39 AM, Phil Yang wrote: > Since rte_atomicXX APIs are not allowed to be used, use C11 atomic > builtins for power in use state update. > > Signed-off-by: Phil Yang > Reviewed-by: Ruifeng Wang > Reviewed-by: Honnappa Nagarahalli > --- > lib/librte_power/power_acpi_cpufreq.c | 45 +++++++++++++++++++++++++-------- > lib/librte_power/power_pstate_cpufreq.c | 45 +++++++++++++++++++++++++-------- > 2 files changed, 70 insertions(+), 20 deletions(-) > Looks good to me. Code looks good, and I applied it locally to have a test, and it's entering and exiting power manangemnt state fine on my systems here. Thanks. Acked-by: David Hunt