DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
	"Jerin Jacob Kollanukkaran" <jerinj@marvell.com>,
	"Maciej Czekaj [C]" <mczekaj@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v6 1/3] net/thunderx: enable build only on 64-bit Linux
Date: Fri, 15 Oct 2021 17:32:22 +0100	[thread overview]
Message-ID: <dbba2766-e0d2-0bce-17ed-4dcd24854792@intel.com> (raw)
In-Reply-To: <PH0PR18MB408693650CC67292565E0FD4DEB99@PH0PR18MB4086.namprd18.prod.outlook.com>

On 10/15/2021 2:58 PM, Pavan Nikhilesh Bhagavatula wrote:
> 
> 
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Ferruh Yigit
>> Sent: Friday, October 15, 2021 4:09 PM
>> To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; Jerin
>> Jacob Kollanukkaran <jerinj@marvell.com>; Maciej Czekaj [C]
>> <mczekaj@marvell.com>
>> Cc: dev@dpdk.org
>> Subject: [EXT] Re: [dpdk-dev] [PATCH v6 1/3] net/thunderx: enable
>> build only on 64-bit Linux
>>
>> External Email
>>
>> ----------------------------------------------------------------------
>> On 10/14/2021 8:56 PM, pbhagavatula@marvell.com wrote:
>>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>>
>>> Since AARCH32 extension is not implemented on thunderx family,
>> only
>>> enable build for 64bit.
>>> Due to Linux kernel AF(Admin function) driver dependency, only
>> enable
>>> build for Linux.
>>>
>>
>> Hi Pavan,
>>
>> Perhaps this patch took more time than it should, but according Jerin's
>> description the problem is SoC can't run 32bit applications.
>>
>> Why do you still mention from the kernel driver dependency? It looks
>> like
>> that dependency is not reason to not compile 32 bit app, am I missing
>> something?
>>
> 
> Since DPDK runs on FreeBSD and Windows and AF driver is absent for those
> We are disabling this driver non-Linux compilations too.
> 

Ah, it doesn't only add 'RTE_ARCH_64' requirement, also reduces the support
to Linux, so commit log makes sense. Thanks.

>>> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>> Acked-by: Jerin Jacob <jerinj@marvell.com>
>>> ---
>>>    v6 Changes:
>>>    - Update commit log to describe why 32bit is not supported.
>>>    v5 Changes:
>>>    - s/fuction/function.
>>>    v4 Changes:
>>>    - Update commit message regarding dependency on AF driver.
>>>
>>>    drivers/net/thunderx/meson.build | 4 ++--
>>>    1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/thunderx/meson.build
>> b/drivers/net/thunderx/meson.build
>>> index 4bbcea7f93..da665bd76f 100644
>>> --- a/drivers/net/thunderx/meson.build
>>> +++ b/drivers/net/thunderx/meson.build
>>> @@ -1,9 +1,9 @@
>>>    # SPDX-License-Identifier: BSD-3-Clause
>>>    # Copyright(c) 2017 Cavium, Inc
>>>
>>> -if is_windows
>>> +if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
>>>        build = false
>>> -    reason = 'not supported on Windows'
>>> +    reason = 'only supported on 64-bit Linux'
>>>        subdir_done()
>>>    endif
>>>
>>> --
>>> 2.17.1
>>>
> 


  reply	other threads:[~2021-10-15 16:32 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25 17:02 [dpdk-dev] [PATCH 1/7] common/octeontx: enable build only on 64bit Linux pbhagavatula
2021-02-25 17:02 ` [dpdk-dev] [PATCH 2/7] mempool/octeontx: " pbhagavatula
2021-02-25 17:02 ` [dpdk-dev] [PATCH 3/7] net/octeontx: " pbhagavatula
2021-02-25 17:02 ` [dpdk-dev] [PATCH 4/7] crypto/octeontx: " pbhagavatula
2021-02-25 17:02 ` [dpdk-dev] [PATCH 5/7] event/octeontx: " pbhagavatula
2021-02-25 17:02 ` [dpdk-dev] [PATCH 6/7] raw/octeontx2: enable build only for " pbhagavatula
2021-03-22 15:14   ` Radha Mohan
2021-02-25 17:02 ` [dpdk-dev] [PATCH 7/7] compress/octeontx: " pbhagavatula
2021-02-26  5:52   ` Ashish Gupta
2021-03-24 10:55 ` [dpdk-dev] [PATCH 1/7] common/octeontx: enable build only on " Jerin Jacob
2021-03-25 10:42   ` Thomas Monjalon
2021-03-25 10:46     ` Thomas Monjalon
2021-03-25 10:58       ` Kinsella, Ray
2021-03-25 11:03         ` Thomas Monjalon
2021-03-25 12:46           ` Jerin Jacob
2021-03-25 12:47             ` Kinsella, Ray
2021-03-25 12:58               ` Jerin Jacob
2021-03-25 13:02                 ` Kinsella, Ray
2021-03-26 10:50                   ` Jerin Jacob
2021-03-25 14:57             ` Thomas Monjalon
2021-03-25 15:01               ` David Marchand
2021-03-25 14:52 ` [dpdk-dev] [PATCH 21.11 v2 0/3] octeontx build only on 64-bit Linux Thomas Monjalon
2021-03-25 14:52   ` [dpdk-dev] [PATCH 21.11 v2 1/3] net/thunderx: enable " Thomas Monjalon
2021-08-23 19:54     ` [dpdk-dev] [PATCH v3 " pbhagavatula
2021-08-23 19:54       ` [dpdk-dev] [PATCH v3 2/3] common/octeontx: " pbhagavatula
2021-08-23 19:54       ` [dpdk-dev] [PATCH v3 3/3] common/octeontx2: " pbhagavatula
2021-09-07 12:14       ` [dpdk-dev] [PATCH v3 1/3] net/thunderx: " Ferruh Yigit
2021-10-03 20:36       ` [dpdk-dev] [PATCH v4 " pbhagavatula
2021-10-03 20:36         ` [dpdk-dev] [PATCH v4 2/3] common/octeontx: " pbhagavatula
2021-10-03 20:36         ` [dpdk-dev] [PATCH v4 3/3] common/octeontx2: " pbhagavatula
2021-10-04  5:56         ` [dpdk-dev] [PATCH v5 1/3] net/thunderx: " pbhagavatula
2021-10-04  5:56           ` [dpdk-dev] [PATCH v5 2/3] common/octeontx: " pbhagavatula
2021-10-04  5:56           ` [dpdk-dev] [PATCH v5 3/3] common/octeontx2: " pbhagavatula
2021-10-04  9:05           ` [dpdk-dev] [PATCH v5 1/3] net/thunderx: " Ferruh Yigit
2021-10-14 19:56           ` [dpdk-dev] [PATCH v6 " pbhagavatula
2021-10-14 19:56             ` [dpdk-dev] [PATCH v6 2/3] common/octeontx: " pbhagavatula
2021-10-18  7:03               ` Harman Kalra
2021-10-14 19:56             ` [dpdk-dev] [PATCH v6 3/3] common/octeontx2: " pbhagavatula
2021-10-15 10:39             ` [dpdk-dev] [PATCH v6 1/3] net/thunderx: " Ferruh Yigit
2021-10-15 13:58               ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2021-10-15 16:32                 ` Ferruh Yigit [this message]
2021-10-15 17:16             ` [dpdk-dev] " Ferruh Yigit
2021-03-25 14:52   ` [dpdk-dev] [PATCH 21.11 v2 2/3] common/octeontx: " Thomas Monjalon
2021-03-25 14:52   ` [dpdk-dev] [PATCH 21.11 v2 3/3] common/octeontx2: " Thomas Monjalon
2021-08-17  8:46   ` [dpdk-dev] [PATCH 21.11 v2 0/3] octeontx " David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbba2766-e0d2-0bce-17ed-4dcd24854792@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=mczekaj@marvell.com \
    --cc=pbhagavatula@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).