[dpdk-dev] "cannot use T= with gcov target" when doing "makefile clean" with DPDK-2.1.0

["Montorsi, Francesco" <fmontorsi@empirix.com>]

Hi all,

I found that after unzipping dpdk-2.1.0.tar.gz if I run:
       # make T=x86_64-native-linuxapp-gcc O=x86_64-native-linuxapp-gcc    config	
And then
    # make V=1 T=x86_64-native-linuxapp-gcc O=x86_64-native-linuxapp-gcc    clean

I get:

[...]
== Clean app/proc_info
make -f /home/fmontorsi/Downloads/dpdk-2.1.0/GNUmakefile gcovclean
make -f /home/fmontorsi/Downloads/dpdk-2.1.0/mk/rte.sdkgcov.mk gcovclean
/home/fmontorsi/Downloads/dpdk-2.1.0/mk/rte.sdkgcov.mk:34: *** "Cannot use T= with gcov target".  Stop.
make[2]: *** [gcovclean] Error 2
make[1]: *** [clean] Error 2
make: *** [clean] Error 2
	
I guess the fix is:

--- /home/fmontorsi/Downloads/dpdk-2.1.0/mk/rte.sdkbuild.mk	2015-08-17 19:35:37.000000000 +0200
+++ dpdk-2.1.0/mk/rte.sdkbuild.mk	2015-08-28 10:52:56.092466418 +0200
@@ -85,5 +85,7 @@
 	@$(RTE_SDK)/scripts/gen-config-h.sh $(RTE_OUTPUT)/.config \
 		> $(RTE_OUTPUT)/include/rte_config.h
+ifndef T
 	$(Q)$(MAKE) -f $(RTE_SDK)/GNUmakefile gcovclean
+endif
 	@echo Clean complete


Let me know if the patch above is wrong or I should do something else to contribute it to the project in the right way.

Thanks,
Francesco Montorsi