DPDK patches and discussions
 help / color / mirror / Atom feed
From: Luca Boccassi <bluca@debian.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>, Liron Himi <lironh@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Kevin Traynor <ktraynor@redhat.com>,
	 Akhil Goyal <akhil.goyal@nxp.com>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2] meson: update meson build for armada drivers
Date: Thu, 17 Dec 2020 10:06:32 +0000
Message-ID: <dbd39c410b369f198d306911531cea3b844c85bc.camel@debian.org> (raw)
In-Reply-To: <57e2bee8-d74a-6c88-f535-24bc1d18b25e@intel.com>

On Wed, 2020-12-16 at 13:52 +0000, Ferruh Yigit wrote:
> On 12/16/2020 1:41 PM, Liron Himi wrote:
> > -----Original Message-----
> > From: Ferruh Yigit <ferruh.yigit@intel.com>
> > Sent: Wednesday, 16 December 2020 15:37
> > To: Liron Himi <lironh@marvell.com>
> > Cc: dev@dpdk.org; Luca Boccassi <bluca@debian.org>; Kevin Traynor <ktraynor@redhat.com>; Akhil Goyal <akhil.goyal@nxp.com>
> > Subject: [EXT] Re: [PATCH v2] meson: update meson build for armada drivers
> > 
> > External Email
> > 
> > ----------------------------------------------------------------------
> > On 12/15/2020 10:23 PM, lironh@marvell.com wrote:
> > > From: Liron Himi <lironh@marvell.com>
> > > 
> > > With pkg-config support available within musdk library (from
> > > musdk-release-SDK-10.3.5.0-PR2 version), meson option 'lib_musdk_dir'
> > > can be removed.
> > > PKG_CONFIG_PATH environment variable should be set appropriately to
> > > use the musdk library.
> > 
> > Hi Liron,
> > 
> > It is good change to get rid of an custom meson option, can we or should we backport this to the v20.11?
> > [L.H.] yes, it can be backported.
> > 
> 
> Kevin, Luca,
> 
> What do you think about backporting this patch to 19.11 & 20.11, it removes 
> 'lib_musdk_dir' custom meson config option and uses pkg-config to find the musdk 
> libraries.
> 
> It looks good change but not sure if it is a regression to remove a build option.
> 
> Thanks,
> ferruh

I don't know how used it is, but removing a meson_option is no good for
LTS. If there is no functionality/build breakage and it's 100%
compatible, it could be made a no-op - that would be acceptable for me.

-- 
Kind regards,
Luca Boccassi

  reply	other threads:[~2020-12-17 10:06 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-02 13:05 [dpdk-dev] [PATCH v1 0/2] armada: introduce musdk pkg-config lironh
2020-12-02 13:05 ` [dpdk-dev] [PATCH v1 1/2] meson: update meson build for armada drivers lironh
2020-12-09 10:49   ` Ferruh Yigit
2020-12-13 20:06     ` [dpdk-dev] [EXT] " Liron Himi
2020-12-14  9:57       ` Ferruh Yigit
2020-12-15 10:04         ` Liron Himi
2020-12-15 10:29           ` Ferruh Yigit
2020-12-15 22:19   ` [dpdk-dev] [PATCH v2] " lironh
2020-12-15 22:23   ` lironh
2020-12-16 13:37     ` Ferruh Yigit
2020-12-16 13:41       ` [dpdk-dev] [EXT] " Liron Himi
2020-12-16 13:48         ` Ferruh Yigit
2020-12-16 21:15           ` Liron Himi
2020-12-16 13:52         ` Ferruh Yigit
2020-12-17 10:06           ` Luca Boccassi [this message]
2020-12-17 10:16             ` Ferruh Yigit
2020-12-16 21:36     ` [dpdk-dev] [PATCH v3] " lironh
2020-12-17 12:15       ` Ferruh Yigit
2021-01-11 11:28       ` Thomas Monjalon
2021-01-11 15:29         ` [dpdk-dev] [EXT] " Liron Himi
2021-01-11 16:05           ` Thomas Monjalon
2021-01-11 16:08             ` Liron Himi
2021-01-11 16:17               ` Thomas Monjalon
2021-01-11 17:07                 ` Bruce Richardson
2021-01-11 17:30                   ` Thomas Monjalon
2021-01-11 18:01                   ` Luca Boccassi
2021-01-11 17:04             ` Bruce Richardson
2021-01-11 17:06               ` Thomas Monjalon
2020-12-02 13:05 ` [dpdk-dev] [PATCH v1 2/2] doc: update armada docs lironh
2020-12-09 10:45   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbd39c410b369f198d306911531cea3b844c85bc.camel@debian.org \
    --to=bluca@debian.org \
    --cc=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=ktraynor@redhat.com \
    --cc=lironh@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git