From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 813F0432FA; Sat, 11 Nov 2023 04:23:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B736402A6; Sat, 11 Nov 2023 04:23:11 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2050.outbound.protection.outlook.com [40.107.223.50]) by mails.dpdk.org (Postfix) with ESMTP id C76624025C for ; Sat, 11 Nov 2023 04:23:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QOFoKMNQFsjx4AQ96SX13Eldupo2Y5iX7W0SEQ1v9mHFzEXVduqt7E4cBJNlh6GkQaqot6ozRnN/mSlnR0eFXgyPgN7MgevFpXlvNwReKsYoInHqlPtd1ki5TvFWuHuZpaNY3xD4G0OaHOebNkRshMON53kgAkWK35bUGArVrUCC/dLKgbZad6T7/5Rej0wViDghSpwX/xNysyrYSdoOVjG61B66VYd4QdSX6N4AI63DQRqZBBU+gLzpvuEYB8uzkKmm2NMnQUDPf+8FhkPsyRGCdM0JwL706CcLegLWkhZ1ImZ/tFGxP+wGcyeKkjg/lT+cMR6Uq4O5YIZUh03rtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JMbZn1TXAXLSswIUMVZsgDVJpZ/I9F13CrDVpXNhhYU=; b=WoYhhjh6cqxhjo9R28yNokdKSlbOIW+frNo1FZTWte/spwnH29lpLD9T+cXULlnOeTXwEWGmuuShv516aclHYbfDfGlLOF95aHdP/pJfnTCGMA0BeykEnkT2iRDE3tgf4hmr/1XGBNVy5hE8AgLHOKtoubjqNxudEKZ+yjGqENcALc6ModfzPJKD3htBxVWmCg3hvQvlxrHQwVMO1UkislQ6uGuhJkGC8gcj7+FbJrHqSesNXeb+wUEffNTDJS7Ok5VZ1N+0qev6QtXCRpHhnit5WCNdPZCD92xYxKIMGlYcGdY+1rB0f3nh5K+P8QtFkePsBsiWK3gS4WKdbd7bsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JMbZn1TXAXLSswIUMVZsgDVJpZ/I9F13CrDVpXNhhYU=; b=2hC+12LAVpKkdljhOFKiiLoXmknc57gvjuaAlGjyF9R4/z1d22MFwFU4vZSSBK0OYUhjb/G3uAbBtkrijnsuCIChuEZFCe3AMkjLZw7vC4uqwzJhIMCpuOtcg6V83qfPrJN8KZHtO4x7/G5xcx1CEaNyJQpLMYNM10Ti/0P2888= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA0PR12MB8422.namprd12.prod.outlook.com (2603:10b6:208:3de::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.29; Sat, 11 Nov 2023 03:23:06 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6954.029; Sat, 11 Nov 2023 03:23:06 +0000 Message-ID: Date: Sat, 11 Nov 2023 03:22:42 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/3] app/testpmd: fix random value to set tunnel TSO Content-Language: en-US To: "lihuisong (C)" , Ivan Malov Cc: dev@dpdk.org, Aman Singh , Yuying Zhang , Andrew Rybchenko , Bernard Iremonger , Ivan Ilchenko , liuyonglong@huawei.com References: <20231110081925.14142-1-lihuisong@huawei.com> <20231110081925.14142-2-lihuisong@huawei.com> <7046579c-a129-69c2-f72b-94ab2fa5d5fd@arknetworks.am> <75d6ecbb-42b6-e591-754f-a70d1aa29fc5@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <75d6ecbb-42b6-e591-754f-a70d1aa29fc5@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0026.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::13) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA0PR12MB8422:EE_ X-MS-Office365-Filtering-Correlation-Id: c7147084-6cb9-4c07-efd2-08dbe2658565 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L95A2ODY/NCPK2Urc4OcjiO7mEZ3kMQiJN2+SNxh1q1M6NEhNliWLAY8maLIpv12VH7cXTMxYeugVhQ7Or4GJ1MvZdIGsJmJd7VAbZwIi6+Gf5XIzij2ndJ/1q6NkVsqBjK8UnIyMyxn7tz/sAViiLMQBtKOxzXdGQ1w2aM+qwP0GjlcYP0ya4iMDTVM7DuOwUvR2UU2FdtWpC1/4DLFZk9fBCbgMjDS8HKlIWa2kuNkD3sfRpi8bU5pIVmeiTeKIh7bETcxOv+QsWpybIUmlH/iQoFSCo1YIO/yeIzc+1tnYTtdPRSmpVxH7s28zhD20H0JuzgNGuss9T3bhLCPk4oT4+eCDmbXuQGBNZuWp4APJpKI7uk4CTyWP+/ZnOOX1RZqIhV2H3THJwJM69pFVkgmNem4Hdds7+hEjuGZk4lcuJfG2jTWJQFKjHQbg4CSmbpXQ/MfuHBi3tL4A3PUyCK4csoIAKAXH5ejEIc0QXznltKUKC1HKseYK+EA6I+g+VKvG8QH3Ut9N+gslkFVWrF/B2eQ+Hl4O5L/Fy8sg18k1haeD6/RzMp6jg7MkloS+mfjZG44khT5XMRgcIJecAeUa8NQkNFdPxMwChqHJx78DI9lSF3AuQSLVXOtCglfPf/C17DfBnv16rM0Ai2w6cJSZvebXSRNasK3oev+d/eQWNzGRvPm4aLnji3f8LZD X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(39860400002)(366004)(396003)(346002)(136003)(230273577357003)(230922051799003)(230173577357003)(1800799009)(451199024)(186009)(64100799003)(44832011)(31696002)(5660300002)(8936002)(6486002)(8676002)(4326008)(31686004)(53546011)(6506007)(316002)(54906003)(83380400001)(66556008)(36756003)(66476007)(41300700001)(2906002)(86362001)(38100700002)(26005)(110136005)(2616005)(66946007)(6666004)(6512007)(478600001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TnIyMCs3d21SN095RFMyaXd0ZUZ1bGhFNEdmNmo2anZaMk5OZitObzFXeGhI?= =?utf-8?B?SzRlQkJoMFovNXB2OEEwOXpxMWgwbHNRWGROa04xWHlyK1U4SlJVSGlKWWNk?= =?utf-8?B?cEFPRVdHZityOGI2aFp1eGZhNnRzQ0tDU2RVSGVhbzhMbXdVMWxCU3NaTGs0?= =?utf-8?B?UzZwQzhzZzhzdjAzL2ZqS1ZCV2h0bVU2UXI3ZWZVWjBQWVVyOVQvdUVycm9U?= =?utf-8?B?Z0RmRUx4SUlIbjFsekhTZm1kRWZaQXBNd0k0RGZ6MnB1VDZscTZraWlYZmsw?= =?utf-8?B?eWhZaDU4aEtlYnRUUUlYTm9mTDZPem5wTkJNR2MrakErUzh3NVo5UDdCaTVt?= =?utf-8?B?QjRLMVk2bDJTT2hnbEs3N3JzNGNvdExiL2VnZFNXUGlSVkVCVjJtam42MHIx?= =?utf-8?B?WmliazN5dDB5SU5meGtma0Y3dDdxUkZ5Y2oxci9pZVVWVVVqVUdjZm5VSFN2?= =?utf-8?B?TC9teVNIVHJSc010OVROdFUvWXNjK3pkVU5PbkI4YnBkT2pFMGdJTU9mVTJF?= =?utf-8?B?NS8zZDNBc00rU2wzU21PRVoxd3pxSFg0V2crYXdaZG55R0c4bEkzZTRwL3NV?= =?utf-8?B?bUhhSG5jVmROUWM0N2oxcVRYcXlJZnVuekVsUFF0aE1BZUVqYXZva2xRNmNa?= =?utf-8?B?ZlNkM24wcGlCN1BNclR5ck5RcW5wR2Z4eStTeHRCVFpwaWo4V1cxOE1qc3lZ?= =?utf-8?B?aVBHK1N3aUZ6TWRzait6RThFZ3ZDNnp5aDBKVW5STEdpZFE4azVvQ1hYUENX?= =?utf-8?B?Wkg1aTRzMzhubXNCaHB2NmdJZE1tWGRNTHk1OEp0YmI3QXk1bGJPemJ3aVVi?= =?utf-8?B?bzJwTjN1alpNb0hnQUNwYXY2aitKRXVXWkJuZVFrV3FNZHhJeWVDb1QrM3hD?= =?utf-8?B?TktOOE5WWEozTWdYMlFMa09wWFJDWFBUSmhlM1hxRzZTSTB0TXNXMkdFRDNz?= =?utf-8?B?OFZ2T2wydC9kV0VPQUgydWdLc0dMbVRsemFFaXUyTlUwSHJLK25EQmMzWHRV?= =?utf-8?B?NWJFY3hmTWFzZ3Y0TFZ5ekVXUDM4bUxZVzNKRnlzUldsdjBrL3I3VjV0bHIr?= =?utf-8?B?bUt3TVk3bWtMZDlOMmdZREhIcVl6dVo5MVFPNk1DWmNrb0dPWHNSNFFwWk13?= =?utf-8?B?eitwdEFPS0h3WjZuUFJieEcvSkY3MDZ0Y201bTBiaFN0cW5WOUtmZGlTL01n?= =?utf-8?B?R0ZYcVlEMGphODV3c3R1b2c3cEJHNjcwY2RyYjJBL21SUTVMS1NrZ0RjUnN5?= =?utf-8?B?Um5ZNHhYZkNncEFReVF3Y1BETFdGa2hGL0JTRDg5d3I5UHpldm5ablVZcVlv?= =?utf-8?B?dUVPbUFUZlBFSjdueTd5d1AxdEQzdXYrM21XWDA2UEF1T3k3c3dab204SnU5?= =?utf-8?B?U0c1RVVzU1JkM1ovcjhDekJxeXVvK3pWRXJWTGtTSUh0cHBOTFdhY3BXb3hN?= =?utf-8?B?VGYwbEQrNXFKTFNYZjVBdHB0dE9hUzVHbCtVYVBWRis3cEN2dWVnUFg5TWFH?= =?utf-8?B?dzhQUTJ0bUZSWTZiWk1NUHNhZDA1VEJNZnpvU2Fmb24wdGdZeU9YOWpIVDU0?= =?utf-8?B?WjFwcUhMYnBzV1Q3bWJ3Wlcvc1NjaDZHb2piVlZ6V1pWdWVIYjN3eHEwY1JS?= =?utf-8?B?R3JsNThPWjIvcUVtSmdqWlFjK3RXTitVK09uNllSdTdTa0c3cXdYekNJVHBi?= =?utf-8?B?ZzVYVEFHamJVb1RERmVVNE5MUmR6S21Ya09yNUo0aThpd1RJdi9oSk5CVURy?= =?utf-8?B?a0kwTXQxRXdjWkVrNDkvaDFhcTRrb29JR0tLMW5DUXR0RU5ObFkwbkRLZE1M?= =?utf-8?B?VnljSmYyYzVDVHZUMlUrMmgvMEh2SzBqd202THl0RC9Kckdrc2NxUUNDY3NE?= =?utf-8?B?bmtUeTJQYnppRWhHWEFLQk1lSWNhSHZLVjBTQW85UzN0amNtNVRLVTVkWlZq?= =?utf-8?B?QndUT0lwLzF6d2VnR1JvLzQvMGRCbjlMMHkzOVNET0hPTkVhTHhpKyszdEF0?= =?utf-8?B?TjNSU3JJS0NwWEorUTJqR3UvWTYxbTJmR3ZEVlZLQ0JFOGl4Ymo0SEtaNGlq?= =?utf-8?B?OHZLTklGNmlOdzBTai9JL3BpZ3llVDRYMXkxV0c3c3kzTlhyYXZ2S0EwNW82?= =?utf-8?Q?hBIN3PLF0uZJmUhjGMTFYWTll?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c7147084-6cb9-4c07-efd2-08dbe2658565 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2023 03:23:06.2878 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RPqekPf/R7ly7u6q/0nuMwYmjavD9aMOhN+12Pxpto7HVCmcmoYhe7iVVrFzQy+z X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8422 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/11/2023 1:17 AM, lihuisong (C) wrote: > Hi, > > Thanks for your review. > > > 在 2023/11/10 19:42, Ivan Malov 写道: >> Hi, >> >> (minor question below) >> >> On Fri, 10 Nov 2023, Huisong Li wrote: >> >>> Currently, testpmd set tunnel TSO offload even if fail to get dev_info. >>> In this case, the 'tx_offload_capa' in dev_info is a random value, >>> >>> Fixes: 6f51deb903b2 ("app/testpmd: check status of getting ethdev info") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Huisong Li >>> --- >>> app/test-pmd/cmdline.c | 29 ++++++++++++++--------------- >>> 1 file changed, 14 insertions(+), 15 deletions(-) >>> >>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c >>> index 05078f8377..25462bdbfc 100644 >>> --- a/app/test-pmd/cmdline.c >>> +++ b/app/test-pmd/cmdline.c >>> @@ -5035,39 +5035,33 @@ struct cmd_tunnel_tso_set_result { >>>     portid_t port_id; >>> }; >>> >>> -static struct rte_eth_dev_info >>> -check_tunnel_tso_nic_support(portid_t port_id) >>> +static void >>> +check_tunnel_tso_nic_support(portid_t port_id, uint64_t >>> tx_offload_capa) >>> { >>> -    struct rte_eth_dev_info dev_info; >> >> Why not just initialise this to zeros? > The main purpose of this function is to check which tunnel TSO offload > port supports instead of getting dev_info, right? > Agree with Huisong, zeroing out the dev_info doesn't help much, this function still will fail to do its job, and caller function will still get wrong dev info. >> >>> - >>> -    if (eth_dev_info_get_print_err(port_id, &dev_info) != 0) >>> -        return dev_info; >>> - >>> -    if (!(dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO)) >>> +    if (!(tx_offload_capa & RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO)) >>>         fprintf(stderr, >>>             "Warning: VXLAN TUNNEL TSO not supported therefore not >>> enabled for port %d\n", >>>             port_id); >>> -    if (!(dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO)) >>> +    if (!(tx_offload_capa & RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO)) >>>         fprintf(stderr, >>>             "Warning: GRE TUNNEL TSO not supported therefore not >>> enabled for port %d\n", >>>             port_id); >>> -    if (!(dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO)) >>> +    if (!(tx_offload_capa & RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO)) >>>         fprintf(stderr, >>>             "Warning: IPIP TUNNEL TSO not supported therefore not >>> enabled for port %d\n", >>>             port_id); >>> -    if (!(dev_info.tx_offload_capa & >>> RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO)) >>> +    if (!(tx_offload_capa & RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO)) >>>         fprintf(stderr, >>>             "Warning: GENEVE TUNNEL TSO not supported therefore not >>> enabled for port %d\n", >>>             port_id); >>> -    if (!(dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_IP_TNL_TSO)) >>> +    if (!(tx_offload_capa & RTE_ETH_TX_OFFLOAD_IP_TNL_TSO)) >>>         fprintf(stderr, >>>             "Warning: IP TUNNEL TSO not supported therefore not >>> enabled for port %d\n", >>>             port_id); >>> -    if (!(dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_UDP_TNL_TSO)) >>> +    if (!(tx_offload_capa & RTE_ETH_TX_OFFLOAD_UDP_TNL_TSO)) >>>         fprintf(stderr, >>>             "Warning: UDP TUNNEL TSO not supported therefore not >>> enabled for port %d\n", >>>             port_id); >>> -    return dev_info; >>> } >>> >>> static void >>> @@ -5077,6 +5071,7 @@ cmd_tunnel_tso_set_parsed(void *parsed_result, >>> { >>>     struct cmd_tunnel_tso_set_result *res = parsed_result; >>>     struct rte_eth_dev_info dev_info; >>> +    int ret; >>> >>>     if (port_id_is_invalid(res->port_id, ENABLED_WARN)) >>>         return; >>> @@ -5088,7 +5083,11 @@ cmd_tunnel_tso_set_parsed(void *parsed_result, >>>     if (!strcmp(res->mode, "set")) >>>         ports[res->port_id].tunnel_tso_segsz = res->tso_segsz; >>> >>> -    dev_info = check_tunnel_tso_nic_support(res->port_id); >>> +    ret = eth_dev_info_get_print_err(res->port_id, &dev_info); >>> +    if (ret != 0) >>> +        return; >>> + >>> +    check_tunnel_tso_nic_support(res->port_id, >>> dev_info.tx_offload_capa); >>>     if (ports[res->port_id].tunnel_tso_segsz == 0) { >>>         ports[res->port_id].dev_conf.txmode.offloads &= >>>             ~(RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | >>> --  >>> 2.33.0 >>> >>> >> >> Thank you. >> >> .