From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0078.outbound.protection.outlook.com [104.47.36.78]) by dpdk.org (Postfix) with ESMTP id 291971B1B3 for ; Tue, 26 Sep 2017 14:33:05 +0200 (CEST) Received: from CY1PR03CA0042.namprd03.prod.outlook.com (10.174.128.52) by CY1PR03MB2364.namprd03.prod.outlook.com (10.166.207.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Tue, 26 Sep 2017 12:33:04 +0000 Received: from BL2FFO11OLC003.protection.gbl (2a01:111:f400:7c09::139) by CY1PR03CA0042.outlook.office365.com (2603:10b6:600::52) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.35.12 via Frontend Transport; Tue, 26 Sep 2017 12:33:04 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11OLC003.mail.protection.outlook.com (10.173.161.187) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.56.11 via Frontend Transport; Tue, 26 Sep 2017 12:33:03 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v8QCX1YC008924; Tue, 26 Sep 2017 05:33:02 -0700 From: Shreyansh Jain To: Ferruh Yigit CC: , References: <20170823141213.25476-1-shreyansh.jain@nxp.com> <20170909112132.13936-1-shreyansh.jain@nxp.com> <20170909112132.13936-4-shreyansh.jain@nxp.com> <916531df-edb4-d0fe-cb86-32cedb6fc46a@intel.com> <690be1c8-67d1-31e0-b1dc-4b270b1f8519@nxp.com> <3bf46b37-6bcb-b6c5-62ea-5632f81f518a@intel.com> Message-ID: Date: Tue, 26 Sep 2017 18:13:55 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131509027838776793; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(376002)(39380400002)(346002)(2980300002)(1110001)(1109001)(3190300001)(339900001)(24454002)(199003)(377454003)(57704003)(132844002)(189002)(6666003)(64126003)(2950100002)(93886005)(5660300001)(8676002)(58126008)(65826007)(316002)(36756003)(189998001)(53546010)(97736004)(33646002)(54906003)(6246003)(6916009)(105606002)(104016004)(47776003)(23676002)(65806001)(65956001)(4326008)(76176999)(54356999)(50986999)(106466001)(8936002)(31686004)(53936002)(8656003)(50466002)(2906002)(229853002)(81166006)(2870700001)(81156014)(83506001)(356003)(86362001)(498600001)(77096006)(31696002)(85426001)(305945005)(68736007); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR03MB2364; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11OLC003; 1:WjK31PgepEj0pn52hm5xT+lVMOccEHmYRteXE4V0wgy8dEnsupzDLHgVfjbBizB4Yi1Ym2km36HdMywhqeC+kTjsUEFYJJQDQokFEx8LyGpaYIGRAukRKVmpB3quT2Wr X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 35486499-4ba8-4e9d-f47a-08d504dabb8a X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:CY1PR03MB2364; X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2364; 3:mWelemrR2ZcHvn9UEPtip+DZEVkEGt7xDjbCmD8wQ+jOx9YAGbtd0dPTKnKAMTfHJbE4iLNsaXpSLz01gTSIeA5px5Vyl1USJdIxc8SoMpKBV/7nNyDqQWOvyBKQja06YziisziPYtkPq6qg9XOtN2ZQWX66PlYnWOwvqq1jGLlDEm3q74+iivohJ8UQyH4xU5mVWeUz2LFjF9vIV4qVbprObiB66OZw3UJzNhNGx9mTf5Tad2oAK1K9V+4wOPcrfkGykTH35u5/exvMEwwIuzqSHwczIWYI2+pDD+moJYQSXe+lRHCaIIQGgfzzeLoCdtVZzzxib3yP/455H7d8xXgwVtPRIPKunh9eax77wVo=; 25:nVQ5KFZsZUOg82h8dn2CREZYW8a/62mNxl9ICNjPglJzZQtJjULo0LycD43pdRY+R6+KewuExdN03IRPskpF4QsTsF+tvVx6MDmjQiEcDOU74g/+IrdYrJmQSfN74fhoBMk0AFZDFR3WD1CGFRk4s3ZaD0no1VSgZXVBuxv5kIbl0FZJFLueJm6fWJjZxlVyuYaJcz879hVd7efeKeDoH/u+WkS43RuctwBgRga2utjb35L/TT/6+ZCFgAq6F35mO3XdJ7BzaUWx+oLNmFKiw6VKCighzBqlxcM0Zhum/3DgaOGU7bShEJrxgl6Zy6a8JEyJBAJ5XQFbaNBXOiZ/xw== X-MS-TrafficTypeDiagnostic: CY1PR03MB2364: X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2364; 31:q4AeFsk7i8JrYBN5j/rg91owHD5es7MGhKjh0fEAux0DOLKftQpTFhbxSSx8Vbw6IF/9ujDaVPDnxSf9idHhlX/ZHNnp832EbHExT2SGengD7utCDwwmeiJ0elUmyd+7lTIZL2uYHoARqa30TFqwOiAexI7gljn2WXMgOkZxlnN5zkAldPMPG2XwEpqWJoJCvke+uczW2x+DUDqJygnu+iW5sFtf3WqbUL2FNK/4ikc=; 4:hkeJC1aelKDYEmIJbPaNJrJd8hgIrp6T4zD6z4PHq/rQcqDJXfD2OS0RfEaTqca4kW7l+dVqxkILLBzxbgcHTNuLLRDyjr8ihb4NeU1ySImbP4dpKrRtLWoGFIeW/5K6FuDeVcRVXW9vIwV0er3DGkWFZpy9RjY0TGzYEEYfrR3p4MkZ4tvdEK2/ipv5BLtH5aRDXzGGqN/ygL+MC18DF+5Vs5aXMyNS982YlamlBIMSwXEMeTMkY2/xtQIocSYS4/CN6pn0fNwafUTgxXmj8/YqKT2l+reTIVh6BKHDVjc= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(10201501046)(93006095)(93001095)(3002001)(6055026)(6096035)(20161123563025)(20161123561025)(20161123559100)(201703131430075)(201703131448075)(201703131433075)(201703161259150)(201703151042153)(20161123565025)(20161123556025)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR03MB2364; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR03MB2364; X-Forefront-PRVS: 0442E569BC X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjAzTUIyMzY0OzIzOjRLTGtpLytBNnJaeUJYMjR0dUk2YXlMNURM?= =?utf-8?B?dUEyTkd1SEJUZFdEZ2R3Y25kOWlQLzltWWNFdGkycjhESmlQYTlBRyswZE4x?= =?utf-8?B?YVNnTTEvYm5RaE9GbmlJTStwNGs0c3FyZE04aFVVcUNNYXFQTTBZR1ZabHNw?= =?utf-8?B?YTcyMFBZdlBOYmJBWHFNaWE1b2ZWcC9Xd2dFLyt4aEgreUtxTnZkOTZGZDBN?= =?utf-8?B?NSs0R2ZTOXZJMWxHT21vZ3QvYitIOWpGSXFyc0Y1YzVNUGxVMER3Zno2ZEtX?= =?utf-8?B?Sm05SDhhWURCb2ptR1FTVTFDU3M2YytSZTRWa09LMVp0K0tMRXNwalZSSDhv?= =?utf-8?B?Y3Fjd1g3cUwrK2Y5azBOdHltb2VPWUVNTjF6cTdETW5jZ2JoWENZL2s3YjFq?= =?utf-8?B?TlZ3OU9nbDF4SjB5a1VyVmVxTFB4QnJ6YjlIUU1IRDBPU05uYXFvMmt2QmhU?= =?utf-8?B?R0RqVW9QYS95OWdUZVBuQ0dRUHI4SXNzQlVHeFBmNnJJUzJmbmxZcldZZGxN?= =?utf-8?B?aEcrVHJvemFwaDFCRHF6NmJ2SCtTenBKT3R1YW5QM1pmaE1NbmlSa2Z5ZUtV?= =?utf-8?B?ZFM2WFlQRWFIeHRSc3VKU3NKdEYxejcxQnNMYXh0Y3lHRWp3Mm9HN3hlVkhv?= =?utf-8?B?b1hlRG5zWEc4UnU1aThoSW5wRU9sU2xVeGNoa1N6UnFBaVhncWZjSzA3NzU1?= =?utf-8?B?VkxmY3ZtcWxSdm9HS1p5aWgvWC9VUUp3b0RYeGpJanBUYkoxUkNSMXlDVUJt?= =?utf-8?B?QTFSNzF5UnJJZDZOdXA5K1c5Z3NaT3Z0T1V0bzZDbWJuRGRHd0Z3RlFSMFNo?= =?utf-8?B?SzZmM0RGSzFqV3lmZjZDY3hEM29YWVA4amFRMjlUc2pmWjl2bmFaUmhlQU1D?= =?utf-8?B?Z1MrTTB3RDk4ODY4ZTRVRUdxK0lreXJzbkFPUEJlbURNbUMzNnFETTY4UkNW?= =?utf-8?B?dTJnRnlvRFFudTF0SFMyM1dwWmNFYkp5K3E0cldBN29mdThaVE45Wk1OclRI?= =?utf-8?B?V0d3OUtrSHBBbDlJcytaVkpDQTR2S3poejl6YkhEdUJ0a01aZ1N5b3B4WjAv?= =?utf-8?B?eGtTQytzN2ZRSFB0SnNwM3lNZmlXQXNuS09YeVNSbEU4bTkrR29ZNzBYeFBZ?= =?utf-8?B?Rm1oK0ZSdUl0QUtjdVFOdnc4TjNqRkxpcm9jTnZzU0VRbUk4OXVocUIrUlJU?= =?utf-8?B?Z0EwWnByYkxhMldGdEFOOWRubzc0WnJhTTFPSmlsL0VYWFY0RVBESjJNVmUz?= =?utf-8?B?NUUwWVBNVmVpY0NCdUxSMllXTzA1a1dld1hPeGhYcXIzNE5OWFVQRzJlMFUy?= =?utf-8?B?R0xHM1R6MG9nemVFMndydS96a002NUkwcm1ZUFFWYTdvSUNWZjVSOFJJQXFn?= =?utf-8?B?QlcvRGE4V0lmdEp1Wk1XajMwYWNGUlhycXZtaDBMQ0RlMUpSaFY5Rm5jTTdl?= =?utf-8?B?SlN6OE5rWHBaZ2d6cUdoUHFzZlp4a21jcmtDMHBwUGNTaU95eEVnMnFrWTVL?= =?utf-8?B?eUtnOTU3OUtaU05wQnI0TzFsYWtPQUZ6TmhrNzBEMmZ6TlhIYWFRMkJLb0ZX?= =?utf-8?B?OUI4bXRZMzM5bFQyK3Y1empYYldXSUtBSUFNRVBKSHZEejdheGVuQktJcFNU?= =?utf-8?B?bmdVSHQ1MXNoa3QyWXVsanEyL2RDNFRKZkNuU3RBL2tVb1hNalBCOXVFOWpH?= =?utf-8?B?NkQyOHZOVzcrVGlreC93cTR1TVc0SlhWNStwWmF6cVFwS2oxYXo4QWdIbklz?= =?utf-8?B?S1RKRUROQXBWNHljVUdGcUF3NnhBS1hhUC91V3ZTTXI4UU5RRTYxd2pneUc3?= =?utf-8?B?SzNDaHBOVG9Bc0JtMTM4M2MzZFNnN0xiY0JUMzlzWDFHd1VrbGFQRlkxVk01?= =?utf-8?B?ejVscFc1WVhaUlQ0T2F1SVlLTlc5b2FUTW1HcGQveXBXdWh4eWNGb21GcXZy?= =?utf-8?B?U2U2T1Z4UGNhWmJWRHR1eERiMDB0UzRNKyttNGRZR1p0QjNEbDBXNkx4Vm00?= =?utf-8?Q?e7CDbi?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR03MB2364; 6:VjToT55HgPiuG/2Vsr1kZ/YW0GXADNMucAyYcoVULTbgl2ptpQbuLA1TWIvFDRdUnNWuCSaSYV9bBpNmk3KD4EWiZSr5tsJgTMjtvXXoO5wbvXaLndq4Q7Ygm48S1etj34p2I3WLexurmQWLJp8C771iwbcoV2RvunESN/ggf9Fkudo00OfabVTfA8danO8W+THOVZCOc9oqqhPG34JLP1Ekv/HHF5s28TifTaIbtS688rEpERmowlIlTAOEeYG+/Q4h7JxDb+/rSBno+nse5ZZ8RhB2r3C7V8KNv7kMf1rLoTWdUasOdupALke/9f3AuplcEy5twzN3XhfhDlZmyQ==; 5:b5X03MmCiyKGL2phIGXzPi9J1lE3cL0WXB3yi33Ccpt6cK9Y08wHyp3K6fYdgwPtCSKNwycZ250jQR58wRlOJICjEMECgyGa6itxkql9p5r02rimyKd8ccwnNl+zim8RaFcuuIKyJSl12I5+ve4eqQ==; 24:ti5PLbHRaTpg15k4AFgEZefJxOckqzyl1lx9xbMJde4Gr4/k/sesTZxI7tLLAkyE3KiAZhVa3g5WV1ADgqMLM7HP5V4mjHAP6MzgoVN/3zM=; 7:Mj63qxmWQeODmjKOu21W19da2AfIcg/48PkgsXp+joJF3KgH3yo+KZ5XysKqj9g+OdZOb0bupmuMODg9hYuJ05Cf0hwEUKHulY8Z0DwudS7mt12FHU6p2CIoLBpWAhe18y5pF5ohVxrzl1d59E59L/fY6tL+pus75fNcyO4iGV0u/YtdIoqQsUIiAds69gZIeQyC+HUHDFr7SLtubfxfekvToFOZ9jrOxPb2Uu8CzHg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2017 12:33:03.6592 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR03MB2364 Subject: Re: [dpdk-dev] [PATCH v4 03/41] bus/dpaa: add compatibility and helper macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Sep 2017 12:33:06 -0000 On Tuesday 19 September 2017 07:27 PM, Shreyansh Jain wrote: > On Tuesday 19 September 2017 07:10 PM, Ferruh Yigit wrote: >> On 9/19/2017 2:18 PM, Shreyansh Jain wrote: >>> On Monday 18 September 2017 08:19 PM, Ferruh Yigit wrote: >>>> On 9/9/2017 12:20 PM, Shreyansh Jain wrote: >>>>> From: Hemant Agrawal >>>>> >>>>> Linked list, bit operations and compatibility macros. >>>>> >>>>> Signed-off-by: Geoff Thorpe >>>>> Signed-off-by: Hemant Agrawal >>>> [...] >>>>> + */ >>>> >> >> <...> >> >>>>> + >>>>> +#ifndef __DPAA_LIST_H >>>>> +#define __DPAA_LIST_H >>>>> + >>>>> +/****************/ >>>>> +/* Linked-lists */ >>>>> +/****************/ >>>> >>>> Do we need to maintain a linked list implementation, why no just use >>>> sys/queue.h ones as done many places in DPDK? >>>> >>>>> + >>>>> +struct list_head { >>>>> +    struct list_head *prev; >>>>> +    struct list_head *next; >>>>> +}; >>>>> + >>>> >>>> <...> >>>> >>> >>> The underlying DPAA infrastructure code is shared between kernel and >>> userspace. That is why, changing the internal headers (for example, >>> using RTE_* queues) is something I want to avoid until absolutely >>> necessary. The outer layers (drivers/*/dpaa/) are something I am >>> trying to keep as close to possible to DPDK. >> >> I understand you want to escape from maintaining a copy of common files >> for DPDK, this has been done by many drivers, as not changing "base" >> files, this makes sense. >> >> But for this case, file is "dpaa_list.h" and as far as I can see all it >> has is linked list implementation, this looked easy to exclude, but if >> not you can ignore the comment. > > Got your point. I will respin and see how much is the impact. > Thanks for inputs. I tried to work around the dpaa_list.h use in DPAA code - but, the changes are subtle but large in number - though, restricted only to base framework. I would prefer to skip this for a while as the driver is stable now. I would probably do this change in a incremental manner to keep it traceable. Ferruh, Is that OK with you?