From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0449342D71; Tue, 27 Jun 2023 13:34:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E7EC2427E9; Tue, 27 Jun 2023 13:34:49 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2084.outbound.protection.outlook.com [40.107.220.84]) by mails.dpdk.org (Postfix) with ESMTP id 7EB2A40EE1 for ; Tue, 27 Jun 2023 13:34:48 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XTO6Rm2VWqUDpV84RhBfz6YfsOa2gcic/eTnTlRZy+ePEJiLquUP8G8Pu1Tx8UbCPNg5Om9y7G0/HjoWaf/GlZlThjl03wkAIpzAQbFggtG/tJlLmnf+DaekRSpJgTia+usNvEzaDiY911dAAC3F1g46U60371nMSZwXK33LI75/vu6VWV5bow/fN7ZdrzaVe2912uSGYLOp9YSiGMot/LOH30OmELCi2OQ8ZvylNeLwilQarI5RpF/pDgPVVqcdinMr2uzfat74PTSi2kCORukvnvU3idaO4DHqnJGNV9ZMguCI56j9YUn3PCPRoWFDRAjQ4r7cmoUP7jNaunAx+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B+OZuwckrTD4SCFVNYRotmsgQXzR1EtUE9cDf4myOUU=; b=OwpJ6qMYr8Mus6yUQ8KsfJ9+Mc+PagKZTg4aOqFB3UaVFWyQn6u5BVzWPmNbJH+uqSHCJ7nLTEVyWwcojON++DEM6cdsQOMX43855BO5xcK3f5eOH5Cd9bdboMJ8SWjL9w2HYY+460YWk3sZ/T9xRQDk3tQxg2Ex5EEbWpA4DL6V1gqipUz9+hCTrc4SeqT00HCSylnP5/hVdzYTTgTOh2l3wXTK8hbNXYaylbbh1zo8itTGr3wA+nd0iMFvbcPpwICkgxSovbpnepoDACRUfq5Gi0aRFWKBdJSCn1kDqXp14MlVbwce4JOIXVl+/a/mdSilc3SPuYccyJ8wSzwqxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B+OZuwckrTD4SCFVNYRotmsgQXzR1EtUE9cDf4myOUU=; b=Eeeznas8mdDw93O4EWWrCUk5E8VZsXiNYmZhvXAfeus/DV6N3y3lwCDu5B4+YYIfwp44nvWKQi/7R1AoYxVAR0TYMZVwhBh+FZAO8OKnGipp9oMiBDZf3JwZ99vi0YwJZM0SSj86rnoJ7CnRQNSjZoONFr1kPDW1h18vvAEywIQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ0PR12MB8139.namprd12.prod.outlook.com (2603:10b6:a03:4e8::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Tue, 27 Jun 2023 11:34:46 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6544.012; Tue, 27 Jun 2023 11:34:46 +0000 Message-ID: Date: Tue, 27 Jun 2023 12:34:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v4] app/testpmd: add trace dump command Content-Language: en-US To: Viacheslav Ovsiienko , dev@dpdk.org Cc: jerinj@marvell.com References: <20230420100803.494-1-viacheslavo@nvidia.com> <20230626115749.8961-1-viacheslavo@nvidia.com> From: Ferruh Yigit In-Reply-To: <20230626115749.8961-1-viacheslavo@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR0P264CA0212.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1f::32) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ0PR12MB8139:EE_ X-MS-Office365-Filtering-Correlation-Id: 12d0ffdf-2b6e-46c3-313d-08db770281f9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sP6SvT3Uh7dPU+3NsNaiPnMYlfaTziGlOQRRkQ5mZs/0O0EEP0iRZunOguUsoJfolIbYtiRZDPoIVuchK6I/gOGjRPH1bbzf4fTeD6CqXYmlq8zCzm7xZfHUF6ImuFRbQRkCR/q9+DLU6ZZGm/B9XyCmaQ8XNOsdXFULpcQINms67d4gZsfZPfv1pT5lp2Gi8Eb8bhKww6vXWGISgDOlXAdFPW1zToSuhDYaf6w7qFbP4RbaFtXTPyN8sP0IoFw3kCwT45PljPx3irCoWmW+976yYV9EmEjFCc7cdvR9Xncp2KdymUzGH1vRez6AaNnZ6qNNYBzD4ZnaNbihXS1dVca95mHB7Kbh76KvIicrWpVBa02GlV00ulXVxBp9bDLBvs+1l6pA5EPEkLmmXNy27VpMg6QB/ZJSyII6J9zdZ3K51o+bGmYpqxOQx1+iqVXSY+Nf+OkG+7zZs5BV0hihgqnJQk+iNHBuHsa5K/0ABS5EYkPUuL2756ctbGU2KYegVtNxfA3DAGsUvST0/1tcz0dY3T53w2l5ESF6ekUeTL5lD3nmwZ6DTjhBMe9OS2CZCORrD0fQniuzSlcG6OtESFvaV6egii2GHOu+snnCewLiDWPBnA3Lop8CLtjOUJff5cVvAgyYZoSFoOkGaMVCyw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(376002)(39860400002)(366004)(396003)(346002)(451199021)(86362001)(31696002)(2616005)(41300700001)(66556008)(66476007)(8936002)(478600001)(316002)(44832011)(5660300002)(6486002)(83380400001)(66946007)(53546011)(6506007)(186003)(966005)(6512007)(4326008)(26005)(8676002)(38100700002)(6666004)(2906002)(36756003)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1RsbjBhcUd0QWpycGJDeDJReWE1RE1IL0NiU0xiZmtTUHF0Q0ZTTzFEc1Rk?= =?utf-8?B?ZmdVQm85clIyb0o4bWtlU244TnhaOGNvMXJCaTVrSlZpTlUrcVdzenBITElQ?= =?utf-8?B?UFEwSVlHSkZIbkx0QmN1MWxlY1RSNzVDTFpWL3BoME5TWENERDR5RmdSbSt3?= =?utf-8?B?TkZqbmVoallralVHNldjUnJSSWNJUVBtQ0c2cnJFTEJDQzlBZDlncm9UeEp3?= =?utf-8?B?dk12aUNiS3E0SzdEdkNJQWRkVWV3MWgzUi8wakJhV3hldFVuK29DYm1OVGt3?= =?utf-8?B?cVE2OTRTSDJjRUNuS2tqdGpjRzBSOE1oMGljNUN5aTFRMVYrdUNTcWE3SjdT?= =?utf-8?B?NjE1bVp2enFCM2ZQZmVTU1lVQUFYRDhJYUdQMkJxNFNkVE5HVEpwbStlV2l2?= =?utf-8?B?Rm5wMzg3ZTVNbjA2MHdMdlQ2S0ZVdTlJSnBWWlBFUlJHbDhYTGRNUCtnblJx?= =?utf-8?B?TWxkZmVCR0lpN2xER3dnb0RvNHIvYWc5VFVZdkpqNzhIMVhuVTB6SW5mSmpE?= =?utf-8?B?V3NOcHhTTnlCa3ZYOWsvWlZaYlNwTFg2OWpmUFhFZlpKc25vd21XRnpWR3lZ?= =?utf-8?B?dlBjak9uMXhVRmpYQjFkSjBiYWUrOVhLSDd0UHJ5NWs4VmxqbnN0MTZRZm9U?= =?utf-8?B?YUJERVowZHF3S1VTMVdSaFBud1dHS3pRZTg3TWkySDdlbEpuS0VFaW1kOEVu?= =?utf-8?B?N1liR2xMZkZ6M3VscHdRbzZqc0cyVkxNUVU5UXRCMUNOZmQ5SXE1d0c2eFAz?= =?utf-8?B?VFQvTnBLeDdKb0ZTMzZzditVZ0ZjUTI0UStoZjdON2lHcS9iV1pMRmJ1V1Jr?= =?utf-8?B?OTBhVitzc05hRVdod2ZJYTJYdDlQWGgvWTBpNTV2SFZqMXJiU3RGVnJjL0Jo?= =?utf-8?B?M0ZwaGlCb0hsZUdXVzl2YmpNZU92cWg4b01md09wOWRXRnhVTGZ0UWMxeDg3?= =?utf-8?B?dVVDemwrOGxTTk1melAvVGxXNWFObUNDaFZzSHorZHN0bERiK0ZOaXhRQVJi?= =?utf-8?B?RmVKS1hRZU02TU11TlozSEZkdThwek1yY3hrTEJVZm5XdWpUMjQ0NHVmVU1M?= =?utf-8?B?bU1FT04wa3RBTGw0VkFSNzkrTVhuWVlmTlhKcjNML2RwUFdXQjdxUk44VkRx?= =?utf-8?B?ZUtQY29UL3RrTjhjOTk5cmdUV3U2VG1GMVVDbGhzbUxGTXFvaGJBN0IzaVVo?= =?utf-8?B?a0pDV0dVaUUwQVVUTHZrV3JmZVpXdHVFaUhrUDdZWnhWenZDbEk0ODVJNlR3?= =?utf-8?B?K0hKME94Wlo5YUJhNDIvYWZIYkNkM1NtVWJIc3hQVnFKTm9xVk1weHU3WFk2?= =?utf-8?B?aEZYUHBoa05iOCtRTkNHQnI5RDdUVE16bFRGYVdiOE1Qc1pZdUFJd0tYMmxV?= =?utf-8?B?ZFErd3F4em5ncVJnRW4wb3NmbzFibVRJaGFPa3lweWZSVUhBOWxSKzZRRStO?= =?utf-8?B?YXlNSk5HOHlPMTBOREtucEJ6bHpwcVJNY1RJRmozVk1KY0RpVXZQYnF5QjFW?= =?utf-8?B?SWFwTzRiT3M2YUp2MU05MWRGNWhMZDRwMURnTWJzTkRiSU9ETWlaZEQ0YkdR?= =?utf-8?B?MGhDTlFiWWVFcGY3c1ZwVU9zazFYbnd4Z1lJVjJZbVZvUXNySEpCMG5TNGhi?= =?utf-8?B?Z09aMWRjV3F2Y0hsbDhqTG5PLytCVlkwQ2JmeGpNZUxzZHFHRlppOTh0N29h?= =?utf-8?B?M0IyZ0xSM0tJdkRmdTFHT3ZiWjM3RXkvNmk2NDVoWSs0blpKSGYvdU8ySmxG?= =?utf-8?B?b3BmaXY5ZCtyU0N1VlRxL1IyMkhpNXp0a0NIcUVaZlorZWxsQmlVdFpkY2RM?= =?utf-8?B?M1l3SUoydjhCcHdRWUpnUkdWSG00N01rSnJja1U5aEIzWjZqeGFLY1NsK2h1?= =?utf-8?B?bTNTYjJuL2N3d25XRS9VbHpMNlB4OW96U1hRZHc2K2xnaEFGVkRNTm1DNWZN?= =?utf-8?B?RnZIVnQvVWM5Mk9ZY0hNcE4rMWVPM2N6enhPWTdBYkNOaFBhUHJDVmQyZGRw?= =?utf-8?B?T2paa2x0cDFocEhIYWZrUGRzUzRHTGsxd0plT0dldHk0TDZWQTM0T0xHSFVz?= =?utf-8?B?TmxKNElCQlhTN2VhK0R6M3Jza3F5UlVnN2gyeitPS3p4ZmhRME9ucUgyMXpu?= =?utf-8?Q?M6qq5iSYSL1NVJh8nFXAP3v85?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12d0ffdf-2b6e-46c3-313d-08db770281f9 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jun 2023 11:34:46.0256 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /EyYrsIJSgOzBxyiOKJMuPFMz8o2z+wXedCC26xpkRVjeT/L5yFLWsjbh4SrPXe3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB8139 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/26/2023 12:57 PM, Viacheslav Ovsiienko wrote: > The "dump_trace" CLI command is added to trigger > saving the trace dumps to the trace directory. > > The tracing data are saved according to the EAL configuration > (explicit --trace-dir EAL command line parameter alters > the target folder to save). The result dump folder gets the name > like rte-YYYY-MM-DD-xx-HH-MM-SS format. > > This command is useful to get the trace date without exiting > testpmd application and to get the multiple dumps to observe > the situation in dynamics. > > Signed-off-by: Viacheslav Ovsiienko > Acked-by: Ferruh Yigit > -- > > v1: https://inbox.dpdk.org/dev/20230609152847.32496-2-viacheslavo@nvidia.com > v2: https://inbox.dpdk.org/dev/20230613165845.19109-2-viacheslavo@nvidia.com > - changed to save_trace command > - Windows compilation check added > > v3: https://inbox.dpdk.org/dev/20230626110734.14126-1-viacheslavo@nvidia.com > - reverted to "dump_trace" command > > v4: - added missed header file include > - missed #ifdef added for Windows compilation (no trace support > for Windows) > --- > app/test-pmd/cmdline.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > Can you please update 'doc/guides/testpmd_app_ug/testpmd_funcs.rst' for new command? It looks like dump_* commands missed in the help output, 'cmd_help_long_parsed()', can you please append this new one end of "display" section, we can complete the missing ones later? <...> > @@ -8371,10 +8372,17 @@ static void cmd_dump_parsed(void *parsed_result, > rte_lcore_dump(stdout); > else if (!strcmp(res->dump, "dump_log_types")) > rte_log_dump(stdout); > +#ifndef RTE_EXEC_ENV_WINDOWS > + else if (!strcmp(res->dump, "dump_trace")) > + rte_trace_save(); > +#endif > } > > static cmdline_parse_token_string_t cmd_dump_dump = > TOKEN_STRING_INITIALIZER(struct cmd_dump_result, dump, > +#ifndef RTE_EXEC_ENV_WINDOWS > + "dump_trace#" > +#endif > Why not add "dump_trace#" as last item, to keep same order with 'cmd_dump_parsed()'?