From: "Mattias Rönnblom" <hofors@lysator.liu.se>
To: Jeff Shaw <jeffrey.b.shaw@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: remove variable length array
Date: Fri, 14 Dec 2018 19:36:38 +0100 [thread overview]
Message-ID: <dc4f658d-76a4-ff6f-d3c0-21084e439d27@lysator.liu.se> (raw)
In-Reply-To: <20181214163827.9403-1-jeffrey.b.shaw@intel.com>
On 2018-12-14 17:38, Jeff Shaw wrote:
> Compilers that do not support the C11 standard, or do not implement
> gcc extensions, may not support variable length arrays.
>
VLAs are a C99 thing.
> The code prior to this commit produced the following warning when
> compiled with "-Wvla -std=c90".
>
> warning: ISO C90 forbids variable length array ‘array’ [-Wvla]
>
> This commit removes the variable length array from the PMD debug
> trace function by allocating memory dynamically on the stack using
> alloca().
>
Is alloca() even included in *any* C standard? As far as I see, it just
achieves the same thing in an uglier, less portable way than VLAs.
next prev parent reply other threads:[~2018-12-14 18:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 16:38 Jeff Shaw
2018-12-14 18:36 ` Stephen Hemminger
2018-12-14 18:59 ` Jeff Shaw
2018-12-14 19:17 ` Jeff Shaw
2018-12-14 18:36 ` Mattias Rönnblom [this message]
2018-12-14 19:07 ` Jeff Shaw
2018-12-14 20:28 ` Mattias Rönnblom
2018-12-14 20:50 ` [dpdk-dev] [PATCH] eal: simplify RTE_PMD_DEBUG_TRACE Stephen Hemminger
2018-12-14 21:20 ` Jeff Shaw
2018-12-14 21:57 ` Stephen Hemminger
2018-12-21 16:17 ` Ferruh Yigit
2018-12-21 18:11 ` [dpdk-dev] [PATCH v2] " Jeff Shaw
2018-12-21 18:18 ` [dpdk-dev] [PATCH v3] " Jeff Shaw
2018-12-22 0:37 ` Ferruh Yigit
2018-12-19 21:45 ` [dpdk-dev] [PATCH] eal: remove variable length array Thomas Monjalon
2018-12-20 10:53 ` Mattias Rönnblom
2018-12-20 11:03 ` Thomas Monjalon
2018-12-14 20:40 ` [dpdk-dev] [PATCH v2] " Jeff Shaw
2018-12-15 14:26 ` Wiles, Keith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc4f658d-76a4-ff6f-d3c0-21084e439d27@lysator.liu.se \
--to=hofors@lysator.liu.se \
--cc=dev@dpdk.org \
--cc=jeffrey.b.shaw@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).