From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Chas Williams <3chas3@gmail.com>, jyu@vmware.com
Cc: dev@dpdk.org, Declan Doherty <declan.doherty@intel.com>, stable@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/bonding: fix buf corruption in merging un-transmitted packets
Date: Mon, 27 Aug 2018 14:12:33 +0100 [thread overview]
Message-ID: <dc51368c-256d-7759-d14c-6124547a7f88@intel.com> (raw)
In-Reply-To: <CAG2-GknsC7bO2f7Gf11jsOJ8jnCoK76Kar1WB0rfQw72hDKtWg@mail.gmail.com>
On 8/20/2018 2:58 PM, Chas Williams wrote:
> On Mon, Aug 20, 2018 at 2:54 AM Jia Yu <jyu@vmware.com> wrote:
>
>> When bond slave devices cannot transmit all packets in bufs array,
>> tx_burst callback shall merge the un-transmitted packets back to
>> bufs array. Recent merge logic introduced a bug which causes
>> invalid mbuf addresses being written to bufs array.
>> When caller frees the un-transmitted packets, due to invalid addresses,
>> application will crash.
>>
>> The fix is avoid shifting mbufs, and directly write un-transmitted
>> packets back to bufs array.
>>
>> Fixes: 09150784a776 ("net/bonding: burst mode hash calculation")
>> Cc: stable@dpdk.org
>> Signed-off-by: Jia Yu <jyu@vmware.com>
>>
>
> Acked-by: Chas Williams <chas3@att.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2018-08-27 13:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <net/bonding: fix buf corruption in merging un-transmitted packets>
2018-08-20 5:18 ` [dpdk-dev] " Jia Yu
2018-08-20 13:58 ` Chas Williams
2018-08-27 13:12 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc51368c-256d-7759-d14c-6124547a7f88@intel.com \
--to=ferruh.yigit@intel.com \
--cc=3chas3@gmail.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=jyu@vmware.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).