From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2C4932C72; Mon, 27 Aug 2018 15:12:35 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Aug 2018 06:12:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,295,1531810800"; d="scan'208";a="68173314" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.56]) ([10.237.221.56]) by orsmga007.jf.intel.com with ESMTP; 27 Aug 2018 06:12:33 -0700 To: Chas Williams <3chas3@gmail.com>, jyu@vmware.com Cc: dev@dpdk.org, Declan Doherty , stable@dpdk.org References: <1534742325-10181-1-git-send-email-jyu@vmware.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: Date: Mon, 27 Aug 2018 14:12:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/bonding: fix buf corruption in merging un-transmitted packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Aug 2018 13:12:36 -0000 On 8/20/2018 2:58 PM, Chas Williams wrote: > On Mon, Aug 20, 2018 at 2:54 AM Jia Yu wrote: > >> When bond slave devices cannot transmit all packets in bufs array, >> tx_burst callback shall merge the un-transmitted packets back to >> bufs array. Recent merge logic introduced a bug which causes >> invalid mbuf addresses being written to bufs array. >> When caller frees the un-transmitted packets, due to invalid addresses, >> application will crash. >> >> The fix is avoid shifting mbufs, and directly write un-transmitted >> packets back to bufs array. >> >> Fixes: 09150784a776 ("net/bonding: burst mode hash calculation") >> Cc: stable@dpdk.org >> Signed-off-by: Jia Yu >> > > Acked-by: Chas Williams Applied to dpdk-next-net/master, thanks.