* [dpdk-dev] [PATCH v2] tap: remove unused KERNEL_VERSION definitions
@ 2017-12-27 18:28 Stephen Hemminger
2018-01-12 18:14 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2017-12-27 18:28 UTC (permalink / raw)
To: dev; +Cc: Stephen Hemminger, Stephen Hemminger
The TAP device does not use these definitions in current version.
And kernel version is not the correct way to detect features.
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
---
drivers/net/tap/rte_eth_tap.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index 6b27679a8ea3..340ebe59b6ad 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -60,7 +60,6 @@
#include <net/if.h>
#include <linux/if_tun.h>
#include <linux/if_ether.h>
-#include <linux/version.h>
#include <fcntl.h>
#include <rte_eth_tap.h>
@@ -78,9 +77,6 @@
#define ETH_TAP_MAC_ARG "mac"
#define ETH_TAP_MAC_FIXED "fixed"
-#define FLOWER_KERNEL_VERSION KERNEL_VERSION(4, 2, 0)
-#define FLOWER_VLAN_KERNEL_VERSION KERNEL_VERSION(4, 9, 0)
-
static struct rte_vdev_driver pmd_tap_drv;
static const char *valid_arguments[] = {
--
2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH v2] tap: remove unused KERNEL_VERSION definitions
2017-12-27 18:28 [dpdk-dev] [PATCH v2] tap: remove unused KERNEL_VERSION definitions Stephen Hemminger
@ 2018-01-12 18:14 ` Ferruh Yigit
2018-01-12 18:16 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2018-01-12 18:14 UTC (permalink / raw)
To: Stephen Hemminger, dev; +Cc: Stephen Hemminger
On 12/27/2017 6:28 PM, Stephen Hemminger wrote:
> The TAP device does not use these definitions in current version.
> And kernel version is not the correct way to detect features.
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Fixes: 7c2d03d65f5e ("net/tap: remove Linux version check")
Cc: stable@dpdk.org
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH v2] tap: remove unused KERNEL_VERSION definitions
2018-01-12 18:14 ` Ferruh Yigit
@ 2018-01-12 18:16 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-01-12 18:16 UTC (permalink / raw)
To: Stephen Hemminger, dev; +Cc: Stephen Hemminger
On 1/12/2018 6:14 PM, Ferruh Yigit wrote:
> On 12/27/2017 6:28 PM, Stephen Hemminger wrote:
>> The TAP device does not use these definitions in current version.
>> And kernel version is not the correct way to detect features.
>>
>> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
>
> Fixes: 7c2d03d65f5e ("net/tap: remove Linux version check")
> Cc: stable@dpdk.org
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-12 18:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-27 18:28 [dpdk-dev] [PATCH v2] tap: remove unused KERNEL_VERSION definitions Stephen Hemminger
2018-01-12 18:14 ` Ferruh Yigit
2018-01-12 18:16 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).