From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE242A0548; Mon, 26 Apr 2021 16:20:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A8D7C41110; Mon, 26 Apr 2021 16:20:11 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id C610641104 for ; Mon, 26 Apr 2021 16:20:09 +0200 (CEST) IronPort-SDR: Ra+nbkkSodQV+A1pKBb78Sf2k9Rg7QUSwvewgXy9GzY6c3Vg0nDvOfLihkoUWdFBAVsxGcGq9f W6fNOcJEWBLA== X-IronPort-AV: E=McAfee;i="6200,9189,9966"; a="175824186" X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="175824186" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2021 07:20:08 -0700 IronPort-SDR: LSN/dPO53g/Qxotuk2EOmSPjZ4FAnBtFZksIZKaXUiQLGxa8VTpsm9VLs+kdrcwhnkMIEmyZdc RU9yXS4HfhrA== X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="402937761" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.252.12.153]) ([10.252.12.153]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Apr 2021 07:20:07 -0700 To: Anatoly Burakov , dev@dpdk.org, Jeff Guo , Haiyue Wang , Konstantin Ananyev , Liang Ma References: From: David Hunt Message-ID: Date: Mon, 26 Apr 2021 15:20:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH v1 1/2] net/ixgbe: allow get_monitor_addr for VF driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Anatoly, On 26/4/2021 2:49 PM, Anatoly Burakov wrote: > When .get_monitor_addr API was introduced, it was implemented in the > ixgbe driver, but only for the physical function; the virtual function > portion of the driver does not support that API. > > Add the missing function pointer to VF device structure. > > Fixes: 3982b7967bb7 ("net/ixgbe: implement power management API") > > Signed-off-by: Anatoly Burakov > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c > index ff65145f55..6cca039a11 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -605,6 +605,7 @@ static const struct eth_dev_ops ixgbevf_eth_dev_ops = { > .rss_hash_update = ixgbe_dev_rss_hash_update, > .rss_hash_conf_get = ixgbe_dev_rss_hash_conf_get, > .tx_done_cleanup = ixgbe_dev_tx_done_cleanup, > + .get_monitor_addr = ixgbe_get_monitor_addr, > }; > > /* store statistics names and its offset in stats structure */ Thanks for the fix. I ran get_monitor_address() on some ixgbe virtual functions here, and can confirm that this patch resolves the issue. Reviewed-by: David Hunt