From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0073.outbound.protection.outlook.com [104.47.34.73]) by dpdk.org (Postfix) with ESMTP id CA0EE107A for ; Thu, 28 Sep 2017 13:36:36 +0200 (CEST) Received: from CY1PR03CA0028.namprd03.prod.outlook.com (10.174.128.38) by DM5SPR00MB235.namprd03.prod.outlook.com (10.173.215.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.7; Thu, 28 Sep 2017 11:36:35 +0000 Received: from BN1BFFO11FD032.protection.gbl (2a01:111:f400:7c10::1:125) by CY1PR03CA0028.outlook.office365.com (2603:10b6:600::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.35.12 via Frontend Transport; Thu, 28 Sep 2017 11:36:35 +0000 Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD032.mail.protection.outlook.com (10.58.144.95) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.56.11 via Frontend Transport; Thu, 28 Sep 2017 11:36:34 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v8SBaWs3001813; Thu, 28 Sep 2017 04:36:33 -0700 To: Ferruh Yigit CC: , References: <20170823141213.25476-1-shreyansh.jain@nxp.com> <20170909112132.13936-1-shreyansh.jain@nxp.com> <20170909112132.13936-14-shreyansh.jain@nxp.com> <596a7bff-1179-1590-c9b2-92e8362460d0@intel.com> From: Shreyansh Jain Message-ID: Date: Thu, 28 Sep 2017 17:17:25 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <596a7bff-1179-1590-c9b2-92e8362460d0@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131510721949704807; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7966004)(346002)(39380400002)(376002)(39860400002)(2980300002)(1109001)(1110001)(3190300001)(339900001)(377454003)(199003)(189002)(24454002)(498600001)(50466002)(356003)(31686004)(104016004)(2906002)(81156014)(77096006)(105606002)(6916009)(8676002)(68736007)(6246003)(106466001)(230700001)(86362001)(53936002)(81166006)(229853002)(8936002)(305945005)(31696002)(33646002)(189998001)(6666003)(64126003)(2950100002)(83506001)(54356999)(316002)(50986999)(65956001)(97736004)(36756003)(76176999)(23676002)(65806001)(53546010)(93886005)(65826007)(47776003)(54906003)(58126008)(5660300001)(4326008)(8656003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5SPR00MB235; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD032; 1:NpCgAA9kSJdJQQ462TSSDb+DUxinv4zaQiuzC3PTQr9ZdUHE0J9YG6yj2+RnW8M49B9uWU0s+SctwDKCEOcwDBmSOgTWp+MFdG1AUWsCXKmytQp+giguCPOer5Ao8P0Q X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9752d7a2-6681-46fd-a267-08d506652c6e X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017052603199)(201703131430075)(201703131517081); SRVR:DM5SPR00MB235; X-Microsoft-Exchange-Diagnostics: 1; DM5SPR00MB235; 3:8F9g5Qjy/lbtG+Uc4PHuMZjUl0adHcdLgXRHtOVpJSudFJ9VeYlaL4i1J2qfovawXHKpXyiny64j76e1CwSuH1ucEan01o0TEIcRX93SxE+vuWGPVmFL50UoN8ZZfo04DkCnwAB1K14oYwRnEI+0oeVlCvhh+OX1HZijCt6gLzhbxuuuwZ9CLd5OKyRoPuTe0mLRJ1L1tj8vKPJe2EC91PBueEXu9wE7bV/B79i321zEv8J8qLVyNGrMLB+0PT6gRQi5Ci0QT4HYgOefWSMTPypT+94/EK7XLvRc/NrcVsR8KPX4fiRyW5N84QewFv59k78JoRv4miRVxRN3z0yNkFThW70xBOG3IegRQeSJl/w=; 25:4pLBmxr5eogJK+PzXi5moZklyeJyFf+awXM4BffB9t393avTDbZNIZV0PFZm7DqmwuSWdBs/jYv+yn21sO0KnDxA9H7qb5KSQMIicasLtsUwVqVbai5UYVLa1sYlo6+TSzIcJL+i3H/WlhUBNGaZUFWWdk/tvG4dlalMkV6cCdp12eJtJJCWPiVhoaM+Mxmfk4RvEGsbyNyry1MQ+JpxlgHvC71opKupcIwrPQg+Mx8o74FpQ5Bb4efiuJh3okCAP1mIRcv+jqGe7mEjq3h/sb7XRyuC8FsVSOncEGWfprf8y2eEYzvNR/aRyhHkkRLqso6DyhZ5eBF1v8jvYnnMVA== X-MS-TrafficTypeDiagnostic: DM5SPR00MB235: X-Microsoft-Exchange-Diagnostics: 1; DM5SPR00MB235; 31:4aspNo2c0yCtFYbd3Tq9GLDIVkZ1D2QvFSsVHKD2zdqspGK/fIP6r3hKXqF7r7MnBdS/v2t8DApjAHwywehq/t5strDfmiKr9x//5UsTQkP0N2SO+nAwLetpal2QwwEcf6OVKziewDibDrt/soFd3t3FR+Q/8wx7nlaT5xUPw39FgnqiMXkw98mijtzfcfKz/0I45aQvCdudjBZrMEN5RjctvVR4OkCnekKs5GJY1iE=; 4:qhPaiYac243U03LoeQGfNaw6D3Bvw6KieLeBrVFYXGSXRaae0xtuqQeHI7e7MlZg/gkhu8Zna8/Xm/AYumYMBqwivx6xGHgn2tr0F8k1E9377FqpNAjxPsz17Gm6MXaC1hG8H1m20SDuCRxh8U7VhReDCX1irBkM8v2f0F+wyjuhlT5EWY3pGnVsNP0l8YTz3HWImuJ3r4/yFctPtjIBFYUgKE0tnKpyIZdlZJbHZk3/uIteR4O7xiNJnx3y0WrQZIl6mS5WonyJAzeQimZcMWAfpkKwawMDPBEEI9CDPYY= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(3002001)(6055026)(6096035)(20161123563025)(20161123561025)(20161123565025)(20161123559100)(20161123556025)(201703131430075)(201703131433075)(201703131441075)(201703131448075)(201703161259150)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:DM5SPR00MB235; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:DM5SPR00MB235; X-Forefront-PRVS: 0444EB1997 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVTUFIwME1CMjM1OzIzOm5INVJNL1dNc1A1cmc1d1pPQ2JyVDQ1RG1p?= =?utf-8?B?UnQxS1A3S3JPVlRqd1QvYkJncWhMYnR1Q0hsQWc4NjhreEc5bkdDR0czbW1M?= =?utf-8?B?MXZtUlF2dm1EV0FGRkV4aUl6ZEZTUWM0N1A5L2VuWUdnS2tiTXdsREZxZUU0?= =?utf-8?B?UU1qcEtyallLSC9PU09FK29vNjlIY0J3U21HVk5JTzRzWEFKem94TS9KNWlR?= =?utf-8?B?aGlzWXNPZGRLcU9zL1dsc3VsaWxnOGRaaDE3SUJETEdOaXRpTXBCblNzaWJl?= =?utf-8?B?N0l3cTNXWEhTNXBoMG1tM3ZwdXZManZpdmhCMmFIRC9RRTNyRExjRUZDK3Nz?= =?utf-8?B?SVlvelNXcWJqem9oenMza1BmL2NmcGk5b2lzcHdwOEhnS3VEZFc1WXF2dEdX?= =?utf-8?B?dnF3cmhiWTk4Z1V1Z25tVjVEdWR5aUJyRE83TVVTeE1CRjBRclgyZlNFeThN?= =?utf-8?B?a2JOay85RkpCdjJtMXpMNjEyVHVqbWFhM1dCTk5FY2VTMjlpQzk5VzVWbmxq?= =?utf-8?B?d1VTQmc4SkQvdXVXTW9pYU9VeE9UZ1JWUUk2eVNzSzhha09sMm9mWC9SS2FC?= =?utf-8?B?VUJhWmNZZWtDNkVFYk93bTA4WGtMK0pQK2x4QUptTzR3NWF4akp5Y1hBaEc1?= =?utf-8?B?RXFCaUlOckNZdU1XVFNQZGpaakRMa3cxeUVqcXNFYWlxczd4Sm1PSXB4VEdG?= =?utf-8?B?TThVVkpYSWVVTFdNQUZXdWs5Zi9WK204UzJuVSt4cWI3S0tGcVhTakp6NmNU?= =?utf-8?B?KzVKbVljbDNpMnhDdHRSKzdyYk9SWTA2T3ZnZTlIRDBjNGVTMWMrV0JkbEth?= =?utf-8?B?TG5QK21BL2E5Nk5ZcGg0QnhpZ0hReXBYNVVKMk1zNEdoN3NkUkZNREZXY3V0?= =?utf-8?B?M0lHZ01IQnFiN2FuT0c5Smh2MW14UTM5ZVVHQ0UxVmZGUzFsNlBzN3NjeVl5?= =?utf-8?B?ZCtZMnNrNGxrV2hDZmM5WVBvUkpwaGdsQ2ZHQ25LRzE2T0lLeTlVWklZWS9q?= =?utf-8?B?MUFVdzl3V2pBM3BUczJkQ05ESFpxeVdXdll2bzMvUUlpbWlGcGpVU3NMZ3d0?= =?utf-8?B?MFdreExKck4zamFXKzYvamJsRDRWK0Q2Tm5taTN0U29kcUFpWkxxUjExZmpi?= =?utf-8?B?ektBQmg1N21hSi8wMisrMlZGaEZtMm1NQml4cGNTRGdvNXZBMTFKZ1cxVFhm?= =?utf-8?B?MnpxaWkvajlNUWtMekxTYTc0aDAxOVRyZE9WL1BZNnZWYXo4WFBJajg5Ykc1?= =?utf-8?B?RU9Xd3FsTUxlSUovRWU5c0xKNGpQOGFGcWx5TlNkZVBhajIwNDllK0pGaVNy?= =?utf-8?B?TGxXam1KNmwybXZOdUlhdEtibUtiOWl0K3dPVUFuOTROQlZRSTFWU2o5RFcz?= =?utf-8?B?ZkFGbGZwVjR3Sk92WVRpUVl2b3drVWFQWGl4Mm5HYmg2dm1McUR5RWdwSlNn?= =?utf-8?B?bHZveTh3eHdqUWprZndiZFFQR09rTFFYWWVjU1JkS1lBK0dScmVmbmwxMUFt?= =?utf-8?B?d29reWZNejRwTUhQd0hvL3k5UElkZHRtYUoxSXVnUDJnM1NpbEJYTThpYkZJ?= =?utf-8?B?bW9YeEFOUFJFRlhDbHA2ZFN0eGM4dDUxbFVHNE5Qa1hGMkJ3VVUrdEV2ZXJK?= =?utf-8?B?VGM5RC96RTJlR1dUOG8xSlpCZU9PUkFnSEJQQmcyaTNFdGJWL0RrcjhZU3RS?= =?utf-8?B?Qm1SeTJWblo3Y0dmR2hHZEk0T0pmZzV0bTdWd2dwNE5LT2NWZ3g4cmRhWUJh?= =?utf-8?B?Y0tnWHJ1cFlHVm9MN2F6V2xFa2R5WGhYRnBXMDJSWjA5RG9paENiOXE0eFNs?= =?utf-8?B?RVZ6cVJFTlZkZ0tjdE1wZnlVK3BmVmd1L1lVOWpCTFMrMTQ4bVRkUUJjL2pj?= =?utf-8?B?VTZlRHlBU3VOcFJQRFZUbGQvN3NMb0RMdUtVeWk3eUtSalY5Q1JrZlVnRVhu?= =?utf-8?Q?zN9k3grLTGLeq0zbKRFRpKVxFEuuOw=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5SPR00MB235; 6:uxvpsanJzen60gSrMVnUsTrUo9OOScVn9wzD1aqwG1xZoVdgidiCwCdFx8HXFIG69aIpD01CGwtn/n40riyPRpppFgt6PdZmJkeZ2OYDEb3yPrc5du+vLTM8awq6138Typ5rUcsPpd0RwxHqAyzqAOJoc1quFZ9SXGqfSBsFg5xDJiLzLCH4AYSueqnTF9XJL+Ob7u734isVfbTaE9nJQsaAC2oCAIyAvUd1n38b4ENcd/RBJwKjcu1RSN4UkHN/UOpkXnuZUAA4qzsTTcS6IUXXQ9Ie2IMRZXa9Y+wr1gcBKySHcuzzSK+ehqVU6gu/yw3VjEx1h6wLn87CiIrj3Q==; 5:rdUXWvt8cn6eEfFrBhH6HU1ao0mm+4rdsL6PK6zo3e7FnPp1FNhdslU/mHqUtLFV/cP6DpIbG4jKAF6IzsxQeLu0AQbr66CtnkfUvBP5OhGnAQSVaJoB7UvyEhi1P1X6TpkQoA3THB+3pEKVaN+E7w==; 24:sPOHhdXE9r65/nA1XSrIZwAz6/CvxnHiAUGYQ/alhcXgrIVV6Xv/mOjBTN7W96qaTmNs1debQ8y3rYRFcmR+518K71nDPlByE7ByY6AortA=; 7:OVq1mu3s8dAGmx6BSTRmU/grkjwFuwD3tdmzEZV+cz63Fe1isdySAHLZggUVntQX+ACBta7NNuwWefXorSu2SntrudSm87oY9ROaa9KHpHBQu24qbZvm3F3jKlSnoJnK+8+Iaq9Th25a/ATkn051XRUuL9hueM73yIsXFRFqDhD8+z8RhCyHPCpkhCSLzB7gE+pQG2mrzFZqx78sKJT3td6uwzsUja7OqhmoD+Lf1Qg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2017 11:36:34.7988 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5SPR00MB235 Subject: Re: [dpdk-dev] [PATCH v4 13/41] bus/dpaa: add support for FMAN frame queue lookup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Sep 2017 11:36:37 -0000 On Monday 18 September 2017 08:21 PM, Ferruh Yigit wrote: > On 9/9/2017 12:21 PM, Shreyansh Jain wrote: >> Signed-off-by: Geoff Thorpe >> Signed-off-by: Roy Pledge >> Signed-off-by: Hemant Agrawal >> Signed-off-by: Shreyansh Jain > > <...> > >> >> +#if !defined(CONFIG_FSL_QMAN_FQ_LOOKUP) && defined(RTE_ARCH_ARM64) >> +#error "_ARM64 requires _FSL_QMAN_FQ_LOOKUP" >> +#endif > > This PMD enabled with new added config > "defconfig_arm64-armv8a-linuxapp-gcc", which is 64bits. So this means > CONFIG_FSL_QMAN_FQ_LOOKUP always defined for the bus. > > Does is make sense to keep above check, but for rest of the code assume > CONFIG_FSL_QMAN_FQ_LOOKUP always set and remove the #ifdefs, to simplify > the code? > > <...> > I have removed these lines in v5. They were indeed unnecessary. Thanks for highlighting.