From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF69A4545E; Fri, 14 Jun 2024 17:40:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C853A40B95; Fri, 14 Jun 2024 17:40:00 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2069.outbound.protection.outlook.com [40.107.92.69]) by mails.dpdk.org (Postfix) with ESMTP id 75D2B402D0; Fri, 14 Jun 2024 17:39:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C87jRdJ8exYPMOUYBoIwQpCAEzVXGoE47TFcu8BMs5XzKtye7Um57Im9RYEx+6QzUUYTXGa7XX1qzIdiG1j3eughHChKoG3jkOQaBGVr2hfU7oEtFsUHOWpxMK0X6pHwjksrpcN8yRiokwW+6GKqJBF6wbKxFm5OLOfKHmU0aPc5hHq8XgLT0tp/Liv74VxHZ5thdWnO7YDX8CH8bTExmEHjXu2+wiwzZTQUmY1MfpGT91mnqLxQXJF7N1VVch4RlXkyBX8lM3wrxpo+zYGYHBQmm2ah2nP/E4dYqs85AyJ90O1r1ZgFezGGITFGXBFucXdSoNUUb61QtCR9KlQPHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ag0rCUbhmcHyjlnzzaA1i8LRjsoceAlGQp2QZIWr0Zs=; b=L5zaRaOO0F0Kg1KbNRpInPLgw6Uk5CGQvmS/Hhbh35UrgocQ7Rb2BLVsPLQEiZGVyQobTlFWDhKHjI1OVIFWjPwUQpbjTAkCV0l4WLPWpFDDG7Ij3XjFt7pbjDU3hEocHv7z3exbAYjqZNrG8rix2bYc7XkiGLZAxHUO9PA2Z2ePALEf4XBpcCcpLfLkK+np/uxUebUq6FgRbacaX/4no3sWvwBr9Oo56W0u7m0j3oP0CfHU6eTUItwPJPMf0N4NdlNm4wZ6yHHF8v1uW7RdUNECT1ITNA92pO5MUIwD6MYFV300LCapG+o5t/MSzIItFrsh4ePvJEThXdY0bIFICA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ag0rCUbhmcHyjlnzzaA1i8LRjsoceAlGQp2QZIWr0Zs=; b=3sKKQ0eTpBKlUDJ38+hJuJeKJA9HvZSXD//QVtxvvXEeKgjspySEpOKX3AzgwHAPHcuAB87wsI7xnVwTC3PdpHCcd7iToi10VtBAQAKlyLtBkGLn6eBjy4qYc89HX2xGljstO0UpCc5AOAHOwvd+wjRTUs/VPOvI+mTsVsdSVTE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA1PR12MB9245.namprd12.prod.outlook.com (2603:10b6:806:3a7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.25; Fri, 14 Jun 2024 15:39:57 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7677.026; Fri, 14 Jun 2024 15:39:56 +0000 Message-ID: <dc7e5205-fe92-4601-bf39-034babb3fb95@amd.com> Date: Fri, 14 Jun 2024 16:39:49 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] app/testpmd: fix lcore ID restriction To: Stephen Hemminger <stephen@networkplumber.org> Cc: Sivaprasad Tummala <sivaprasad.tummala@amd.com>, david.marchand@redhat.com, aman.deep.singh@intel.com, yuying.zhang@intel.com, dev@dpdk.org, stable@dpdk.org References: <20240415194631.124343-1-sivaprasad.tummala@amd.com> <20240416095556.173787-1-sivaprasad.tummala@amd.com> <5de50671-73b8-432d-a1a2-ce6b3120e73d@amd.com> <5a0370e4-aa42-4bc4-a5a8-34c37b88b95f@amd.com> <20240613121330.71538e19@hermes.local> <3fad191a-1402-4bb2-9992-6e2f4a50d295@amd.com> <20240614082707.3a2becec@hermes.local> Content-Language: en-US From: Ferruh Yigit <ferruh.yigit@amd.com> Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240614082707.3a2becec@hermes.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DUZPR01CA0325.eurprd01.prod.exchangelabs.com (2603:10a6:10:4ba::22) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA1PR12MB9245:EE_ X-MS-Office365-Filtering-Correlation-Id: a825acf0-304d-4767-3264-08dc8c883e22 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|366013|376011|1800799021; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dE1pRlFjM0hBREp5YmFaUndRRWVVSjhxNHlVRUo4ZlZUNFlZUGYxTWNXY2tX?= =?utf-8?B?dExXcFM1aVdIS1hGdlNWSEFaZUtQTDBJN0lkUndla2NleXZUV2Naa3pSSEZh?= =?utf-8?B?QmVyOFlxRFJDM3pkMVZMVFRUWTc5L05SbG9ZSVhMRldDRzVHUEZqNzZxeWpl?= =?utf-8?B?anNHL2lSQ3VBbjBuSFhoTDBaL1prZW9jcjl0Y2hkVTJRaG9MdXZlLy9UaHFT?= =?utf-8?B?bGM1NEpyc3ZJUTJpMWxGditmQXAwZUE0Z0V6TGJCWXVJUnd2cWRQNTZrSjBi?= =?utf-8?B?UEZ5NDN3V2g1bk9sYm9CckV6NjhjcThDR1VXSWUzZW42Mm1CeHlscXZTdzI2?= =?utf-8?B?YnlpTDBmTjVYc2F5Q2NjdUt0RTl2bFJUMHhqNFgzUFFLYXpBUFNJcGpnNFB3?= =?utf-8?B?L0JObU1KZzByOEFXWVg0NnBGQ3U2ZWZDQmQyS3d5cnNOejNFa29ZQ3pWM2JD?= =?utf-8?B?MWt4TEZiNXZXU3ZEbkNMdEJHT0d2cEE5bzdoRFdzaWxTaDRoaUpHczdCWm85?= =?utf-8?B?YmlJSEI2OWlqUkxPL2FEUFREajdoSXNxQnRzOFd1cmpKa2NZSDRUczFBQ0g1?= =?utf-8?B?Z1F3TE1WQW5uek9qMERmS2ludG04QXpmQ2pyS3JCLzBscDEwdGdCTkFid2pz?= =?utf-8?B?WFpDOXZ4Kzdsb2lhdGZZd09ZU2hlSitmKzM5QTJTQ1NEZFc4a1J1bTdGMUll?= =?utf-8?B?ZXp4dy85bEdZQmcvdld6Nks0ODB2UnIxSFNTZitEUk1ZME91NDRLUkF0aFRF?= =?utf-8?B?TWVRTTg3SzdKTXZ4ZVBqMWZVRFR4Qkp3d0FNazVjWGt0cG1iL1ZqMEhqS2V0?= =?utf-8?B?ajI2b1lzbVpBKzZSYnhJSTlDVUxDZUpYd2w5UFhxcDFoaC8ySTh2b1hFQ2tK?= =?utf-8?B?MEZhZk5FT2tXUTUvT0xlcGZCUk5HaHRoWGJHRTdtdStYdjE5YUxSVHZtcFNj?= =?utf-8?B?amlmRy9mc0FVVGg0TlFLSWs3RmRVQlZ2QkFrRGRQUnFKSHN3UFVyTnZDd3dW?= =?utf-8?B?anNzQWxTUW5vQXVtVm0vdzQxQ1NhTlJPZmp4QTBMc2F5YWZ1bkg0QXl2enNi?= =?utf-8?B?VXQ4dWRFWFkxaHNVeUhOc1FTblIzWlNaYk00U2FqNjJXSzRyT09vZDhiVmIv?= =?utf-8?B?Z3IzOWdhdTlReTkxamErV1R3UnNnQWVjeTBwRSt6dEkrNkliMyt3aVlGQVdG?= =?utf-8?B?UEVEdVluaDVEWG84RGJuV3R1dHVlUHpSOVh1aVk5bkxhY2JoazRDSXdYVDA4?= =?utf-8?B?VE9ZYmM1WXI1ZGV1MDBoVi95bnlhcnpWY0hLV1M3OG81eVprc3d1ODhaaE1Z?= =?utf-8?B?NWdTM3c2RkE4VjdadkpEbndlZGJpWkhYa1ZoRml3RzZ1OUw1ZURMQ1lvTDFG?= =?utf-8?B?UUcrdnRLNVhIS2VBeFFBaE5yVkx6UlZSMmlDTmhoWnd6QkUxQW1WRVRaNVg2?= =?utf-8?B?dnJlRWR5VHVONXNNWEJhTGlmMWoxZ01sdXgvYTZjVHV6ekU2MjlWTlhWYWVh?= =?utf-8?B?bVZvMWthbjN1bUNCbUN4QUJMRnpWRTUwY21uNkMrWUpQUnhzdVFpenJqZEx6?= =?utf-8?B?YWJPVld1TndUYXlLUUliWmo2eVpxbnF0N1A1aEtWZ1lTaE93MTJ3ZE4yRjN4?= =?utf-8?B?L0tvUitjQXVGTjJQNUt2S21YMEZXQW5Lb3YrbStSNDZwWTlmMjJuZWdIZDZa?= =?utf-8?B?UXRCODhZbCtSMldNWnY0Tm4rQWV4WU9uVk9TK09YbGNTenBCM0p2TGEzYXFi?= =?utf-8?Q?lqy+KtOqflMS8cIbRgBWxPdeBka6IgARIwTSuvD?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230037)(366013)(376011)(1800799021); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ym4xdGhYUFMyUy9pV3lnMFdQNWVKZDlXSFUrUUlsLzc0TWFiK0M1R3ZDTDFp?= =?utf-8?B?Vk1KdUhGN3g1L1RORXpJOUdlL1hFL2Fwemh1NUFHWTEzc3lzbVFNeEJQUGJJ?= =?utf-8?B?TUNUZ1pCMm1sSFFLaXY2R3Zob1ErQjQ4NlM5Rk1jekVZL3JLaUJLWDdJN2RQ?= =?utf-8?B?eXg5SHZGbnY0dDNSZTdvK1dKTnN2YWVJTHo5RE5JcjB5OUxHVHAvZEN0WnVp?= =?utf-8?B?b2lZaUIycDhsOTRBUXZrc2xRT0pndk4zWi9ZcmtHMG1aYld3OVc4NGJWY0RO?= =?utf-8?B?cGIyd1BmWW9UYWp2Tmw1T05HTVRPaDg2cEIwTVRkdDA2WXNZVmpRaHdRTHVp?= =?utf-8?B?QjQ3VE4yRXVyWjE1TTZVY1N1OWRhV0VjdEZjVk1zVXJlREszRW55WWN2S2tL?= =?utf-8?B?R1M0Y2ZLZUJBNEE0Y1ZDelhsZ0NtYm4wV1M0L1pUbHZ6bS83UU1ERGxBdkl6?= =?utf-8?B?Zm9LOGxEdUdVaHlKZERMWmF5L1ZqZEdsNU82QXp5N2ZOYTVJYzRqSm01OUR0?= =?utf-8?B?REV1U1Z3d21iTDA0WHo0UHFTRW8wamUvTTlPdjVzcDZzZzZuWUp3SkVrUS9t?= =?utf-8?B?MUVCSjdsSFZkZHFvZzR3dEJpcWNCQTFXUmlnelJYeCt6T29vRzdjemZvOTZy?= =?utf-8?B?bTdlUmRzdGVYQ2J2bE1rSXVIUm1XeU40OUpPV1BSSm1HQ2lDMzhIeExlR0w4?= =?utf-8?B?K1hiZnBRbXp3a0NtTHd4a2tpTGpzV3l5cnYvMTZEMEwyUTUzcWMxZFZMM01T?= =?utf-8?B?U2ZXVkM4aWxNUkxHVllCSVh6R2sveVNCWVBwdDZ3S0Z0aiszTncyQkJBWFhm?= =?utf-8?B?TVJVL3RvRHQ2TEVhVk5hRGc3NW5Eb082R0RZSDVNUTU5eEN3enVxeUNXK05s?= =?utf-8?B?MW1DOXdmVGJNQUkrVmNYMndWWEYyTlNyY3Vsc040YnluR2R2YThzS2VTZEs3?= =?utf-8?B?WlEvcnA2NnBGYXZoeWdhbzRuVGUxbmpMaUhhK25KaDUrWGpkM2kvL2RRd3U2?= =?utf-8?B?b3NXelBHRExtbzJyb2tZUkRWak9CMVlxZGZjZjd3SExxZSs0dnhPWXUwb0FZ?= =?utf-8?B?MDgrYlAzRk5mZEN6TEpXanJGeXRqWlRoek16dURUcC9CK1FMVjJlVW05Z0tV?= =?utf-8?B?SWxaZVI5ay9zTzdkejJiTGFXNGZBQU9ueWRiMi9DbDlSOGFTNTJkVVBKSjhN?= =?utf-8?B?d25IeW9yTkRXYUdKU1lQOXgwZkhLTnovaHZycHBiU2JZS29LTmE3TEJMRTBo?= =?utf-8?B?NHhNR1pKb3gyRGZNU2F2MGZrTDBFUGI3MFdoYUJKMUNoUnBiMml0cnNOOVd0?= =?utf-8?B?SmtaaGNEallCaENuTytpOFdxemUzNnB3WU5kMzR1eFZCUm55Vlk3SGdQdTdz?= =?utf-8?B?YTFLUjN4MzZ2QWtnNjRXR2VmVEVVYTRpMTNVT1FObEl6dTNaczlRUEdXRVha?= =?utf-8?B?Yy80T1lJelprb1N1NmgyRHJaUDYxN2pmUUFOU0ZKbTFreWkxRlRmd1pHRSs2?= =?utf-8?B?VlJkZUh2UThBbnFYWjB6QmM5VjBIblRQM0FRbGMrTkdTa0ZqK2NQOGp1SHZq?= =?utf-8?B?bm9qTUdJVWtiMk5LTkU0YURHMEdWcjBhVE54YmpZUnZSa2t5bkI5VDRsYklK?= =?utf-8?B?V0dyNzhqUCtrdXZNVThZS1dibFA0NWlJWW1BSWN5OFFlYjMzMlA4TXVWRFda?= =?utf-8?B?MnhaQ09HeWh0dlVjQkIxYmxtMkhYb2xRSFdLTnBVditLWkl6d0F6NTFNNWl6?= =?utf-8?B?aTdKVXNRbjIwTlNBR1JzL1NjK3p1aTdscmhjQ2NyYTh4MlhLYm9UcTRGRnNT?= =?utf-8?B?SnBmNXRxOURYL3B6Y2RERjZmQVBKZUMyZ3RhR1lSQnlxRWhKTTZvYklyOExn?= =?utf-8?B?MHZYVk1peEx6dFFHQ3R0eUQvWEVUMlM0NytPUHl3MUQvSjVGME1kU0ZlNjgz?= =?utf-8?B?NmtjYjVkTWplZFJVdlkrdXVqV0tWUCs1cUs5dCtCNlRHUHZncFhqaWdKREpJ?= =?utf-8?B?cGhkamZGYy83TjFQS0xUYkdJSG5ua3E4N2hLaUhPdHRTT3JTTmNtKzRRMlpD?= =?utf-8?B?UVVFRXF3T09oTm96TUloRXZTaUVMamZaY1dXY0VMeG5VVVNxc04rcldlVjhG?= =?utf-8?Q?aiKAbIwaP6XdCGBFj5U4mtRP5?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: a825acf0-304d-4767-3264-08dc8c883e22 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2024 15:39:56.7730 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PE1012A7r+/55PaGlj1ApCFjHVGPF7fUNyvFlFu7Qy82Lu1tkLqYJG58hMnyeWnM X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB9245 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 6/14/2024 4:27 PM, Stephen Hemminger wrote: > On Fri, 14 Jun 2024 10:01:02 +0100 > Ferruh Yigit <ferruh.yigit@amd.com> wrote: > >> On 6/13/2024 8:13 PM, Stephen Hemminger wrote: >>> On Thu, 13 Jun 2024 17:51:14 +0100 >>> Ferruh Yigit <ferruh.yigit@amd.com> wrote: >>> >>>>> Hi Sivaprasad, >>>>> >>>>> Is this '(lcoreid_t)' cast required? Because of integer promotion I >>>>> think result will be correct without casting. >>>>> >>>>> (And without integer promotion considered, casting needs to be done on >>>>> one of the variables, not to the result, because result may be already >>>>> cast down I think. Anyway this is not required for this case since >>>>> variables are u16.) >>>>> >>>> >>>> Why casing required (for record) is, >>>> 'nb_txq' -> uint16_t, promoted to 'int' >>>> 'nb_fwd_ports' -> uint16_t, promoted to 'int' >>>> (nb_txq * nb_fwd_ports) -> result 'int' >>>> nb_fwd_lcores -> 'uint32_t' >>>> >>>> comparison between 'int' & 'uint32_t' gives warning. After some compiler >>>> version it is smart enough to not give a warning, but casting is >>>> required for old compilers. >>>> >>>> And back to my comment above, casting one of the parameter to >>>> 'lcoreid_t' also works, as it forcing promotion to 'unsigned int' >>>> instead. But logically casting looks odd, so keeping casting result. >>> >>> Where is the integer promotion happening? >>> >> >> Raslan reported following compile error, this version of the patch has >> the cast, but merged version, v3, doesn't. >> >> >> ``` >> ../../root/dpdk/app/test-pmd/config.c: In function 'icmp_echo_config_setup': >> ../../root/dpdk/app/test-pmd/config.c:5159:30: error: comparison between >> signed and unsigned integer expressions [-Werror=sign-compare] >> if ((nb_txq * nb_fwd_ports) < nb_fwd_lcores) > > That does look like a compiler bug. uint16 multiplied by uint16 should be uint16. > Probably, this warning goes away with newer version of compiler. > Not sure why DPDK keeps using small types like uint16 so much, doesn't have any > real benefit since all this is in registers. ^