From: Ranjit Menon <ranjit.menon@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: talshn@mellanox.com, dev@dpdk.org, pallavi.kadam@intel.com,
david.marchand@redhat.com, grive@u256.net
Subject: Re: [dpdk-dev] [PATCH 1/7] eal: move OS common functions to single file
Date: Thu, 23 Apr 2020 09:31:54 -0700 [thread overview]
Message-ID: <dcee9d23-312a-9005-ec75-a1f02375aae2@intel.com> (raw)
In-Reply-To: <3727963.e99z0qppnp@thomas>
On 4/23/2020 3:48 AM, Thomas Monjalon wrote:
> 23/04/2020 11:06, Dmitry Kozlyuk:
>> On 2020-04-23 09:27 GMT+0200 Thomas Monjalon wrote:
>>> 23/04/2020 01:51, Ranjit Menon:
>>>> On 4/22/2020 12:27 AM, talshn@mellanox.com wrote:
>>>>> From: Tal Shnaiderman <talshn@mellanox.com>
>>>>>
>>>>> Move common functions between Unix and Windows to eal_config.c.
>>>>
>>>> Like other files in common, we should call this eal_common_config.c
>>>
>>> I am not sure about the interest of repeating the directory name
>>> in the file name in general.
>>> Do you see a real benefit?
In general, no. But in this case, it does make a difference, IMO.
When seeing all the files in EAL together, it clearly stands out that
these are common/shared files and any change therein will affect others
beyond Windows. IMO, I prefer it the way it is.
>>
>> It allows using VPATH in Makefile. If filenames are identical in different
>> VPATH directories, make can't pick both. Makefiles are being deprecated, but
>> they'll be around for some more time.
>
> Makefile will be removed in 20.11
>
>
ranjit m.
next prev parent reply other threads:[~2020-04-23 16:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 7:27 [dpdk-dev] [PATCH 0/7] Windows bus/pci support talshn
2020-04-22 7:27 ` [dpdk-dev] [PATCH 1/7] eal: move OS common functions to single file talshn
2020-04-22 23:51 ` Ranjit Menon
2020-04-23 7:27 ` Thomas Monjalon
2020-04-23 9:06 ` Dmitry Kozlyuk
2020-04-23 10:48 ` Thomas Monjalon
2020-04-23 16:31 ` Ranjit Menon [this message]
2020-04-22 7:27 ` [dpdk-dev] [PATCH 2/7] pci: build on Windows talshn
2020-04-22 7:27 ` [dpdk-dev] [PATCH 3/7] eal: add function finding integer in a string talshn
2020-04-22 7:27 ` [dpdk-dev] [PATCH 4/7] drivers: ignore pmdinfogen generation for Windows talshn
2020-04-22 7:27 ` [dpdk-dev] [PATCH 5/7] drivers: fix incorrect meson import folder " talshn
2020-04-22 7:27 ` [dpdk-dev] [PATCH 6/7] bus/pci: introduce Windows support with stubs talshn
2020-04-22 7:27 ` [dpdk-dev] [PATCH 7/7] bus/pci: support Windows with bifurcated drivers talshn
2020-04-27 22:58 ` Narcisa Ana Maria Vasile
2020-04-28 8:11 ` Tal Shnaiderman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dcee9d23-312a-9005-ec75-a1f02375aae2@intel.com \
--to=ranjit.menon@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=grive@u256.net \
--cc=pallavi.kadam@intel.com \
--cc=talshn@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).