From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id CD494214A for ; Tue, 3 Jan 2017 15:49:14 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP; 03 Jan 2017 06:49:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,455,1477983600"; d="scan'208";a="918457389" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by orsmga003.jf.intel.com with ESMTP; 03 Jan 2017 06:49:12 -0800 To: "Yang, Qiming" References: <1481008582-69416-1-git-send-email-qiming.yang@intel.com> <20053497.vNKJpYf1IB@xps13> <10603884.vrshqR2O82@xps13> Cc: "dev@dpdk.org" , "Horton, Remy" , Thomas Monjalon From: Ferruh Yigit Message-ID: Date: Tue, 3 Jan 2017 14:49:11 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 1/4] ethdev: add firmware information get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jan 2017 14:49:15 -0000 On 1/3/2017 9:05 AM, Yang, Qiming wrote: > Hi, Ferruh > Please see the question below. In my opinion, etrack_id is just a name used to define the ID of one NIC. > In kernel version ethtool, it will print this ID in the line of firmware verison. > I know what is etrack_id mean, but I really don't know why this named etrack_id. Hi Qiming, I suggested the API based on fields you already used in your patch. So, this API is to get FW version, is etrack_id something that defines (part of) firmware version? Thanks, ferruh > Can you explain this question? > > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Tuesday, January 3, 2017 4:40 PM > To: Yang, Qiming > Subject: Re: [PATCH v3 1/4] ethdev: add firmware information get > > Please reply below the question and on the mailing list. > You'll have to explain why this name etrack_id. > > 2017-01-03 03:28, Yang, Qiming: >> Hi, Thomas >> etrack_id is not a terminology, it's decided by me. >> Which is store the unique number of the firmware. >> firmware-version: 5.04 0x800024ca >> 800024ca is the etrack_id of this NIC. >> >> -----Original Message----- >> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] >> Sent: Monday, January 2, 2017 11:39 PM >> To: Yang, Qiming >> Cc: dev@dpdk.org; Horton, Remy ; Yigit, Ferruh >> Subject: Re: [PATCH v3 1/4] ethdev: add firmware information get >> >> 2016-12-27 20:30, Qiming Yang: >>> /** >>> + * Retrieve the firmware version of a device. >>> + * >>> + * @param port_id >>> + * The port identifier of the device. >>> + * @param fw_major >>> + * A array pointer to store the major firmware version of a device. >>> + * @param fw_minor >>> + * A array pointer to store the minor firmware version of a device. >>> + * @param fw_patch >>> + * A array pointer to store the firmware patch number of a device. >>> + * @param etrack_id >>> + * A array pointer to store the nvm version of a device. >>> + */ >>> +void rte_eth_dev_fw_info_get(uint8_t port_id, uint32_t *fw_major, >>> + uint32_t *fw_minor, uint32_t *fw_patch, uint32_t *etrack_id); >> >> I have a reserve about the naming etrack_id. >> Please could you point to a document explaining this ID? >> Is it known outside of Intel? > >