From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7E113A0550;
	Wed, 25 May 2022 14:01:30 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 22BCE40146;
	Wed, 25 May 2022 14:01:30 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 32EAC400EF
 for <dev@dpdk.org>; Wed, 25 May 2022 14:01:29 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id C98EC8A;
 Wed, 25 May 2022 15:01:28 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru C98EC8A
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1653480088;
 bh=pR1kDwXv7TXQXTyQ51gUD6tTX8hjZTPKlRlhns9X6Pg=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=sZDqhBNe+ke0YhRwAwmJ8bsgEV3reJNTDbecVwieutKQ8N2qmPw9qfiyemlK1rrpq
 dj5Jox0FOEIz6k+uruzd2ZdMqOAjIWd7UaPASCb82S9OLaYqTh8Bpq233uIfih5X7F
 h8ZvPken47s2dhh+W0tK7prHqbTYTuVnacyWgwbI=
Message-ID: <dd456798-9338-9b45-1ce5-e3f5a304a268@oktetlabs.ru>
Date: Wed, 25 May 2022 15:01:28 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v8 5/5] ethdev: format module EEPROM for SFF-8636
Content-Language: en-US
To: Robin Zhang <robinx.zhang@intel.com>, dev@dpdk.org
Cc: thomas@monjalon.net, kevinx.liu@intel.com
References: <20220524062442.194809-1-robinx.zhang@intel.com>
 <20220525031446.72578-1-robinx.zhang@intel.com>
 <20220525031446.72578-6-robinx.zhang@intel.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20220525031446.72578-6-robinx.zhang@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 5/25/22 06:14, Robin Zhang wrote:
> This patch implements format module EEPROM information for
> SFF-8636 Rev 2.7
> 
> Signed-off-by: Robin Zhang <robinx.zhang@intel.com>

[snip]

> diff --git a/lib/ethdev/sff_8636.c b/lib/ethdev/sff_8636.c
> new file mode 100644
> index 0000000000..ad625fc73b
> --- /dev/null
> +++ b/lib/ethdev/sff_8636.c
> @@ -0,0 +1,750 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2022 Intel Corporation
> + *
> + * Implements SFF-8636 based QSFP+/QSFP28 Diagnostics Memory map.
> + *
> + */
> +
> +#include <stdio.h>
> +#include <math.h>
> +#include <rte_mbuf.h>
> +#include <rte_ethdev.h>
> +#include <rte_flow.h>
> +#include "sff_common.h"
> +#include "sff_8636.h"
> +#include "ethdev_sff_telemetry.h"

Please, fix includes

> +/* Flat Memory:0- Paging, 1- Page 0 only */
> +#define	SFF_8636_STATUS_PAGE_3_PRESENT		(1 << 2)

RTE_BIT32 here and in many cases below?