From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id C680DE5D for ; Mon, 11 Sep 2017 19:56:55 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2017 10:56:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,379,1500966000"; d="scan'208";a="899200388" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by FMSMGA003.fm.intel.com with ESMTP; 11 Sep 2017 10:56:42 -0700 To: Markus Theil , dev@dpdk.org Cc: stephen@networkplumber.org, nicolas.dichtel@6wind.com References: <1503336825-7700-1-git-send-email-markus.theil@tu-ilmenau.de> <1504613046-7259-1-git-send-email-markus.theil@tu-ilmenau.de> <1504613046-7259-3-git-send-email-markus.theil@tu-ilmenau.de> From: Ferruh Yigit Message-ID: Date: Mon, 11 Sep 2017 18:56:39 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1504613046-7259-3-git-send-email-markus.theil@tu-ilmenau.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v7 3/6] igb_uio: fix MSI-X IRQ assignment with new IRQ function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Sep 2017 17:56:56 -0000 On 9/5/2017 1:04 PM, Markus Theil wrote: > The patch which introduced the usage of pci_alloc_irq_vectors > came after the patch which switched to non-threaded ISR (f0d1896fa1), > but did not use non-threaded ISR, if pci_alloc_irq_vectors > is used. > > Fixes: 99bb58f3adc7 ("igb_uio: switch to new irq function for > MSI-X") > Cc: nicolas.dichtel@6wind.com > > Signed-off-by: Markus Theil > --- > lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > index 93bb71d..6885e72 100644 > --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > @@ -331,6 +331,7 @@ igbuio_pci_enable_interrupts(struct rte_uio_pci_dev *udev) > #else > if (pci_alloc_irq_vectors(udev->pdev, 1, 1, PCI_IRQ_MSIX) == 1) { > dev_dbg(&udev->pdev->dev, "using MSI-X"); > + udev->info.irq_flags = IRQF_NO_THREAD; IRQF_NO_THREAD seems has been introduced in 2.6.39, so using this flag causing build error for kernel versions < 2.6.39. btw, the flag is already in use, so issue is not related to this patch. In DPDK documentation supported Linux kernel version is >= 2.6.34 [1]. We should either increase supported version to 2.6.39, or update igb_uio code. I am for increasing minimum supported kernel version to 2.6.39, any objection / comment? 2.6.39 released on May 2011 2.6.34 released on May 2010 [1] http://dpdk.org/doc/guides/linux_gsg/sys_reqs.html#system-software > udev->info.irq = pci_irq_vector(udev->pdev, 0); > udev->mode = RTE_INTR_MODE_MSIX; > break; >