From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: alvinx.zhang@intel.com, david.marchand@redhat.com,
arybchenko@solarflare.com
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix mapping of PCI resources
Date: Mon, 28 Sep 2020 10:10:52 +0100 [thread overview]
Message-ID: <dd585762-d74d-5759-be51-669715df8ea7@intel.com> (raw)
In-Reply-To: <20200928063429.14148-1-alvinx.zhang@intel.com>
On 28-Sep-20 7:34 AM, alvinx.zhang@intel.com wrote:
> From: Alvin Zhang <alvinx.zhang@intel.com>
>
> When mapping PCI bar resources around the MSI-X table, if the size
> of the first part is 0, the second part should also be mapped if
> its size is not 0.
>
> Fixes: e200535c1ca3 ("mem: drop mapping API workaround")
> Cc: stable@dpdk.org
>
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> ---
> drivers/bus/pci/linux/pci_vfio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/pci/linux/pci_vfio.c b/drivers/bus/pci/linux/pci_vfio.c
> index 34b5da8..37bfda8 100644
> --- a/drivers/bus/pci/linux/pci_vfio.c
> +++ b/drivers/bus/pci/linux/pci_vfio.c
> @@ -565,7 +565,7 @@
> }
>
> /* if there's a second part, try to map it */
> - if (map_addr != NULL
> + if ((map_addr != NULL || memreg[0].size == 0)
> && memreg[1].offset && memreg[1].size) {
> void *second_addr = RTE_PTR_ADD(bar_addr,
> (uintptr_t)(memreg[1].offset -
>
Dupe of http://patches.dpdk.org/patch/78768/ ?
--
Thanks,
Anatoly
next prev parent reply other threads:[~2020-09-28 9:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 6:34 alvinx.zhang
2020-09-28 9:10 ` Burakov, Anatoly [this message]
2020-09-28 9:43 ` David Marchand
2020-09-28 9:55 ` Ling, WeiX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd585762-d74d-5759-be51-669715df8ea7@intel.com \
--to=anatoly.burakov@intel.com \
--cc=alvinx.zhang@intel.com \
--cc=arybchenko@solarflare.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).