From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 635D042A59; Thu, 4 May 2023 09:47:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 54B0142BDA; Thu, 4 May 2023 09:47:44 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id E92CC40141 for ; Thu, 4 May 2023 09:47:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Au4B/xb9jSOdC5gH7MDHQXakcByEC3TJloHhYv2LKaxC2x6oyJAf20K700J9/08x65nSaieF8LOgNB96j6xhZaGz124BIzukSbnN1AexFen9rh6fg9PrK8tSqKCS+V6dPvRgKgOqld2bqYUxvRnm7pMAxDIWwrh4ntPyvMw+xB+LDhvFbcvKvSTII419K8rYtmEowu+RilzdUUaNTllRKS+rDAo/QZDmU0rsky6i1HbaXIDkJyL+B+SVxONtwdm1rwaXyWq4NEvsTnYC9ZByiYgs6S0mM6TrnyxATQIPFs9cdSvppfh0dmnOO+gdoG4MdW2ZOwH3QgcQ4ORjn+Nbgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wa1Y0SdZNQzgGUZgdlCDa1svJXglnkQMQlt/gj3gRdg=; b=eqJAsed/UHKjG/q1Ap1QLI59+Upy6/jq8Y/3K7zA4vurcUNv0fC+bHAf5jlN3LtDzQLMakWB4plio4oqslgnXTrjAxAGN6ow7WVwzEWkgVovwkapVgKpWP6DgbyclzLz4h3cifYPtHKRgS6IQZzO6K+2xFwuhT1Y9PYZ27G+hay4OMutJgEybDYluhmiAeryme2kIx8hUQ+Yvdy+urRsL2lGZsAcxZ7CCU0zujS0YMZIpWdlkoPDKFB3QycH85rRguusNCkS9netxxrrte1Tk3mNZA7Jd/mKUhHbdfPVGqMF/UGjyBJxVDu1eImru5p8rfcIBo38FTUsDDdJ+p6Fmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wa1Y0SdZNQzgGUZgdlCDa1svJXglnkQMQlt/gj3gRdg=; b=N0MNIXR4rutxMkHkKxoHgf+XDtv5AbLDSoYybQdkFoLMA1T4s16LHBXLEwsvr4bEu2ZfAKXwCVpk7BhhyydOwKASE6/Bzk+sx0jG1o3tLufG9a2HOYdRr6+Ne7FLxZ+nWCA7luX4rMS4y6CrtOw66rmK9TQCNaV4LSAI/4HiWAo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by BL1PR12MB5875.namprd12.prod.outlook.com (2603:10b6:208:397::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.26; Thu, 4 May 2023 07:47:40 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::e818:77ea:75b5:f8cc]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::e818:77ea:75b5:f8cc%5]) with mapi id 15.20.6363.022; Thu, 4 May 2023 07:47:40 +0000 Message-ID: Date: Thu, 4 May 2023 08:47:33 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [RFC PATCH 3/3] ethdev: rename parameter in API to get FEC To: Denis Pryazhennikov , dev@dpdk.org Cc: Ivan Malov , Viacheslav Galaktionov , Thomas Monjalon , Andrew Rybchenko References: <20230428102728.51956-1-denis.pryazhennikov@arknetworks.am> <20230428102728.51956-4-denis.pryazhennikov@arknetworks.am> <8b00ea5e-cb12-0f21-61a4-26961dc86ff8@arknetworks.am> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <8b00ea5e-cb12-0f21-61a4-26961dc86ff8@arknetworks.am> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0460.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::16) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|BL1PR12MB5875:EE_ X-MS-Office365-Filtering-Correlation-Id: 52ee6f93-6697-4e19-8c88-08db4c73d5ed X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MiZg7V7RQYIvTLM+9UMtsi+oFV9Gds2SJtaM3Y2wnlLr6tpf6cJ2sJ9D4aZwteVl8r0VOjh65AVz2L4k2FwD5cgdnI/UFvQN/FR6errog0mZLnDUrkPmIoBBo3t1RpK4aqYNDs4vzpvnQeR8TmKsLaPoTEq4LB1gVt8pOJKREnj2x4s9Or32SOS80TJSXgkFJSKFyrtNZThG2w26UTKgK3G/EjfG89i+hBvCxGCMg3b0hww3dRCUie8Q7zwDfx5x1z7jQvQbbQiYAueLmQEf6BjSvheS0s51wQ5j+iSDZyg6VM0H1RGpQRW7RQCE45lDwo0NJci7g1jKnWoZl73x4V3XbcuCCXkCAFYkiGp9q+q05DXN1/kFTLoWdYPnl4yijImF4owgvZ+dHvbbbbKaYY+NONC09r86kav6qO7W+RKZARLfFwiJxxpZeXRUFLTWiTNW5VHW3tFw2MSXr6pDxI75yrw10jYiLtQcm/FA62xr2q07Nk1bRptXTsYZKRA5CWn+3lUPlyCVm/V2wbWryT17u+jLQ7qs+r6iV+W3FSWEID9gcGEPFcnzUndG3AgzZlbajff7G0Uj9vNnPs062L91thpQmHbx+SmyxzteoDz8HkX4nvMh9pp2W6Wc8vfF9z+m2P+xxloUAedWq4nEvg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(136003)(346002)(366004)(376002)(396003)(451199021)(2906002)(186003)(83380400001)(38100700002)(5660300002)(54906003)(8936002)(8676002)(966005)(31686004)(316002)(6506007)(6512007)(53546011)(26005)(86362001)(6666004)(4326008)(44832011)(36756003)(6486002)(2616005)(478600001)(31696002)(66946007)(66556008)(66476007)(41300700001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cTIwZmE3TlZYWmN3b3d0SzVrODRuSmt6SkpKVGlkOGxHU1g2WGxlS0QxM04y?= =?utf-8?B?MnpqZk1zbERnNWdsTi8yS3pEeTg4emdtc0R3bWdyeDEvYmxsalVVQzJHK1p1?= =?utf-8?B?Qmk1WHRSUlZVYjBmQmZ1WkNLeUcrVWFXQTdSdDhBMkRNSVpUdHZzZVZWb0Vr?= =?utf-8?B?RTM4QzgrcjR1RlVodGp3Q0RuNFRlMUNXWFdkMDcxaHAwbzh1Q28yd3h5QTJi?= =?utf-8?B?bjVqM1A4RjlLUFY2UE81WDB0a1d5ZG9jR0R6QVVYTTFlZlZ1OThuanRNeWdq?= =?utf-8?B?K1BIN0NMV0NhVTFneXJMOWNuQjBMdTdvdnpIVUtvSVhFbUNsaHI5RDM5Y244?= =?utf-8?B?ME9KWjFGcDVFOWExNG91OExvQVA1V2xjTEVidEd3SnJhSy9ZZUhHTkJsS2lh?= =?utf-8?B?Rm41MFN1Q1ZLRlpkSi9LeGxoWXZZRFBwSi9JcWdLUmZnUUF2d0xiRUwyeURx?= =?utf-8?B?S1phV1VEVWJLdnhjMUhLRXM1elQrQWRMMTRUN1Rxb2tUYWl2ZlIvUk9BUmtN?= =?utf-8?B?dWxCVzkwZFFQdytKVFFrWVRqeUh0aEhMSERGMEZ4RS90MlRjQnhvS1VjZXhy?= =?utf-8?B?OVhjbTJqVzlQTHdaNndZNHZUSjNVYXFocHNyNEp5aGFMMTQ0TzV3aHN3TGJV?= =?utf-8?B?ZkxzK29mK2RmVTMwTHpsdWhVRWcycEcwVWVqVERFVStGUktJeXRadUI2ZkxZ?= =?utf-8?B?L1owWWgxWDRQbzRKdjByQXg1N2JTYVE1ZmtJT0dESWoxOE1aWmNrcEJJTE9m?= =?utf-8?B?M21FZ2JmVWFmWDI5aTRaOXJBbDFjNU5zT3NuOGUxZWE2ejFrOWx5L0I4V1RV?= =?utf-8?B?b3U2a092Nk9rRlQwT05nYXFIcWN6bzBzMWpWWHVreEtpekRWVlhhQ0tId1NS?= =?utf-8?B?R1F3MUZnZktkVFl2VVhqMGlxRHJVMzdWelExSGdNOTltZHFqOXo4aWUrdVUz?= =?utf-8?B?Q0JWZHpRdnJ6YWozOUNVS1l5WHUxRHd5ZEw1UlBaVDdEbnYyUVpoNHpCWVk0?= =?utf-8?B?a0dEbFlMM2Vjc1NvRkZJaHl5aHp0eHI3SncvZ1hRUkdsa1lQMllFRFAyaUQz?= =?utf-8?B?SFg4RVhoT0hmaXhqdy90RXFIVzdDSStRQzZVbmVkMExEby9MREw4cmxvQ0ZZ?= =?utf-8?B?d0FwdUc3RlI1NUM4a0dkMUh2alFLcVozNHMvVDBtbjFtWTRaWGxSVTdLenYx?= =?utf-8?B?am56azNqd3FVbjdGMXB4a1hCOEV0cXQ5eFovbWVNYzlKZFFXSnNZM0N1N3FX?= =?utf-8?B?ekpDMDhEMy9rY3NTaDE4K2cxUFNrbUs5NXh6c2t6Y3VnZE1lRHRFRHpQdFFI?= =?utf-8?B?S0FmK2ZkOFpjTC82TDMrdSsyWUwvMW5qLzk4eG9tMWhjaCtNQ0lJbWtBb21Y?= =?utf-8?B?cEUrd3lKdDBtNG9ncm5hc0VCY0JmODJNVGprNWtqenVocDNrMGVlWUxVb3VF?= =?utf-8?B?andieFYrVE5CWXhxRm9DUkYzd2hsNnZHWWNpa2JqcytSWEF2TEl5MUVqNVRG?= =?utf-8?B?NTVsUmZneVllSGJ3OElEemVqRVgzZWlMMHdGeCs4blBVTDM3QmpnWEc5K3BM?= =?utf-8?B?alB6akhjVVg5YjFBZGs1bjhlVGF2ZlpZRVU3aGtMZFY0SGJaQmhOb0hKWDlB?= =?utf-8?B?dmVLTk1jeW11THdwZlA2Z1BEMVVaMVhxT09HbXpHNktWUzU2NXVNdi9UaUw3?= =?utf-8?B?SEc2aTJrN0VBenVsWk45ODdNclpLZkZ5NWE5bWN3eHVBbk9jcEx6eHVpcTg5?= =?utf-8?B?ZlQ3MTJjSUhPcVJPRTBWRmd0eW9qSHlodFZ5anFFMWZKbjBIb0pnQkwycFht?= =?utf-8?B?VnBtcVFQV0N6M2pqWk1va21nWDV1dHB4VUY1c1MwWEVPamJUN0djUERrazdJ?= =?utf-8?B?S0szcXVJWDR3d0xRRU5PYkZxVWV2WnVqNCtqK00rUDY2NmxtSmNybitqQjFP?= =?utf-8?B?SFh6SXVmSmEzU2JPalBKd1ZvYW9ZV1pGNSsyRktEQmx4N3VKUWROM1dzT25w?= =?utf-8?B?dTVRZWtRKzY2c1NqNDJlQWhWbkh1UHF0cmxRUFlyaXkzMVNIN0tMd21vaXhE?= =?utf-8?B?bWVpNmtpUmZuYk9YdkpvMSsxZHZQVFpqU2drWE9GQzhEcXc4dnJZa3NSdmpU?= =?utf-8?Q?7x4f2n1jfFtYJcAv00deNnk0v?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52ee6f93-6697-4e19-8c88-08db4c73d5ed X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2023 07:47:40.0261 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lCq2KNJcaqUf0sO0wAb/QHSC0OKY5umILdCuFiRtlGsiEDsN+wSGF1tvWPZp8dna X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5875 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/4/2023 8:13 AM, Denis Pryazhennikov wrote: > I think my patch isn't correct. > I would say that > - fec_capa is a set of bits produced by 'RTE_ETH_FEC_MODE_TO_CAPA()'; > - fec_mode is an element of 'enum rte_eth_fec_mode'. > > Based on this definition, replacing 'fec_capa' with 'fec_mode' should > involve changing the parameter type. > Probably I shouldn't change the name, but I should add a more detailed > comment. > >> Independent from being single FEC mode or not, I think both > 'rte_eth_fec_get()' & 'rte_eth_fec_set()' should get 'fec_mode' as > param, what do you think? > > Andrew Rybchenko asked to replace 'mode' with 'fec_capa' for > 'rte_eth_fec_set()' in > https://inbox.dpdk.org/dev/aa745bd1-a564-fa8c-c77b-2d99c97690aa@solarflare.com/ > I don't think we need to change it for rte_eth_fec_set(). > OK > On 5/2/23 7:02 PM, Ferruh Yigit wrote: >> On 4/28/2023 11:27 AM, Denis Pryazhennikov wrote: >>> Only one valid FEC mode can be get by rte_eth_fec_get(). >>> The previous name implied that more than one FEC mode >>> can be obtained. >> +1 and patch looks good. >> >> But isn't this valid for 'rte_eth_fec_set()', it gets 'fec_mode'. FEC >> capability has its own type "struct rte_eth_fec_capa". >> >> Independent from being single FEC mode or not, I think both >> 'rte_eth_fec_get()' & 'rte_eth_fec_set()' should get 'fec_mode' as >> param, what do you think? >> >>> Documentation was updated accordingly. >>> >>> Signed-off-by: Denis Pryazhennikov >>> Acked-by: Ivan Malov >>> Acked-by: Viacheslav Galaktionov >> <...> >>