From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93C97A09EF; Mon, 21 Dec 2020 10:07:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6F4B4CBDF; Mon, 21 Dec 2020 10:07:30 +0100 (CET) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by dpdk.org (Postfix) with ESMTP id C2CD0CBB4 for ; Mon, 21 Dec 2020 10:07:27 +0100 (CET) Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CztrM1LwSzhw9T for ; Mon, 21 Dec 2020 17:06:43 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.498.0; Mon, 21 Dec 2020 17:07:21 +0800 To: References: <1608504422-29220-1-git-send-email-rahul.lakkireddy@chelsio.com> From: "Min Hu (Connor)" Message-ID: Date: Mon, 21 Dec 2020 17:07:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <1608504422-29220-1-git-send-email-rahul.lakkireddy@chelsio.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix start index for showing FEC array X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" ÔÚ 2020/12/21 6:47, Rahul Lakkireddy дµÀ: > From: Karra Satwik > > Start from index 0 when going through the FEC array. This will allow > "off" to get printed for RTE_ETH_FEC_NOFEC mode. > > Fixes: b19da32e3151 ("app/testpmd: add FEC command") > Cc: stable@dpdk.org > > Signed-off-by: Karra Satwik > Signed-off-by: Rahul Lakkireddy > --- > app/test-pmd/config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 3f6c8642b..a6a5baa4e 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -3701,7 +3701,7 @@ show_fec_capability(unsigned int num, struct rte_eth_fec_capa *speed_fec_capa) > printf("%s : ", > rte_eth_link_speed_to_str(speed_fec_capa[i].speed)); > > - for (j = RTE_ETH_FEC_AUTO; j < RTE_DIM(fec_mode_name); j++) { > + for (j = 0; j < RTE_DIM(fec_mode_name); j++) { As RTE_ETH_FEC_NOFEC is mode which every device has, so we think it should not be regarged as "capabilities". Thanks. > if (RTE_ETH_FEC_MODE_TO_CAPA(j) & > speed_fec_capa[i].capa) > printf("%s ", fec_mode_name[j].name); >