From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27CE3A057B; Tue, 28 Jun 2022 15:17:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12D2240691; Tue, 28 Jun 2022 15:17:58 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2054.outbound.protection.outlook.com [40.107.220.54]) by mails.dpdk.org (Postfix) with ESMTP id 61679400D7 for ; Tue, 28 Jun 2022 15:17:56 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fBSfpsuvXtwADWICHbp84gGt26naRDuWkhEkeOGE/0KqypWq9f7T/ZllJ7ERSx6yOPFoEZ4jzex9WV2dN+71bSDEbXxNiyNp28C47BBzHtC1MQ4r9l0dCK7ZctJWFR3BBjxaWu8RPthXpFTB6H/HTuy5GJMUCXrdeqsY0o0f5tjt9/3yuMu6XRxrd4aR8OusoKOC63xcFkaRwlGhdmoowR75QQR5bQwMa5cd7Uib69tzplWA3BoHpX7O+SqeFJ7/Pq37Sj/WL7fDJePpQUTDse0K1ponAaj/J8iVOx6oC/ZE39WNvKctp8pNbFJepvSetKyoOqyn2Pai1EgYec7/Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sDTBopK3jFWHEv9pmolqFufSRrelVY5eIpBogZl9n2M=; b=ZiElJO16YpRRJVj6RY5WcZZNiCHhDn1HmHfzAxFTizE3nWWdG1TopMB35xlnJ2/wRkNJxhbwpRc0KvnRRYoWz65kEk8y9GbPQT2IWD/BfQFBECTO83ftZTW9f1luPW6cDC9Vtd/O9zX9JlnFIEzWi8/YVcDV8/VTnXBxJ3neqPXVZJtBAEMIDM+NJ146uHlgGBPnoPKrOGn1dy0QYOk10UU+4IbyJInzLUacnrkJXGlVXARBNNsemvQUd/4e61/nk/p640rkjLinmIBgn9zpJHHHT4U/ZOtfLYtkLI2o+i25s76Zi3/y9us6JZFZy5P9YEF7ksKbVZv7tBjoiKdpLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=huawei.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sDTBopK3jFWHEv9pmolqFufSRrelVY5eIpBogZl9n2M=; b=PwcamxmhL9Kjh3ZHcJejYKUx7FrVMFUIyuzDGoNYpgsbqlxG+6JwcEEHQZGZ7dI/OVgrd8/KARhvn7xIe2xIHOttGpiCActrG8vEA2u8Lm00C/KTIvT1kDWPqDP3ZYBstxssu+rgDV3vcIoL4W/P9EZ7zFQFDqO4EqSlgl+hCYM= Received: from BN9PR03CA0985.namprd03.prod.outlook.com (2603:10b6:408:109::30) by BYAPR02MB5829.namprd02.prod.outlook.com (2603:10b6:a03:11e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.17; Tue, 28 Jun 2022 13:17:53 +0000 Received: from BN1NAM02FT024.eop-nam02.prod.protection.outlook.com (2603:10b6:408:109:cafe::c4) by BN9PR03CA0985.outlook.office365.com (2603:10b6:408:109::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15 via Frontend Transport; Tue, 28 Jun 2022 13:17:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; pr=C Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by BN1NAM02FT024.mail.protection.outlook.com (10.13.2.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5373.15 via Frontend Transport; Tue, 28 Jun 2022 13:17:52 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 28 Jun 2022 14:17:50 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Tue, 28 Jun 2022 14:17:50 +0100 Envelope-to: lihuisong@huawei.com, aman.deep.singh@intel.com, yuying.zhang@intel.com, andrew.rybchenko@oktetlabs.ru, dev@dpdk.org, thomas@monjalon.net, huangdaode@huawei.com, liudongdong3@huawei.com Received: from [10.71.119.54] (port=50598) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1o6B6E-0000QR-QE; Tue, 28 Jun 2022 14:17:50 +0100 Message-ID: Date: Tue, 28 Jun 2022 14:17:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH V5 2/7] app/testpmd: unify the name of L2 payload offload Content-Language: en-US To: "lihuisong (C)" , , , CC: , , , References: <20220429102445.23711-1-lihuisong@huawei.com> <20220624072401.21839-1-lihuisong@huawei.com> <20220624072401.21839-3-lihuisong@huawei.com> <62028c08-cec3-74f4-f91d-423b8a415705@xilinx.com> <5884a54f-24cb-19ae-f48b-0e5df33e9336@huawei.com> From: Ferruh Yigit In-Reply-To: <5884a54f-24cb-19ae-f48b-0e5df33e9336@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 88769c22-e635-47a5-7ca4-08da59089b23 X-MS-TrafficTypeDiagnostic: BYAPR02MB5829:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FMHlY7kgDPhVnNa2FDzd3StcHEW+JcQdaHgpVIgapMVIqd/IdrBmbwI8IP1KPtF677UeFDfTFTjW1GOrMg2nZs/OlL0cmIwbHCSUVtBsh7GvhvEXIBcTr6JIZBErAnC/6VlKGtj6fgiUsX78coXRGfCF+ysyeKtpt0nC/XU3Bgd0RRB0XXpamHNZWn+atvKLntUze9//Ii2scYnyyGFUxhbR1NzJFp6VuNvk9RDvLOJaGZ9fj+E4cAGz/dnQ4jt463CaKuAh3Vy6sZmSzIVn1ifUFZTbuWEce2yqNRJFchmVw6P/dJZgTdWU2ki0mAwMFuEpWCR44kiwHHWHJFanPr1oe817VHj6o6Qvj+hLA54HhOLznkB0lCmI68VrrVrLiDA5GYn2okGkcJKnxSC9EjfL1TS7FiyyCcup3SEe1cCYaxyJ/x34sj54Urt2sNCJ292s7c9F3aPjuKhW9eTy78YxUFEOFGHagzHpFMKZRFlun8iZBntchdT7PMO30o2XHwlwCDsyH4dlvzjwifnGfxrGDaArCjN26szAkaKn8FgqvP9FxYuFg2F2IFERTMZUbbnji9RZyONw9cC7R0vq6q4OaO5goBWt7yaBH+KQ8n65kNWnp+QmQQaDkt/PNZ9TVFstWHWu8shHnPKkMuR/KlHU34bOvmSk6btlyQCfwH0O7XiFwd2LNmTMVkg77zI/pVlbfPT+VOC3G46M3IbjpWa6Rmy3rbqNDNQ9IbYkg70meN6gCkY4oNi8eRwzjy+pVuNvHZ8Q8bdGGQQN5Bh1JA9NId/SCRfGsRjozWx6znWU84l/PZ9JtrzTYJHdbw7lRCiQpjJ5sFW3QupkQ4aDsQns6V/syyM9TfUY2ipKp/U= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(396003)(346002)(376002)(136003)(36840700001)(40470700004)(46966006)(41300700001)(70586007)(8676002)(70206006)(82310400005)(478600001)(336012)(9786002)(26005)(31686004)(2616005)(4326008)(8936002)(40460700003)(36756003)(40480700001)(54906003)(31696002)(53546011)(47076005)(82740400003)(5660300002)(110136005)(36860700001)(316002)(426003)(7636003)(186003)(83380400001)(44832011)(356005)(2906002)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2022 13:17:52.2188 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88769c22-e635-47a5-7ca4-08da59089b23 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT024.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB5829 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/25/2022 3:12 AM, lihuisong (C) wrote: > > 在 2022/6/24 21:53, Ferruh Yigit 写道: >> On 6/24/2022 8:23 AM, Huisong Li wrote: >>> Currently, the "port config all rss xx" command uses 'ether' name to >>> match >>> and to set 'RTE_ETH_RSS_L2_PAYLOAD' offload. However, others RSS >>> command, >>> such as, "port config rss-hash-key" and "show port >>> rss-hash key", use 'l2-payload' to represent this offload. So this patch >>> unifies the name of 'RTE_ETH_RSS_L2_PAYLOAD' offload. >>> >>> Signed-off-by: Huisong Li >> >> ack >> >> But I wonder if we should continue to support 'ether' with an >> exception to not break the interface, at least for a while like to >> next LTS. > It's supposed to have a very small impact, and it is just an optional input > of this command in testpmd. What's more, patch 3/7 has to use > "l2-payload" to > match. This shouldn't affect the optimization progress of "port config > all rss xx" > command, right? Yes, impact is small, OK to rename. But can you please add a release note update to inform any possible user. A brief, one line update is good to say "testpmd RSS type 'ether' renamed to 'l2-payload'" >> >>> --- >>>   app/test-pmd/cmdline.c                      | 6 +++--- >>>   doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +- >>>   2 files changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c >>> index 9a7fd5fc35..a701bac953 100644 >>> --- a/app/test-pmd/cmdline.c >>> +++ b/app/test-pmd/cmdline.c >>> @@ -694,7 +694,7 @@ static void cmd_help_long_parsed(void >>> *parsed_result, >>>               "receive buffers available.\n\n" >>>                 "port config all rss (all|default|ip|tcp|udp|sctp|" >>> - >>> "ether|port|vxlan|geneve|nvgre|vxlan-gpe|ecpri|mpls|ipv4-chksum|l2tpv2|" >>> + >>> "l2-payload|port|vxlan|geneve|nvgre|vxlan-gpe|ecpri|mpls|ipv4-chksum|l2tpv2|" >>> >>> "none|level-default|level-outer|level-inner|)\n" >>>               "    Set the RSS mode.\n\n" >>>   @@ -2080,7 +2080,7 @@ cmd_config_rss_parsed(void *parsed_result, >>>           rss_conf.rss_hf = RTE_ETH_RSS_TCP; >>>       else if (!strcmp(res->value, "sctp")) >>>           rss_conf.rss_hf = RTE_ETH_RSS_SCTP; >>> -    else if (!strcmp(res->value, "ether")) >>> +    else if (!strcmp(res->value, "l2_payload")) >>>           rss_conf.rss_hf = RTE_ETH_RSS_L2_PAYLOAD; >>>       else if (!strcmp(res->value, "port")) >>>           rss_conf.rss_hf = RTE_ETH_RSS_PORT; >>> @@ -2203,7 +2203,7 @@ static cmdline_parse_inst_t cmd_config_rss = { >>>       .f = cmd_config_rss_parsed, >>>       .data = NULL, >>>       .help_str = "port config all rss " >>> - "all|default|eth|vlan|ip|tcp|udp|sctp|ether|port|vxlan|geneve|" >>> + "all|default|eth|vlan|ip|tcp|udp|sctp|l2-payload|port|vxlan|geneve|" >>> "nvgre|vxlan-gpe|l2tpv3|esp|ah|pfcp|ecpri|mpls|ipv4-chksum|l2tpv2|" >>> "none|level-default|level-outer|level-inner|", >>>       .tokens = { >>> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst >>> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst >>> index 0b7a53fdf1..cc299cff6c 100644 >>> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst >>> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst >>> @@ -2144,7 +2144,7 @@ port config - RSS >>>     Set the RSS (Receive Side Scaling) mode on or off:: >>>   -   testpmd> port config all rss >>> (all|default|eth|vlan|ip|tcp|udp|sctp|ether|port|vxlan|geneve|nvgre|vxlan-gpe|l2tpv3|esp|ah|pfcp|ecpri|mpls|l2tpv2|none) >>> >>> +   testpmd> port config all rss >>> (all|default|eth|vlan|ip|tcp|udp|sctp|l2-payload|port|vxlan|geneve|nvgre|vxlan-gpe|l2tpv3|esp|ah|pfcp|ecpri|mpls|l2tpv2|none) >>> >>>     RSS is on by default. >> >> .