From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CF50A04B7; Wed, 14 Oct 2020 11:57:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 789071DDC8; Wed, 14 Oct 2020 11:57:38 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id BEE251D679 for ; Wed, 14 Oct 2020 11:57:34 +0200 (CEST) IronPort-SDR: sjSZOOdpWxn84ljQVOlopC28oTqL80EOxRN4xixMlJ2U7tepRmsrbJ1vpxPWeuM3aw6Ng1yKgC zYEqBWFLqUNQ== X-IronPort-AV: E=McAfee;i="6000,8403,9773"; a="183589129" X-IronPort-AV: E=Sophos;i="5.77,374,1596524400"; d="scan'208,217";a="183589129" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 02:57:32 -0700 IronPort-SDR: IIJ1BG1KWnRYZINpj9g3le8xYoCLHYDenFJziXDNiA9f/l4lyRXJ+/vDZWIttO1+l69GSLvI/J YZ3bEl0ngmLg== X-IronPort-AV: E=Sophos;i="5.77,374,1596524400"; d="scan'208,217";a="314108326" Received: from rnicolau-mobl1.ger.corp.intel.com (HELO [10.251.83.231]) ([10.251.83.231]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2020 02:57:30 -0700 To: David Marchand , dev@dpdk.org Cc: Jerin Jacob , Ruifeng Wang , Jan Viktorin , Bruce Richardson , Konstantin Ananyev References: <20201014081430.31349-1-david.marchand@redhat.com> From: "Nicolau, Radu" Message-ID: Date: Wed, 14 Oct 2020 10:57:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20201014081430.31349-1-david.marchand@redhat.com> Content-Language: en-GB Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] eal: add experimental tags for write combining store X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/14/2020 9:14 AM, David Marchand wrote: > Only marking the doxygen declarations is not enough. > Arch specific implementations must be tagged as well since there is no > common declaration of those inlines. > > Fixes: 8a00dfc738fe ("eal: add write combining store") > > Signed-off-by: David Marchand > --- Reviewed-by: Radu Nicolau >