DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Kadam, Pallavi" <pallavi.kadam@intel.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, thomas@monjalon.net, ranjit.menon@intel.com,
	qiming.yang@intel.com, qi.z.zhang@intel.com,
	ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH 3/4] net/ice: disable ice DDP package on Windows
Date: Thu, 4 Mar 2021 16:31:00 -0800
Message-ID: <dde2be9d-6b4e-fa2f-152e-380ecbc5c434@intel.com> (raw)
In-Reply-To: <20210304021211.2dbac1a9@sovereign>

Hi Dmitry,

On 3/3/2021 3:12 PM, Dmitry Kozlyuk wrote:
> 2021-03-03 13:59, Pallavi Kadam:
>> Disable loading of private DDP packages in ice PMD on Windows.
>>
>> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
>> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
>> ---
>>   drivers/net/ice/ice_ethdev.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
> Are DDP packages unavailable on Windows or is their loading disabled because
> reading from PCI config space is not implemented by netuio? In the former
> case, please document the reason in commit (and probably in used guide?).
> In the latter case, could you instead fix rte_pci_config_read() to return (-1)
> on Windows, so that DDP loading automatically fails at reading capabilities?
> This would ensure ICE PMD remains portable by compiling all of its code in
> every platform.

Yes, loading of external DDP package is not supported on Windows.

Will update the commit message and the ice user guide accordingly in v2.


  reply	other threads:[~2021-03-05  0:31 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-03 21:59 [dpdk-dev] [PATCH 0/4] Support ice PMD " Pallavi Kadam
2021-03-03 21:59 ` [dpdk-dev] [PATCH 1/4] build: enable iavf driver " Pallavi Kadam
2021-03-03 21:59 ` [dpdk-dev] [PATCH 2/4] net/ice: build " Pallavi Kadam
2021-03-04 12:56   ` David Marchand
2021-03-08 23:30     ` Kadam, Pallavi
2021-03-03 21:59 ` [dpdk-dev] [PATCH 3/4] net/ice: disable ice DDP package " Pallavi Kadam
2021-03-03 23:12   ` Dmitry Kozlyuk
2021-03-05  0:31     ` Kadam, Pallavi [this message]
2021-03-03 21:59 ` [dpdk-dev] [PATCH 4/4] doc: update ice PMD and 21.05 release notes Pallavi Kadam
2021-03-03 23:13   ` Dmitry Kozlyuk
2021-03-05  0:25     ` Kadam, Pallavi
2021-03-11  1:58 ` [dpdk-dev] [PATCH v2 0/3] Support ice PMD on Windows Pallavi Kadam
2021-03-11  1:58   ` [dpdk-dev] [PATCH v2 1/3] build: enable iavf base code to build on windows Pallavi Kadam
2021-03-25 16:41     ` Jie Zhou
2021-03-26 11:41     ` Ferruh Yigit
2021-03-28  2:05       ` Kadam, Pallavi
2021-03-11  1:58   ` [dpdk-dev] [PATCH v2 2/3] net/ice: build on Windows Pallavi Kadam
2021-03-25 16:48     ` Jie Zhou
2021-03-26 11:51     ` Ferruh Yigit
2021-03-28  2:00       ` Kadam, Pallavi
2021-03-26 11:58     ` Ferruh Yigit
2021-03-28  2:04       ` Kadam, Pallavi
2021-03-11  1:58   ` [dpdk-dev] [PATCH v2 3/3] net/ice: disable ice DDP package " Pallavi Kadam
2021-03-25 16:55     ` Jie Zhou
2021-03-26 11:53     ` Ferruh Yigit
2021-03-28  2:02       ` Kadam, Pallavi
2021-04-02  1:26   ` [dpdk-dev] [PATCH v3 0/3] Support ice PMD " Pallavi Kadam
2021-04-02  1:26     ` [dpdk-dev] [PATCH v3 1/3] build: enable iavf base code to build on windows Pallavi Kadam
2021-04-02  1:26     ` [dpdk-dev] [PATCH v3 2/3] net/ice: build on Windows Pallavi Kadam
2021-04-02  1:26     ` [dpdk-dev] [PATCH v3 3/3] net/ice: disable ice DDP package " Pallavi Kadam
2021-04-06 16:40     ` [dpdk-dev] [PATCH v3 0/3] Support ice PMD " Ferruh Yigit
2021-04-06 17:22       ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dde2be9d-6b4e-fa2f-152e-380ecbc5c434@intel.com \
    --to=pallavi.kadam@intel.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=ferruh.yigit@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=ranjit.menon@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git