From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Dekel Peled <dekelp@mellanox.com>,
Matan Azrad <matan@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>,
Raslan Darawsheh <rasland@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix match on empty VLAN item in DV mode
Date: Mon, 11 May 2020 21:29:28 +0100 [thread overview]
Message-ID: <dde4f3a4-6986-8e15-9e92-839c6f93df8d@intel.com> (raw)
In-Reply-To: <VI1PR05MB53906B558FC8EBE0B6F98F5EB6A10@VI1PR05MB5390.eurprd05.prod.outlook.com>
On 5/11/2020 7:19 PM, Dekel Peled wrote:
> Repo link:
> https://git.dpdk.org/next/dpdk-next-net-mlx/commit/?id=40513808b165f7436389bfffcc8a35dbdc93121c
I mean as following:
commit 40513808b165 ("doc: refine ethernet and VLAN flow rule items")
>
> Regards,
> Dekel
>
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> Sent: Monday, May 11, 2020 8:19 PM
>> To: Dekel Peled <dekelp@mellanox.com>; Matan Azrad
>> <matan@mellanox.com>; Slava Ovsiienko <viacheslavo@mellanox.com>;
>> Raslan Darawsheh <rasland@mellanox.com>
>> Cc: dev@dpdk.org; stable@dpdk.org
>> Subject: Re: [dpdk-stable] [PATCH] net/mlx5: fix match on empty VLAN item
>> in DV mode
>>
>> On 5/5/2020 1:57 PM, Dekel Peled wrote:
>>> In existing implementation, using wild card VLAN item is not allowed.
>>> A VLAN item in flow pattern must include VLAN ID (vid) value.
>>> This obligation contradics the intention of documentation update [1].
>>
>> At this perspective it is not "documentation update" but "flow API
>> spec/contract".
>>
>>>
>>> This patch updates the VLAN item validation and translation, to allow
>>> wild card VLAN item, without VLAN ID value.
>>> User guide and release notes are updated accordingly.
>>>
>>> [1]
>>>
>> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatch
>>>
>> es.dpdk.org%2Fpatch%2F69207%2F&data=02%7C01%7Cdekelp%40mell
>> anox.co
>>>
>> m%7Ca4d34826f0104f0bfa4a08d7f5cf7090%7Ca652971c7d2e4d9ba6a4d14925
>> 6f461
>>>
>> b%7C0%7C0%7C637248143603832039&sdata=j%2BjcdLaYQ7Kzgdnq454X
>> q8RWfdl
>>> S7oFBibFgUjruGhk%3D&reserved=0
>>
>> Can you please refer to the commit in the repo, instead of a superseded
>> patch in patchwork?
>>
>> Will update above while merging.
>>
>>>
>>> Fixes: 00f75a40576b ("net/mlx5: fix VLAN match for DV mode")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
>>> Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
>>
>> <...>
>
prev parent reply other threads:[~2020-05-11 20:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 12:57 [dpdk-dev] " Dekel Peled
2020-05-10 10:48 ` Raslan Darawsheh
2020-05-11 17:19 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2020-05-11 18:19 ` Dekel Peled
2020-05-11 20:29 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dde4f3a4-6986-8e15-9e92-839c6f93df8d@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dekelp@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=rasland@mellanox.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).