From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24781A0613 for ; Thu, 26 Sep 2019 09:38:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E49CE1BDFD; Thu, 26 Sep 2019 09:38:08 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id F234E1B9BA for ; Thu, 26 Sep 2019 09:38:06 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2019 00:38:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,551,1559545200"; d="scan'208";a="219273442" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.10]) ([10.237.221.10]) by fmsmga002.fm.intel.com with ESMTP; 26 Sep 2019 00:38:03 -0700 To: "Yu, PingX" , Luca Boccassi , Kevin Traynor , "Mcnamara, John" , "Kusztal, ArkadiuszX" Cc: "Peng, Yuan" , "dev@dpdk.org" , "Xu, Qian Q" References: <20190815180508.14043-1-yskoh@mellanox.com> <4A3FBC67CD7DCF48BECD235A28B050330ADA8312@SHSMSX101.ccr.corp.intel.com> <67D543A150B29E4CAAE53918F64EDAEA3775D71C@SHSMSX103.ccr.corp.intel.com> <295acfbe39e7276664681fbf4566e528307a6bef.camel@debian.org> <02ff5c87524b34f9e53a8d1f30ce878ecd0625a3.camel@debian.org> <17f4b1440d4f4eece5d4c6c99db2cd40c8dbf69f.camel@debian.org> <234ee773a52d3ea52623c75725be2abbfea369f5.camel@debian.org> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: Date: Thu, 26 Sep 2019 08:38:04 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/26/2019 8:34 AM, Yu, PingX wrote: > Luca, > 1. Latest 17.11 branch is verified passed for feature PF. No issue now. > 2. bugs 3/4/5 are fixed now by arkadiuszx.kusztal@intel.com 's patch. No issue now. Can you please share the link of the mentioned patch? > > Regards, > Yu Ping > > -----Original Message----- > From: Luca Boccassi [mailto:bluca@debian.org] > Sent: Wednesday, September 25, 2019 4:08 AM > To: Kevin Traynor ; Yigit, Ferruh ; Mcnamara, John > Cc: Yu, PingX ; Peng, Yuan ; dev@dpdk.org; Xu, Qian Q > Subject: Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review and test > > Yu Ping, Qian, > > I have pushed to the 17.11 branch with the fixes for 1 and 2, and for building with kernel 5.3 (just a change in the comments, nothing functional). Do you need to re-run the test suite, or are you confident enough with a quick check? > > This release is already quite late, is it OK if bugs 3/4/5 are postponed to the next release? > > On Tue, 2019-09-24 at 18:25 +0100, Luca Boccassi wrote: >> On Tue, 2019-09-24 at 18:15 +0100, Kevin Traynor wrote: >>> On 24/09/2019 17:36, Ferruh Yigit wrote: >>>> On 9/24/2019 12:07 PM, Luca Boccassi wrote: >>>>> Ping - any updates on these patches? The release of 17.11.7 is >>>>> currently on hold waiting for a resolution here. >>>> >>>> Hi Luca, >>>> >>>> Test team provided some internal details: >>>> >>>> 1- Build issue on f30, >>>> A patch has been sent to stable mail list to fix it, not sure if >>>> it has been >>>> merged: >>>> https://mails.dpdk.org/archives/stable/2019-September/017122.html >>>> >>>> >> >> Thanks Ferruh, I am testing a build with that one. >> >>>> 2- "make -C test/" fails. >>>> "Fix looks to be to add "#include " into >>>> test_rwlock.c" >>>> Not sure if there is a patch for this. >>> >>> Hi, this include was added in 18.11 as part of: >>> >>> commit 0d0dfaaff93cb599b2c58fd6fe405fd4f44b5710 >>> Author: Joyce Kong < >>> joyce.kong@arm.com >>> >>> >>> Date: Tue Sep 10 11:36:58 2019 +0800 >>> >>> test/rwlock: benchmark on all available cores >>> >>> [ upstream commit fe252fb695efa9deb95f2e6b7baf6f805996a5b0 ] >>> >>> >>> Note, the master commit would not apply and it was a custom backport >>> for >>> 18.11 by Joyce >>> ( >>> http://inbox.dpdk.org/stable/1568086619-5029-1-git-send-email-joyce. >>> kong@arm.com >>> >>> ) >>> Maybe it can work for 17.11 too? >> >> Hi, >> >> It was backported for 17.11 too, but it does not have the include. >> I'll >> test another commits that has it. >> >>>> 3- l2fwd-crypto, ERROR: Test Case test_qat_h_AES_XCBC_MAC_auto >>>> Result FAILED Work in progress >>>> >>>> 4- ipsec-secgw, forwarding failed with null crypto QAT Work in >>>> progress >>>> >>>> 5- Unit test "cryptodev_qat_autotest" failed Issue not analyzed >>>> yet. >>>> >>>> >>>>> Thanks! >>>>> >>>>> On Wed, 2019-09-18 at 10:03 +0000, Yu, PingX wrote: >>>>>> Luca, >>>>>> FYI. Currently there isn't reference for bug1 and bug2 and >>>>>> also haven't send to mailing list yet. These bugs should be >>>>>> fixed before release as they will block the basic PF test. >>>>>> >>>>>> Regards, >>>>>> Yu Ping >>>>>> >>>>>> >>>>>> -----Original Message----- >>>>>> From: dev [mailto: >>>>>> dev-bounces@dpdk.org >>>>>> >>>>>> >>>>>> ] On Behalf Of Luca Boccassi >>>>>> Sent: Wednesday, September 18, 2019 5:18 PM >>>>>> To: Peng, Yuan < >>>>>> yuan.peng@intel.com >>>>>> >>>>>> >>>>>>> ; >>>>>> >>>>>> dev@dpdk.org >>>>>> >>>>>> >>>>>> >>>>>> Subject: Re: [dpdk-dev] FW: 17.11.7-rc1 (LTS) patches review >>>>>> and test >>>>>> >>>>>> Hi, >>>>>> >>>>>> Ping - this is blocking the 17.11.7 release. >>>>>> >>>>>> Thanks! >>>>>> >>>>>> On Tue, 2019-09-17 at 10:53 +0100, Luca Boccassi wrote: >>>>>>> Hello, >>>>>>> >>>>>>> Do you have a reference for the patches for bug 1 and 2? >>>>>>> Have >>>>>>> they >>>>>>> been sent to the mailing list? >>>>>>> >>>>>>> On Thu, 2019-09-12 at 08:52 +0000, Peng, Yuan wrote: >>>>>>>> Update the latest test status here. >>>>>>>> >>>>>>>> -----Original Message----- >>>>>>>> From: Yu, PingX >>>>>>>> Sent: Thursday, September 12, 2019 2:37 PM >>>>>>>> To: Yongseok Koh < >>>>>>>> yskoh@mellanox.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Ananyev, Konstantin < >>>>>>>> >>>>>>>> konstantin.ananyev@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; >>>>>>>> >>>>>>>> asafp@mellanox.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Cc: Xu, Qian Q < >>>>>>>> qian.q.xu@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Lin, Xueqin < >>>>>>>> >>>>>>>> xueqin.lin@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Chen, Zhaoyan < >>>>>>>> >>>>>>>> zhaoyan.chen@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; O'Hare, Cathal < >>>>>>>> >>>>>>>> cathal.ohare@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Yigit, Ferruh < >>>>>>>> >>>>>>>> ferruh.yigit@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Ma, LihongX < >>>>>>>> >>>>>>>> lihongx.ma@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Li, WenjieX A < >>>>>>>> >>>>>>>> wenjiex.a.li@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Wang, FengqinX < >>>>>>>> >>>>>>>> fengqinx.wang@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Peng, Yuan < >>>>>>>> >>>>>>>> yuan.peng@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Subject: RE: 17.11.7-rc1 (LTS) patches review and test >>>>>>>> >>>>>>>> All, >>>>>>>> Update the latest test status here. >>>>>>>> The critical bug has been fixed and we have re-tested all >>>>>>>> Intel >>>>>>>> key >>>>>>>> features. >>>>>>>> >>>>>>>> Intel(R) Testing result lists here. >>>>>>>> # Basic Intel(R) NIC testing >>>>>>>> * PF(i40e): One bug found in 1st round test. 2nd round >>>>>>>> test >>>>>>>> pass >>>>>>>> after fixing the bug. (see Bug1) >>>>>>>> * PF(ixgbe): the same as PF(i40e). >>>>>>>> * VF: Pass and no issue. >>>>>>>> * Build or compile: One bug found in 1st round test. 2nd >>>>>>>> round >>>>>>>> test >>>>>>>> pass after fixing the bug. (see Bug2) >>>>>>>> * Intel NIC single core/NIC performance: Pass and no >>>>>>>> issue. >>>>>>>> >>>>>>>> #Basic cryptodev and virtio testing >>>>>>>> * vhost/virtio basic loopback, PVP and performance test: >>>>>>>> pass. >>>>>>>> * cryptodev: 3 bugs are found(see bug statistic in >>>>>>>> below). >>>>>>>> (See >>>>>>>> Bug3,4 and 5) >>>>>>>> >>>>>>>> Bugs statistic: >>>>>>>> Bug1: make -C test/ failed. It blocked about 60 test >>>>>>>> cases >>>>>>>> for >>>>>>>> both >>>>>>>> PF(i40e) and PF(ixgbe). Resolved by adding "#include >>>>>>>> " >>>>>>>> into test_rwlock.c. Please decide whether submit a patch >>>>>>>> to >>>>>>>> DPDK >>>>>>>> or >>>>>>>> not. >>>>>>>> Bug2: compile error on fc30. Patch is provided and >>>>>>>> validated >>>>>>>> pass. >>>>>>>> Need to decide whether merge into DPDK or not. >>>>>>>> Bug3: L2fwd: test_qat_h_AES_XCBC_MAC_auto failed. No >>>>>>>> progress >>>>>>>> yet. >>>>>>>> commit 39fb9500c42752a537588f7a203433ec4737fa1e >>>>>>>> Author: Arek Kusztal < >>>>>>>> arkadiuszx.kusztal@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Date: Wed Dec 12 20:59:02 2018 +0100 >>>>>>>> >>>>>>>> Bug4: Ipsec-gw_test forwarding failed with null crypto >>>>>>>> QAT. >>>>>>>> No >>>>>>>> progress yet. >>>>>>>> commit 39fb9500c42752a537588f7a203433ec4737fa1e >>>>>>>> Author: Arek Kusztal < >>>>>>>> arkadiuszx.kusztal@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Date: Wed Dec 12 20:59:02 2018 +0100 >>>>>>>> >>>>>>>> Bug5: Crypto: cryptodev_qat_autotest test failed. No >>>>>>>> progress >>>>>>>> yet. >>>>>>>> 39fb9500c42752a537588f7a203433ec4737fa1e is the first >>>>>>>> bad >>>>>>>> commit >>>>>>>> commit 39fb9500c42752a537588f7a203433ec4737fa1e >>>>>>>> Author: Arek Kusztal < >>>>>>>> arkadiuszx.kusztal@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Date: Wed Dec 12 20:59:02 2018 +0100 >>>>>>>> >>>>>>>> Regards, >>>>>>>> Yu Ping >>>>>>>> >>>>>>>> >>>>>>>> -----Original Message----- >>>>>>>> From: Wang, FengqinX >>>>>>>> Sent: Monday, August 26, 2019 3:12 PM >>>>>>>> To: Yongseok Koh < >>>>>>>> yskoh@mellanox.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Ananyev, Konstantin < >>>>>>>> >>>>>>>> konstantin.ananyev@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; >>>>>>>> >>>>>>>> asafp@mellanox.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Cc: Xu, Qian Q < >>>>>>>> qian.q.xu@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Lin, Xueqin < >>>>>>>> >>>>>>>> xueqin.lin@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Chen, Zhaoyan < >>>>>>>> >>>>>>>> zhaoyan.chen@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; O'Hare, Cathal < >>>>>>>> >>>>>>>> cathal.ohare@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Yigit, Ferruh < >>>>>>>> >>>>>>>> ferruh.yigit@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Yu, PingX < >>>>>>>> >>>>>>>> pingx.yu@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Ma, LihongX < >>>>>>>> >>>>>>>> lihongx.ma@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Li, WenjieX A < >>>>>>>> >>>>>>>> wenjiex.a.li@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Subject: RE: 17.11.7-rc1 (LTS) patches review and test >>>>>>>> >>>>>>>> Add asafp in the loop due to Yongseok is longer working >>>>>>>> at >>>>>>>> Mellanox. >>>>>>>> >>>>>>>> BRs, Vicky >>>>>>>> >>>>>>>> -----Original Message----- >>>>>>>> From: Wang, FengqinX >>>>>>>> Sent: Monday, August 26, 2019 3:07 PM >>>>>>>> To: 'Yongseok Koh' < >>>>>>>> yskoh@mellanox.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Ananyev, Konstantin < >>>>>>>> >>>>>>>> konstantin.ananyev@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Cc: Xu, Qian Q < >>>>>>>> qian.q.xu@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Lin, Xueqin < >>>>>>>> >>>>>>>> xueqin.lin@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Chen, Zhaoyan < >>>>>>>> >>>>>>>> zhaoyan.chen@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; O'Hare, Cathal < >>>>>>>> >>>>>>>> cathal.ohare@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Yigit, Ferruh < >>>>>>>> >>>>>>>> ferruh.yigit@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Yu, PingX < >>>>>>>> >>>>>>>> pingx.yu@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Ma, LihongX < >>>>>>>> >>>>>>>> lihongx.ma@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Li, WenjieX A < >>>>>>>> >>>>>>>> wenjiex.a.li@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Subject: RE: 17.11.7-rc1 (LTS) patches review and test >>>>>>>> >>>>>>>> Hi Yongseok, Konstantin, >>>>>>>> >>>>>>>> There is one critical compile issue found, and below is >>>>>>>> the >>>>>>>> bad >>>>>>>> commit related information, this issue has blocked most >>>>>>>> of >>>>>>>> unit >>>>>>>> tests which have used dpdk/test/test, would you please >>>>>>>> help >>>>>>>> to >>>>>>>> fix >>>>>>>> this issue ASAP? >>>>>>>> >>>>>>>> commit 29e08d740ffc1e0ed9e7a9bd25fb95714fac1070 >>>>>>>> Author: Joyce Kong < >>>>>>>> joyce.kong@arm.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Date: Thu Jul 25 14:50:21 2019 +0800 >>>>>>>> >>>>>>>> test/rwlock: benchmark on all available cores >>>>>>>> >>>>>>>> [ backported from upstream commit >>>>>>>> fe252fb695efa9deb95f2e6b7baf6f805996a5b0 ] >>>>>>>> >>>>>>>> Add performance test on all available cores to >>>>>>>> benchmark >>>>>>>> the scaling up performance of rw_lock. >>>>>>>> >>>>>>>> Fixes: af75078fece3 ("first public release") >>>>>>>> >>>>>>>> Suggested-by: Gavin Hu < >>>>>>>> gavin.hu@arm.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Signed-off-by: Joyce Kong < >>>>>>>> joyce.kong@arm.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Acked-by: Konstantin Ananyev < >>>>>>>> konstantin.ananyev@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> And below is the error message output: >>>>>>>> >>>>>>>> test_rwlock.c: In function 'load_loop_fn': >>>>>>>> test_rwlock.c:126:38: error: expected ')' before 'PRIu64' >>>>>>>> printf("Core [%u] rwlock_data = %"PRIu64"\n", ^~~~~~ >>>>>>>> ) >>>>>>>> test_rwlock.c:126:19: error: format '%u' expects a >>>>>>>> matching >>>>>>>> 'unsigned int' argument [-Werror=format=] printf("Core >>>>>>>> [%u] >>>>>>>> rwlock_data = %"PRIu64"\n", ~^ >>>>>>>> test_rwlock.c:126:36: error: spurious trailing '%' in >>>>>>>> format [- >>>>>>>> Werror=format=] printf("Core [%u] rwlock_data = >>>>>>>> %"PRIu64"\n", ^ >>>>>>>> test_rwlock.c: In function 'test_rwlock_perf': >>>>>>>> test_rwlock.c:160:31: error: expected ')' before 'PRIu64' >>>>>>>> printf("Core [%u] count = %"PRIu64"\n", i, >>>>>>>> lock_count[i]); >>>>>>>> ^~~~~~ >>>>>>>> ) >>>>>>>> test_rwlock.c:160:18: error: format '%u' expects a >>>>>>>> matching >>>>>>>> 'unsigned int' argument [-Werror=format=] printf("Core >>>>>>>> [%u] >>>>>>>> count >>>>>>>> = >>>>>>>> %"PRIu64"\n", i, lock_count[i]); ~^ >>>>>>>> test_rwlock.c:160:29: error: spurious trailing '%' in >>>>>>>> format [- >>>>>>>> Werror=format=] printf("Core [%u] count = %"PRIu64"\n", >>>>>>>> i, >>>>>>>> lock_count[i]); ^ >>>>>>>> test_rwlock.c:164:26: error: expected ')' before 'PRIu64' >>>>>>>> printf("Total count = %"PRIu64"\n", total); ^~~~~~ >>>>>>>> ) >>>>>>>> test_rwlock.c:164:24: error: spurious trailing '%' in >>>>>>>> format [- >>>>>>>> Werror=format=] printf("Total count = %"PRIu64"\n", >>>>>>>> total); >>>>>>>> ^ >>>>>>>> cc1: all warnings being treated as errors >>>>>>>> >>>>>>>> BRs, Vicky >>>>>>>> >>>>>>>> -----Original Message----- >>>>>>>> From: Yongseok Koh [mailto: >>>>>>>> yskoh@mellanox.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> ] >>>>>>>> Sent: Friday, August 16, 2019 2:05 AM >>>>>>>> To: dpdk stable < >>>>>>>> stable@dpdk.org >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Cc: >>>>>>>> dev@dpdk.org >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> ; >>>>>>>> pezhang@redhat.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> ; >>>>>>>> siliu@redhat.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> ; Wang, FengqinX < >>>>>>>> fengqinx.wang@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Chen, Zhaoyan < >>>>>>>> >>>>>>>> zhaoyan.chen@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; Xu, Qian Q < >>>>>>>> >>>>>>>> qian.q.xu@intel.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> ; >>>>>>>> >>>>>>>> alialnu@mellanox.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> ; >>>>>>>> rasland@mellanox.com >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Subject: 17.11.7-rc1 (LTS) patches review and test >>>>>>>> >>>>>>>> Hi all, >>>>>>>> >>>>>>>> Here is a list of patches targeted for LTS release >>>>>>>> 17.11.7. >>>>>>>> Please >>>>>>>> help review and test. The planned date for the final >>>>>>>> release is >>>>>>>> Aug >>>>>>>> 23, Before that, please shout if anyone has objections >>>>>>>> with >>>>>>>> these >>>>>>>> patches being applied. >>>>>>>> >>>>>>>> Also for the companies committed to running regression >>>>>>>> tests, >>>>>>>> please >>>>>>>> run the tests and report any issue before the release >>>>>>>> date. >>>>>>>> >>>>>>>> A release candidate tarball can be found at: >>>>>>>> >>>>>>>> >>>>>>>> https://dpdk.org/browse/dpdk-stable/tag/?id=v17.11.7-rc1 >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> These patches are located at branch 17.11 of dpdk-stable >>>>>>>> repo: >>>>>>>> >>>>>>>> https://dpdk.org/browse/dpdk-stable/ >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Yongseok >>>>>>>> >>>>>>>> --- >>>>>>>> >>>>>>>> Aaron Conole (1): >>>>>>>> net/virtio: fix dangling pointer on failure >>>>>>>> >>>>>>>> Agalya Babu RadhaKrishnan (1): >>>>>>>> doc: fix interactive commands in testpmd guide >>>>>>>> >>>>>>>> Akhil Goyal (1): >>>>>>>> crypto/dpaa2_sec: fix session clearing >>>>>>>> >>>>>>>> Alejandro Lucero (1): >>>>>>>> net/nfp: fix RSS query >>>>>>>> >>>>>>>> Anatoly Burakov (2): >>>>>>>> eal: improve musl compatibility of string functions >>>>>>>> malloc: fix documentation of realloc function >>>>>>>> >>>>>>>> Andrew Rybchenko (2): >>>>>>>> net/sfc: remove control path logging from Rx queue >>>>>>>> count >>>>>>>> app/testpmd: set fixed flag for exact link speed >>>>>>>> >>>>>>>> Andrius Sirvys (3): >>>>>>>> net/virtio: fix duplicate naming of include guard >>>>>>>> bitrate: fix unchecked return value >>>>>>>> drivers/net: fix shifting 32-bit signed variable 31 >>>>>>>> times >>>>>>>> >>>>>>>> Anoob Joseph (1): >>>>>>>> cryptodev: fix driver name comparison >>>>>>>> >>>>>>>> Beilei Xing (1): >>>>>>>> net/i40e: fix link speed for X722 >>>>>>>> >>>>>>>> Bernard Iremonger (1): >>>>>>>> examples/ipsec-secgw: fix debug logs >>>>>>>> >>>>>>>> Bill Hong (1): >>>>>>>> net: fix Tx VLAN flag for offload emulation >>>>>>>> >>>>>>>> Bruce Richardson (9): >>>>>>>> eal: support strlcat function >>>>>>>> net/bonding: fix buffer length when printing >>>>>>>> strings >>>>>>>> examples/l2fwd-cat: fix build on FreeBSD >>>>>>>> app/crypto-perf: check range of socket id >>>>>>>> examples/vhost_scsi: fix null-check for parameter >>>>>>>> net/i40e: fix dereference before null check in mbuf >>>>>>>> release >>>>>>>> net/ixgbe: fix warning with GCC 9 >>>>>>>> bus/fslmc: fix warning with GCC 9 >>>>>>>> eal: tighten permissions on shared memory files >>>>>>>> >>>>>>>> Chaitanya Babu Talluri (2): >>>>>>>> drivers/net: fix possible overflow using strlcat >>>>>>>> cfgfile: replace strcat with strlcat >>>>>>>> >>>>>>>> David Christensen (2): >>>>>>>> maintainers: update for IBM POWER >>>>>>>> examples/vm_power_manager: fix PMD specific code >>>>>>>> >>>>>>>> David Marchand (7): >>>>>>>> eal: fix check when retrieving current CPU affinity >>>>>>>> eal: remove dead code in core list parsing >>>>>>>> app/testpmd: remove unused field from port struct >>>>>>>> doc: fix examples in bonding guide >>>>>>>> net/bonding: fix port id types >>>>>>>> net/bonding: fix queue index types >>>>>>>> app/testpmd: remove useless casts on statistics >>>>>>>> >>>>>>>> Davide Caratti (1): >>>>>>>> net/bnxt: support IOVA VA mode >>>>>>>> >>>>>>>> Dekel Peled (8): >>>>>>>> net/mlx5: fix hex dump of error completion >>>>>>>> net/mlx5: fix sync when handling Tx completions >>>>>>>> eal/ppc: fix global memory barrier >>>>>>>> eal: fix typo in comment of vector function >>>>>>>> doc: fix links to doxygen and sphinx sites >>>>>>>> app/testpmd: fix typo in comment >>>>>>>> net/mlx5: fix comments mixing Rx and Tx >>>>>>>> net/mlx5: fix release of Rx queue object >>>>>>>> >>>>>>>> Fan Zhang (1): >>>>>>>> examples/ipsec-secgw: fix AES-CTR block size >>>>>>>> >>>>>>>> Ferruh Yigit (5): >>>>>>>> kni: fix build with Linux 5.1 >>>>>>>> build: fix crash by disabling AVX512 with binutils >>>>>>>> 2.31 >>>>>>>> net/ring: fix return value check >>>>>>>> net/kni: fix return value check >>>>>>>> app/testpmd: revert fixed flag for exact link speed >>>>>>>> >>>>>>>> Gage Eads (1): >>>>>>>> ring: fix namesize macro documentation block >>>>>>>> >>>>>>>> Gavin Hu (3): >>>>>>>> test/spinlock: remove delay for correct >>>>>>>> benchmarking >>>>>>>> test/spinlock: amortize the cost of getting time >>>>>>>> spinlock: reimplement with atomic one-way barrier >>>>>>>> >>>>>>>> Hari Kumar Vemula (1): >>>>>>>> net/bonding: fix reset active slave >>>>>>>> >>>>>>>> Harry van Haaren (1): >>>>>>>> event/sw: fix enqueue checks in self-test >>>>>>>> >>>>>>>> Herakliusz Lipiec (1): >>>>>>>> doc: fix broken link in LPM guide >>>>>>>> >>>>>>>> Hyong Youb Kim (4): >>>>>>>> net/bonding: avoid warning for invalid port >>>>>>>> net/enic: fix flow director SCTP matching >>>>>>>> net/enic: fix SCTP match for flow API >>>>>>>> net/enic: check for unsupported flow item types >>>>>>>> >>>>>>>> Igor Romanov (1): >>>>>>>> app/testpmd: fix stdout flush after printing stats >>>>>>>> >>>>>>>> Ilya Maximets (2): >>>>>>>> vhost: fix device leak on connection add failure >>>>>>>> vhost: fix silent queue enabling with legacy guests >>>>>>>> >>>>>>>> Ivan Malov (1): >>>>>>>> net/sfc: log port ID as 16-bit unsigned integer on >>>>>>>> panic >>>>>>>> >>>>>>>> Jerin Jacob (1): >>>>>>>> mk: fix AVX512 disabled warning on non x86 >>>>>>>> >>>>>>>> Jianfeng Tan (1): >>>>>>>> drivers/net: do not use private ethdev data >>>>>>>> >>>>>>>> Joyce Kong (1): >>>>>>>> test/rwlock: benchmark on all available cores >>>>>>>> >>>>>>>> Kevin Traynor (3): >>>>>>>> net/qede: support IOVA VA mode >>>>>>>> eal/linux: fix log levels for pagemap reading >>>>>>>> failure >>>>>>>> power: fix frequency list buffer validation >>>>>>>> >>>>>>>> Liang Zhang (1): >>>>>>>> net/bonding: fix LACP negotiation >>>>>>>> >>>>>>>> Luo Gaoliang (1): >>>>>>>> kni: fix build on RHEL8 >>>>>>>> >>>>>>>> Marcin Smoczynski (1): >>>>>>>> examples/ipsec-secgw: fix build error log >>>>>>>> >>>>>>>> Natanael Copa (3): >>>>>>>> bus/fslmc: remove unused include of error.h >>>>>>>> bus/fslmc: fix build with musl libc >>>>>>>> app/test: fix build with musl libc >>>>>>>> >>>>>>>> Pallantla Poornima (3): >>>>>>>> app/test: fix sprintf with strlcat >>>>>>>> test/distributor: replace sprintf with strlcpy >>>>>>>> test/hash: replace sprintf with snprintf >>>>>>>> >>>>>>>> Qi Zhang (1): >>>>>>>> net/i40e: fix time sync for 25G >>>>>>>> >>>>>>>> Radu Nicolau (3): >>>>>>>> net/null: add MAC address setting fake operation >>>>>>>> test/virtual_pmd: add MAC address setting fake op >>>>>>>> test/bonding: assign non-zero MAC to null devices >>>>>>>> >>>>>>>> Rahul Lakkireddy (1): >>>>>>>> net/cxgbe: update Chelsio T5/T6 NIC device ids >>>>>>>> >>>>>>>> Rami Rosen (8): >>>>>>>> net/virtio: remove forward declaration >>>>>>>> mbuf: fix a typo >>>>>>>> doc: fix a minor typo in testpmd guide >>>>>>>> doc: remove reference to rte.doc.mk in programmers >>>>>>>> guide >>>>>>>> examples/ethtool: fix two typos >>>>>>>> doc: fix link in Linux getting started guide >>>>>>>> app/testpmd: fix a typo in log message >>>>>>>> ethdev: fix a typo >>>>>>>> >>>>>>>> Rasesh Mody (2): >>>>>>>> net/bnx2x: fix race for periodic flags >>>>>>>> net/bnx2x: fix optic module verification >>>>>>>> >>>>>>>> Shahaf Shuler (1): >>>>>>>> net/mlx5: fix packet inline on Tx queue wraparound >>>>>>>> >>>>>>>> Shahed Shaikh (5): >>>>>>>> net/bnx2x: fix segfaults due to stale interrupt >>>>>>>> status >>>>>>>> net/bnx2x: fix memory leak >>>>>>>> net/bnx2x: fix ramrod timeout >>>>>>>> net/bnx2x: fix DMAE timeout >>>>>>>> net/qede: fix Tx packet prepare for tunnel packets >>>>>>>> >>>>>>>> Shreyansh Jain (1): >>>>>>>> bus/dpaa: fix Rx discard register mask >>>>>>>> >>>>>>>> Stephen Hemminger (8): >>>>>>>> net/octeontx: fix vdev name >>>>>>>> net/bnxt: fix Rx VLAN offload flags >>>>>>>> net/virtio: remove useless condition >>>>>>>> ring: fix an error message >>>>>>>> net/ring: avoid hard-coded length >>>>>>>> net/ring: use calloc style where appropriate >>>>>>>> net/ring: check length of ring name >>>>>>>> net/virtio: fix buffer leak on VLAN insert >>>>>>>> >>>>>>>> Thomas Monjalon (2): >>>>>>>> mk: fix build of shared library with libbsd >>>>>>>> bus/vdev: fix debug message on probing >>>>>>>> >>>>>>>> Tiwei Bie (4): >>>>>>>> net/virtio: add barrier in interrupt enable >>>>>>>> vhost: restore mbuf first when freeing zmbuf >>>>>>>> vhost: fix potential use-after-free for zero copy >>>>>>>> mbuf >>>>>>>> vhost: fix potential use-after-free for memory >>>>>>>> region >>>>>>>> >>>>>>>> Vishal Kulkarni (1): >>>>>>>> net/cxgbe: fix missing checksum flags and packet >>>>>>>> type >>>>>>>> >>>>>>>> Xiao Wang (1): >>>>>>>> net/fm10k: fix VLAN strip offload flag >>>>>>>> >>>>>>>> Yipeng Wang (1): >>>>>>>> hash: fix doc about thread/process safety >>>>>>>> >>>>>>>> Yongseok Koh (4): >>>>>>>> net/mlx5: fix instruction hotspot on replenishing >>>>>>>> Rx >>>>>>>> buffer >>>>>>>> net/mlx5: check Tx queue size overflow >>>>>>>> net/mlx5: fix max number of queues for NEON Tx >>>>>>>> doc: fix typo in mlx5 guide >>>>>>>> >>>>>>>> Yunjian Wang (1): >>>>>>>> net/ixgbe: fix crash on remove >>>>>>>> >>>>>>>> >>>>>> >>>>>> -- >>>>>> Kind regards, >>>>>> Luca Boccassi >>>>>> >>> >>> >>>