From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 70F6841CE3; Sun, 19 Feb 2023 21:15:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 531F942D32; Sun, 19 Feb 2023 21:15:45 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2060.outbound.protection.outlook.com [40.107.93.60]) by mails.dpdk.org (Postfix) with ESMTP id EE53140698 for ; Sun, 19 Feb 2023 21:15:43 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KZD/JVRmP9pRkUXupD9BOwM7o8r1v0narzRpMOBuI//mgAHSihSI3cZefrTkUOkqc9XAAqffuoynKL6yFetO5RLhAX6HYRD106BjJsuw7bpDynYQh741NNWg0kVtD820+7D3l2GKoLn/qnRtw8yY7GATk6EAqfPSOg5KorPxTpufVdBY3dpvwTN/kQdHz0f8JNZLXpRB/jAH4qPhb3+eD3m13sqlziG4aXhpvTJ//P+qXju+n6E7pUW4BIbU9y0+BCV+e4knr5c+lb/gpQv4uNUQ8lolZLJlDVpY7IuxGKTNnQNtOjXH8k7LHFMzvtuPlOUbr5pyOW9UUiUwpIXznA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fd2mVbB/kp2je9STWFyBfzt1t46zEa6VMn+1ep6tfb4=; b=j94DcABAwzBd95Y3C9xdtAguap9fBHRKz8Yfo4gnn7EccoyOr59SXgY4vh3j2dVoc8fu4ii6Jgv01wYP1YK0DEZD5RVKfY0Karv1okZV2QTRUtA/2yjF2l8DBE4uMkGsrNHHK5/LSthkKJtA/54wXfRM+wzvdbTw+K1QxrPfXrTLAvRcGskuUj8FLWiyBJiTvXnICJRXSOhB6l0O4aHd4au5iyOkw5uGptjhpCs+3civCJAl5Xm6cJAseHuqCyh0+dI3ts5opC4IxuJxSCUwvBN1cB1VJOXrJ2mXxKZ0T22+yeUtUDmhZa+heOePfL2boPtWmRiwqh3exdEO+TylKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fd2mVbB/kp2je9STWFyBfzt1t46zEa6VMn+1ep6tfb4=; b=ISx3/PPtiW9qz7qs/VrN9SfTBm8g8c7hEKD7OUIRychSK1Vrab7mvhFvlRZpJKci9i7CXN+/noWfnf+V7oHfEdhOo5dRa1M4lr+MsyVBkrFGHL1uggMCDikJRkyVghpmOhpaVwQhuDpWs8WhdWCSpARMTAfEw0LyFIuz7FdaS64= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CY5PR12MB6429.namprd12.prod.outlook.com (2603:10b6:930:3b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Sun, 19 Feb 2023 20:15:41 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3614:22ed:ed5:5b48%7]) with mapi id 15.20.6111.019; Sun, 19 Feb 2023 20:15:41 +0000 Message-ID: Date: Sun, 19 Feb 2023 20:15:35 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] net/gve: add Rx/Tx queue statistics Content-Language: en-US To: Levend Sayar , junfeng.guo@intel.com Cc: dev@dpdk.org References: <20230219003111.85508-1-levendsayar@gmail.com> From: Ferruh Yigit In-Reply-To: <20230219003111.85508-1-levendsayar@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PA7P264CA0141.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:377::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CY5PR12MB6429:EE_ X-MS-Office365-Filtering-Correlation-Id: 75dd04a8-b4e9-4bb0-514b-08db12b612c2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sULs1VHqUz0p73N+kcgme1pHvBAFD0uEbSCIHkIkjYKJagGlfw9e4k976bYYi2GuB1ccMRm8dN3tXCb+umcyhVK6gvpOkI1tl2ivbpTNyo6C5mpgsjRzqzhMchdrWZ3Vjottwgg4Q7Oo+vWefA1pSfwnMJuCG52chnk0nksjyDSBzH+gHQKHiJupOzBM60Yaf8TrwlVExtQs4+5dpLb3xgrAGYEnwWxlekhdZ/G27Mn+Jp3YeQB+tJigm9ii28I2LYN9Zx/I6Omkz7o9bmuF04FAYArVshHtfbNs5BsSA3sAxK9gPRdqGBI8AZY4nJiXc1IkfDRK6R5ADhphcynI7BB68Xmq94ewjOBNTa+AKPoXDlVOTEgwRhAMxR53og+5kLXhI22FyGx34q2e8lbOPSpBvGNHUDKO+fIB+xeBUVbx/wXEu/2RpqRkjms/6FP7zua0alERHTpiOAPNmL1Jx9tK6RdK+vtiwLCC1F1bkbB5doHo0RZ5TN3B4HkAEFtnpxmToqH/fvFAtRIefH+jbME8eYdbYMX8h9C9m6QN+q7LdoktPnAaY2JVcn4F9KK+7eiF2Mv/YY4myDdM+rLIGIoeu2lwM588QwSHWVSUIRZl4Rn/aPSor5zDs+JSnGhMFZNktuk31jT1p7DAxTkJu+A9/DSolBO6E3X5x1D6rqTozvnCK3J9d+2hvCD4kR4VgZEdfb49XPQJ398OTSG26g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(396003)(366004)(136003)(346002)(376002)(39860400002)(451199018)(86362001)(6512007)(478600001)(186003)(31686004)(26005)(8676002)(31696002)(38100700002)(66556008)(8936002)(44832011)(5660300002)(2616005)(966005)(2906002)(6666004)(4326008)(36756003)(6486002)(41300700001)(53546011)(66946007)(6506007)(316002)(66476007)(83380400001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0dsOUhJU2RFOU45aDdubmxaV2orV01ZQkd0em9keWhScjFNTGZ6SEcrUlFR?= =?utf-8?B?MStlanRXRGJXall0OXFkQ0ZKcXpFeE5aMGlwMXhLNDBFQWNVdEVMcE4yV3c4?= =?utf-8?B?a2VsOXRUNEJpSFdnVGVDK29jeXhJNXl4N1d6Yi9GV0pqZDd0bGhZZDkxb3Z4?= =?utf-8?B?aGhSUE1UenRpcVB4Q2xNREo4V2JQOVl4SjlyYlp4WCtOclRkdm1RQWxPMmh5?= =?utf-8?B?eEw5SUhHZFpoZXlmYSsxTHlEclR6L0ZZNUNITlZjaW5HZ2lPbEhBcFV0ZGV0?= =?utf-8?B?VzJ0Qi9sdHlXS1hlV21yWGlYWGhoY3Q1c09PZmFwRWhoZzNrYjU3cHRhSFh3?= =?utf-8?B?NlVPLzF2VjdQbjFCUlhvK1lyakR3TmYwcWVoUnZEKzg4MzFicW1iSHh4bHNM?= =?utf-8?B?SFp6TWYxWFVpY01oL21LN24rS05OVER2dDA0WmdseGhVVE9idHVRZ05lRC9v?= =?utf-8?B?Qk5MZVdaTHA2c1hZMERubFlGdnppMVc2REJHbkNkVW02dUVnN042Q0lJQTcv?= =?utf-8?B?cmh2SnVQTEhrV1ZVbHdIc21HYU92Rm5xQzM0N2JUbFpqZmdJa3ZHTzlWcVEz?= =?utf-8?B?Z296eTJZK1llNjgrM2lKb2tnUVh3SExyc1Y5dnVlQ2VqTXpHMU5TZjh4ZTZB?= =?utf-8?B?U1M3QlB1SkFJc3RLVzR1dXozdENyREVIanRqdm51bythRnhoZWlQZWJjSFBn?= =?utf-8?B?NVVubWhHTjFnV2Z0eXJZUjhaenNzZHVoeXhwK05GOG9CUlJZeWRyQkJ4Mml2?= =?utf-8?B?QzAzZmdpaXZHdTVQM2VZeGlWRUtrakdybWI5eWNBR1lOUStuUkZsNmdFWnM2?= =?utf-8?B?M2k1MERoZVJuVmU2MzVwOW80QVFQdndRN0ZKbkY4QXNCZzRXTEFGMDRpSkFo?= =?utf-8?B?ZzZvZXFvWitqanZmcjl5RGIzVHhibzYrZTg0MElzbDc2NkFjRkRoNzJvSFhE?= =?utf-8?B?a1FySzlURWlVTlE1eERicXgwOWdpNWZxZk0wZmxzVThoRWxOQVpLRmJMcVdU?= =?utf-8?B?emtCYWtsSC80aVlCUkI1dXhJdG5WYkt6djZOTEhudHdsOW0rQ1J4MEJJVGph?= =?utf-8?B?c3Y3WkIzNnpSbStEUGhhYnVTaGNYUUdVMHVZWXg3azFQYmh5aTZ3V3M2dW42?= =?utf-8?B?S2lIWTZwMHBTZ29Lb2FMRERURDVGYTNSK1JNSFhzcEFkRE1nM3J1TkhIS1Zo?= =?utf-8?B?Qk5nR0h5MmwzQVdSWUFLSjY3cHJYb3FRbmtmSHR5aVJ0QSs1SEdlTjFYWC9i?= =?utf-8?B?ZmRQMUtuTFJTd2xqOTVFMW1TUjByRkpjQjhMVUd6REt2UFNPM0JXN25ZRitS?= =?utf-8?B?bXNuaFJjOXFURTBRUE9TVVZKZU5ZbjBkVU9XN1gvdkRXYllNVEFJREZWUm01?= =?utf-8?B?TUNiU0Z0dk5WeVpseWh0d1lCaVh2Wkc5TWpZb1JhdFV3S2FUVWRBei85azNm?= =?utf-8?B?S0hLdzF4MENzSWloK2ZQMkJ3bTkybXhCbThaenFPMDZISTBiMys5bEdVQWxM?= =?utf-8?B?Q3pQV3RQRW1xcjhlVUc2SDBhWTFRU3F0eXk0eE9qY2MzcmhnMndRR0Y4Y3I1?= =?utf-8?B?bWp6cDdDQmtreWtjV1p2TlR1MTY1cWNuRU5xQ3RwZ2tOTHhWendNbFFhQ2F5?= =?utf-8?B?OU05RjFuYXZGNThON3gzVjJPTkI0TXNzKzJsSGhWU0JkMGZ0cTJVcm5YbVhP?= =?utf-8?B?blI3RmRLdXJaeEZOemlSbmpUdVpvMjA3TkpBK2JxQlZ3NUpoUTBjNVdiVnQx?= =?utf-8?B?WUpaYmlZcGlmWWV1Q2RvMFRvRVYvR2RHUXJZVjJ5OCtTRnlhTTU0T3cwWUxm?= =?utf-8?B?U0gwcFhKd1MxMDFKTkhJMkNTdVlTWEJocVJkQTZJWHZLU3M4UVFEZVhNcll1?= =?utf-8?B?YXZ3SHVNN2RGUDRBYmU4SnlVLzFJTGh1N3ZUamllUlpKUWphQXF6ZkFUYlBT?= =?utf-8?B?R2JnZ1c4NHFTUlhoSTZ3M3NwZXNWVExRSmlPNmRMZjRaRHlNUEJ2b0Y1Q0dN?= =?utf-8?B?RFhhTE9GOVRBL2R5VkdHN2FnQmlQbXJLY0RCazZEdGFNWXI2djBvUjJBUloy?= =?utf-8?B?R0k0RHpjUGxoZWo3K0ZGd25kZGN2SHVXVG0rNWROMHQ3amIxOU9FSmFRS0pQ?= =?utf-8?Q?0VUDoPhwuIsdgs4Ohf09U7NIi?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75dd04a8-b4e9-4bb0-514b-08db12b612c2 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Feb 2023 20:15:41.3160 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qn03vniP687qzu+HhR0I+w5DCRKy0pQiNmyi7LTVIqlnOEQTV8Cfa6zJAjhX6c9Z X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6429 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/19/2023 12:31 AM, Levend Sayar wrote: > Google Virtual NIC PMD is enriched with rx/tx queue statistics info. > > Signed-off-by: Levend Sayar > --- > drivers/net/gve/gve_ethdev.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c > index fef2458a16..2a6cb11da3 100644 > --- a/drivers/net/gve/gve_ethdev.c > +++ b/drivers/net/gve/gve_ethdev.c > @@ -213,6 +213,7 @@ gve_dev_start(struct rte_eth_dev *dev) > } > } > > + dev->data->dev_flags |= RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS; > dev->data->dev_started = 1; > gve_link_update(dev, 0); > > @@ -331,6 +332,9 @@ gve_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > stats->opackets += txq->packets; > stats->obytes += txq->bytes; > stats->oerrors += txq->errors; > + > + stats->q_opackets[i] = txq->packets; > + stats->q_obytes[i] = txq->bytes; > } > > for (i = 0; i < dev->data->nb_rx_queues; i++) { > @@ -342,6 +346,10 @@ gve_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > stats->ibytes += rxq->bytes; > stats->ierrors += rxq->errors; > stats->rx_nombuf += rxq->no_mbufs; > + > + stats->q_ipackets[i] = rxq->packets; > + stats->q_ibytes[i] = rxq->bytes; > + stats->q_errors[i] = rxq->errors; > } > > return 0; nack, as explained in other thread [1], we need to implement xstats in driver without relying on 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag. [1] https://inbox.dpdk.org/dev/0123d577-39f5-7213-07b3-04ef3918edda@amd.com/T/#u