From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B1850A0543;
	Tue,  4 Oct 2022 16:48:51 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 62B6940DFB;
	Tue,  4 Oct 2022 16:48:51 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 34C9440DDC
 for <dev@dpdk.org>; Tue,  4 Oct 2022 16:48:50 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id B58835D;
 Tue,  4 Oct 2022 17:48:49 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B58835D
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1664894929;
 bh=ETTuw7S4IeYUDSZbh1Di9APJDcbc5Wy6xZzirbni5zA=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=C0IRQY7sjWAiDKIes13Yovvt9wT/DVcUj9bJ2v+lVaBwxO4ajuowoMHYUby1/OG0x
 7IIDkxnwtxzctOkXDNd8lpNPxb9fpctcuzOhBE067cFHgZpruPjf95LFAfbecG+7cf
 I9uZfFo89yCR8oU7BPLKscyRE1OZiDwZibtZXghQ=
Message-ID: <de49555c-d609-108c-176f-f9292bbd03a5@oktetlabs.ru>
Date: Tue, 4 Oct 2022 17:48:49 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.0
Subject: Re: [PATCH v2 1/1] app/testpmd: add command line argument
 'nic-to-pmd-rx-metadata'
Content-Language: en-US
To: "Singh, Aman Deep" <aman.deep.singh@intel.com>,
 Hanumanth Pothula <hpothula@marvell.com>,
 Yuying Zhang <yuying.zhang@intel.com>
Cc: dev@dpdk.org
References: <20220801131338.1710737-1-hpothula@marvell.com>
 <20220802175151.2277437-1-hpothula@marvell.com>
 <b105688b-8327-425c-f435-3f1c4f04a9ba@intel.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <b105688b-8327-425c-f435-3f1c4f04a9ba@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 9/1/22 11:03, Singh, Aman Deep wrote:
> 
> 
> On 8/2/2022 11:21 PM, Hanumanth Pothula wrote:
>> Presently, rx metadata is sent to PMD by default, leading
>> to a performance drop as processing for the same in rx path
>> takes extra cycles.
>>
>> Hence, introducing command line argument, 'nic-to-pmd-rx-metadata'
>> to control passing rx metadata to PMD. By default it’s disabled.
>>
>> Signed-off-by: Hanumanth Pothula <hpothula@marvell.com>
> 
> Acked-by: Aman Singh <aman.deep.singh@intel.com>
> 
>> v2:
>> - taken cared alignment issues
>> - renamed command line argument from rx-metadata to 
>> nic-to-pmd-rx-metadata
>> - renamed variable name from rx-metadata to nic_to_pmd_rx_metadata
>> ---
>>
> 


Please, update doc/guides/testpmd_app_ug/testpmd_funcs.rst to
document the new command-line argument.

Also avoid argument name in the summary. It must be human-
readable.