From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F681A052A; Wed, 27 Jan 2021 12:34:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 332B3140CEF; Wed, 27 Jan 2021 12:34:09 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id D7FAD140CEE for ; Wed, 27 Jan 2021 12:34:07 +0100 (CET) IronPort-SDR: +4zSIeZl0HMLHk51Rqr3QCA3tQc4CD4dNSHbpH1QiQbikAWpK3S/teZgsq7xynA1X4jqwjybvl 3C/zNLbQOxkA== X-IronPort-AV: E=McAfee;i="6000,8403,9876"; a="180199344" X-IronPort-AV: E=Sophos;i="5.79,379,1602572400"; d="scan'208";a="180199344" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 03:34:06 -0800 IronPort-SDR: ES6EeG+JBYQQVhkUqJTXaP5z0Ke54+hM66rzLrzXoEAEGMs7IiMXyRFiTQRTU5wUIlQfwrDEFl wZcXEmixTA5Q== X-IronPort-AV: E=Sophos;i="5.79,379,1602572400"; d="scan'208";a="430071678" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.208.215]) ([10.213.208.215]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jan 2021 03:34:06 -0800 To: Qi Zhang , thomas@monjalon.net Cc: dev@dpdk.org References: <20210112114703.350878-1-qi.z.zhang@intel.com> <20210119031905.518082-1-qi.z.zhang@intel.com> From: Ferruh Yigit Message-ID: Date: Wed, 27 Jan 2021 11:34:04 +0000 MIME-Version: 1.0 In-Reply-To: <20210119031905.518082-1-qi.z.zhang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] ethdev: refine doxygen for add UDP tunnel port API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/19/2021 3:19 AM, Qi Zhang wrote: > Refine the doxygen for rte_eth_dev_udp_tunnel_port_add. > Add more detail description of the impacted offload functions. > > Signed-off-by: Qi Zhang > --- > > v2: > - reword doxygen that focus on API impact base on previous discussion. > > lib/librte_ethdev/rte_ethdev.h | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index f758ec837..ab50a7039 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -4031,6 +4031,17 @@ rte_eth_dev_rss_hash_conf_get(uint16_t port_id, > * to change or add more UDP port for the tunnel. So the offloading function > * can take effect on the packets with the specific UDP port. > * > + * The impacted offloading functions include: > + * > + * - A specific tunnel type in mbuf->packet_type > + * > + * - A rte_flow rule that matches on specific tunnel header > + * > + * NOTE: If a packet only has a matched UDP port but don't have a legal tunnel > + * header, the packet may still not be recognized as a tunnel packet by > + * the device parser, then the related offloading function will not take > + * effect. > + * > * @param port_id > * The port identifier of the Ethernet device. > * @param tunnel_udp > Hi Thomas, is the v2 good to go?